From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Cc: Jaegeuk Kim <jaegeuk@kernel.org>, Can Guo <cang@codeaurora.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>
Subject: [f2fs-dev] [PATCH v2 5/5] scsi: ufs: fix clkgating on/off correctly
Date: Tue, 20 Oct 2020 12:52:58 -0700 [thread overview]
Message-ID: <20201020195258.2005605-6-jaegeuk@kernel.org> (raw)
In-Reply-To: <20201020195258.2005605-1-jaegeuk@kernel.org>
The below call stack prevents clk_gating at every IO completion.
We can remove the condition, ufshcd_any_tag_in_use(), since clkgating_work
will check it again.
ufshcd_complete_requests(struct ufs_hba *hba)
ufshcd_transfer_req_compl()
__ufshcd_transfer_req_compl()
__ufshcd_release(hba)
if (ufshcd_any_tag_in_use() == 1)
return;
ufshcd_tmc_handler(hba);
blk_mq_tagset_busy_iter();
Cc: Alim Akhtar <alim.akhtar@samsung.com>
Cc: Avri Altman <avri.altman@wdc.com>
Cc: Can Guo <cang@codeaurora.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
drivers/scsi/ufs/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index b5ca0effe636..cecbd4ace8b4 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -1746,7 +1746,7 @@ static void __ufshcd_release(struct ufs_hba *hba)
if (hba->clk_gating.active_reqs || hba->clk_gating.is_suspended ||
hba->ufshcd_state != UFSHCD_STATE_OPERATIONAL ||
- ufshcd_any_tag_in_use(hba) || hba->outstanding_tasks ||
+ hba->outstanding_tasks ||
hba->active_uic_cmd || hba->uic_async_done)
return;
--
2.29.0.rc1.297.gfa9743e501-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>, Can Guo <cang@codeaurora.org>
Subject: [PATCH v2 5/5] scsi: ufs: fix clkgating on/off correctly
Date: Tue, 20 Oct 2020 12:52:58 -0700 [thread overview]
Message-ID: <20201020195258.2005605-6-jaegeuk@kernel.org> (raw)
In-Reply-To: <20201020195258.2005605-1-jaegeuk@kernel.org>
The below call stack prevents clk_gating at every IO completion.
We can remove the condition, ufshcd_any_tag_in_use(), since clkgating_work
will check it again.
ufshcd_complete_requests(struct ufs_hba *hba)
ufshcd_transfer_req_compl()
__ufshcd_transfer_req_compl()
__ufshcd_release(hba)
if (ufshcd_any_tag_in_use() == 1)
return;
ufshcd_tmc_handler(hba);
blk_mq_tagset_busy_iter();
Cc: Alim Akhtar <alim.akhtar@samsung.com>
Cc: Avri Altman <avri.altman@wdc.com>
Cc: Can Guo <cang@codeaurora.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
drivers/scsi/ufs/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index b5ca0effe636..cecbd4ace8b4 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -1746,7 +1746,7 @@ static void __ufshcd_release(struct ufs_hba *hba)
if (hba->clk_gating.active_reqs || hba->clk_gating.is_suspended ||
hba->ufshcd_state != UFSHCD_STATE_OPERATIONAL ||
- ufshcd_any_tag_in_use(hba) || hba->outstanding_tasks ||
+ hba->outstanding_tasks ||
hba->active_uic_cmd || hba->uic_async_done)
return;
--
2.29.0.rc1.297.gfa9743e501-goog
next prev parent reply other threads:[~2020-10-20 19:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 19:52 [f2fs-dev] propose some UFS fixes Jaegeuk Kim
2020-10-20 19:52 ` Jaegeuk Kim
2020-10-20 19:52 ` [f2fs-dev] [PATCH v2 1/5] scsi: ufs: atomic update for clkgating_enable Jaegeuk Kim
2020-10-20 19:52 ` Jaegeuk Kim
2020-10-21 2:05 ` [f2fs-dev] " Can Guo
2020-10-21 2:05 ` Can Guo
2020-10-21 4:41 ` [f2fs-dev] " jaegeuk
2020-10-21 4:41 ` jaegeuk
2020-10-20 19:52 ` [f2fs-dev] [PATCH v2 2/5] scsi: ufs: clear UAC for FFU and RPMB LUNs Jaegeuk Kim
2020-10-20 19:52 ` Jaegeuk Kim
2020-10-20 19:52 ` [f2fs-dev] [PATCH v2 3/5] scsi: ufs: use WQ_HIGHPRI for gating work Jaegeuk Kim
2020-10-20 19:52 ` Jaegeuk Kim
2020-10-21 0:57 ` [f2fs-dev] " Can Guo
2020-10-21 0:57 ` Can Guo
2020-10-21 4:52 ` [f2fs-dev] " jaegeuk
2020-10-21 4:52 ` jaegeuk
2020-10-20 19:52 ` [f2fs-dev] [PATCH v2 4/5] scsi: add more contexts in the ufs tracepoints Jaegeuk Kim
2020-10-20 19:52 ` Jaegeuk Kim
2020-10-20 19:52 ` Jaegeuk Kim [this message]
2020-10-20 19:52 ` [PATCH v2 5/5] scsi: ufs: fix clkgating on/off correctly Jaegeuk Kim
2020-10-21 2:00 ` [f2fs-dev] " Can Guo
2020-10-21 2:00 ` Can Guo
2020-10-21 4:52 ` [f2fs-dev] " jaegeuk
2020-10-21 4:52 ` jaegeuk
2020-10-21 6:05 ` [f2fs-dev] " Can Guo
2020-10-21 6:05 ` Can Guo
2020-10-23 0:53 ` [f2fs-dev] " Jaegeuk Kim
2020-10-23 0:53 ` Jaegeuk Kim
2020-10-26 3:12 ` [f2fs-dev] " Can Guo
2020-10-26 3:12 ` Can Guo
2020-10-26 6:19 ` [f2fs-dev] " Jaegeuk Kim
2020-10-26 6:19 ` Jaegeuk Kim
2020-10-26 18:47 ` [f2fs-dev] " asutoshd
2020-10-26 18:47 ` asutoshd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020195258.2005605-6-jaegeuk@kernel.org \
--to=jaegeuk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=cang@codeaurora.org \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.