All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm-bsp/corstone700-test-app: adding test recipe for systems comms
@ 2020-10-21 17:10 Abdellatif El Khlifi
  2020-10-21 17:23 ` [meta-arm] " Denys Dmytriyenko
  2020-10-25 15:01 ` Jon Mason
  0 siblings, 2 replies; 10+ messages in thread
From: Abdellatif El Khlifi @ 2020-10-21 17:10 UTC (permalink / raw)
  To: meta-arm, Lakshmi.Kailasanathan, Ross.Burton; +Cc: nd, Abdellatif El Khlifi

From: Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>

This commit provides a recipe that generates a Linux userspace
application used for testing the communication between Corstone700 cores.

Change-Id: I7c00653b0fcd6d9074510bbb70a838762aed0150
Signed-off-by: Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>
---
 .../corstone700-test-app_1.0.bb               | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb

diff --git a/meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb b/meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb
new file mode 100644
index 0000000..d2bfb19
--- /dev/null
+++ b/meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb
@@ -0,0 +1,21 @@
+SUMMARY = "CORSTONE700 systems communications tests"
+DESCRIPTION = "This is a Linux userspace tool to test the communication between Corstone700 cores"
+HOMEPAGE = "https://git.linaro.org/landing-teams/working/arm/test-apps.git"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://license.md;md5=e44b2531cd6ffe9dece394dbe988d9a0"
+
+SRC_URI = "git://git.linaro.org/landing-teams/working/arm/test-apps.git;protocol=https"
+SRCREV = "ecd93a275d11cf08f670a97783110bd698250963"
+PV .= "~git${SRCPV}"
+
+COMPATIBLE_MACHINE = "(corstone700)"
+
+S = "${WORKDIR}/git"
+
+do_compile() {
+    ${CC} ${S}/test-app.c ${CFLAGS} ${LDFLAGS} -o ${S}/test-app
+}
+
+do_install() {
+    install -D -p -m 0755 ${S}/test-app ${D}${bindir}/test-app
+}
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [meta-arm] [PATCH] arm-bsp/corstone700-test-app: adding test recipe for systems comms
  2020-10-21 17:10 [PATCH] arm-bsp/corstone700-test-app: adding test recipe for systems comms Abdellatif El Khlifi
@ 2020-10-21 17:23 ` Denys Dmytriyenko
  2020-10-21 18:39   ` Ross Burton
  2020-10-25 15:01 ` Jon Mason
  1 sibling, 1 reply; 10+ messages in thread
From: Denys Dmytriyenko @ 2020-10-21 17:23 UTC (permalink / raw)
  To: Abdellatif El Khlifi; +Cc: meta-arm, Lakshmi.Kailasanathan, Ross.Burton, nd

On Wed, Oct 21, 2020 at 06:10:33PM +0100, Abdellatif El Khlifi wrote:
> From: Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>
> 
> This commit provides a recipe that generates a Linux userspace
> application used for testing the communication between Corstone700 cores.
> 
> Change-Id: I7c00653b0fcd6d9074510bbb70a838762aed0150
> Signed-off-by: Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>
> ---
>  .../corstone700-test-app_1.0.bb               | 21 +++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb
> 
> diff --git a/meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb b/meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb
> new file mode 100644
> index 0000000..d2bfb19
> --- /dev/null
> +++ b/meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb
> @@ -0,0 +1,21 @@
> +SUMMARY = "CORSTONE700 systems communications tests"
> +DESCRIPTION = "This is a Linux userspace tool to test the communication between Corstone700 cores"
> +HOMEPAGE = "https://git.linaro.org/landing-teams/working/arm/test-apps.git"
> +LICENSE = "BSD-3-Clause"
> +LIC_FILES_CHKSUM = "file://license.md;md5=e44b2531cd6ffe9dece394dbe988d9a0"
> +
> +SRC_URI = "git://git.linaro.org/landing-teams/working/arm/test-apps.git;protocol=https"
> +SRCREV = "ecd93a275d11cf08f670a97783110bd698250963"
> +PV .= "~git${SRCPV}"

OpenEmbedded convention is to use "+git..."


> +
> +COMPATIBLE_MACHINE = "(corstone700)"
> +
> +S = "${WORKDIR}/git"
> +
> +do_compile() {
> +    ${CC} ${S}/test-app.c ${CFLAGS} ${LDFLAGS} -o ${S}/test-app
> +}
> +
> +do_install() {
> +    install -D -p -m 0755 ${S}/test-app ${D}${bindir}/test-app
> +}
> -- 
> 2.17.1
> 

> 
> 
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-arm] [PATCH] arm-bsp/corstone700-test-app: adding test recipe for systems comms
  2020-10-21 17:23 ` [meta-arm] " Denys Dmytriyenko
@ 2020-10-21 18:39   ` Ross Burton
  2020-10-21 18:58     ` Denys Dmytriyenko
  0 siblings, 1 reply; 10+ messages in thread
From: Ross Burton @ 2020-10-21 18:39 UTC (permalink / raw)
  To: Denys Dmytriyenko
  Cc: Abdellatif El Khlifi, meta-arm, Lakshmi.Kailasanathan,
	Ross Burton, nd

On Wed, 21 Oct 2020 at 18:23, Denys Dmytriyenko <denis@denix.org> wrote:
> > +PV .= "~git${SRCPV}"
>
> OpenEmbedded convention is to use "+git..."

+ and ~ have different behaviour, so the question is whether this SHA
is before or after the 1.0 release.

If the 1.0 release hasn't happened yet, ~ is correct.  If 1.0 has
already happened, + would be correct.

The lack of a 1.0 tag suggests that ~ is in fact the correct character to use.

( 1.0~1 < 1.0 < 1.0+1)

Ross

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-arm] [PATCH] arm-bsp/corstone700-test-app: adding test recipe for systems comms
  2020-10-21 18:39   ` Ross Burton
@ 2020-10-21 18:58     ` Denys Dmytriyenko
  2020-10-22 10:12       ` Abdellatif El Khlifi
  2020-10-22 14:03       ` Ross Burton
  0 siblings, 2 replies; 10+ messages in thread
From: Denys Dmytriyenko @ 2020-10-21 18:58 UTC (permalink / raw)
  To: Ross Burton
  Cc: Abdellatif El Khlifi, meta-arm, Lakshmi.Kailasanathan,
	Ross Burton, nd

On Wed, Oct 21, 2020 at 07:39:16PM +0100, Ross Burton wrote:
> On Wed, 21 Oct 2020 at 18:23, Denys Dmytriyenko <denis@denix.org> wrote:
> > > +PV .= "~git${SRCPV}"
> >
> > OpenEmbedded convention is to use "+git..."
> 
> + and ~ have different behaviour, so the question is whether this SHA
> is before or after the 1.0 release.
> 
> If the 1.0 release hasn't happened yet, ~ is correct.  If 1.0 has
> already happened, + would be correct.
> 
> The lack of a 1.0 tag suggests that ~ is in fact the correct character to use.
> 
> ( 1.0~1 < 1.0 < 1.0+1)

Yeah, I know this is Debian convention for things like -rc1

And OpenEmbedded convention for this case historically was 0.9+1.0-rc1

-- 
Denys

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-arm] [PATCH] arm-bsp/corstone700-test-app: adding test recipe for systems comms
  2020-10-21 18:58     ` Denys Dmytriyenko
@ 2020-10-22 10:12       ` Abdellatif El Khlifi
  2020-10-22 14:03       ` Ross Burton
  1 sibling, 0 replies; 10+ messages in thread
From: Abdellatif El Khlifi @ 2020-10-22 10:12 UTC (permalink / raw)
  To: Denys Dmytriyenko, Ross Burton
  Cc: meta-arm@lists.yoctoproject.org, Lakshmi Kailasanathan, nd

[-- Attachment #1: Type: text/plain, Size: 1416 bytes --]

The choice made to use ~ is because the 1.0 release hasn't happened yet.

This convention is already used under openembedded/meta-openembedded:

meta-oe/recipes-devtools/luajit/luajit_git.bb :

PV = "2.1.0~beta3-200809"
________________________________
From: Denys Dmytriyenko <denis@denix.org>
Sent: 21 October 2020 19:58
To: Ross Burton <ross@burtonini.com>
Cc: Abdellatif El Khlifi <Abdellatif.ElKhlifi@arm.com>; meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org>; Lakshmi Kailasanathan <Lakshmi.Kailasanathan@arm.com>; Ross Burton <Ross.Burton@arm.com>; nd <nd@arm.com>
Subject: Re: [meta-arm] [PATCH] arm-bsp/corstone700-test-app: adding test recipe for systems comms

On Wed, Oct 21, 2020 at 07:39:16PM +0100, Ross Burton wrote:
> On Wed, 21 Oct 2020 at 18:23, Denys Dmytriyenko <denis@denix.org> wrote:
> > > +PV .= "~git${SRCPV}"
> >
> > OpenEmbedded convention is to use "+git..."
>
> + and ~ have different behaviour, so the question is whether this SHA
> is before or after the 1.0 release.
>
> If the 1.0 release hasn't happened yet, ~ is correct.  If 1.0 has
> already happened, + would be correct.
>
> The lack of a 1.0 tag suggests that ~ is in fact the correct character to use.
>
> ( 1.0~1 < 1.0 < 1.0+1)

Yeah, I know this is Debian convention for things like -rc1

And OpenEmbedded convention for this case historically was 0.9+1.0-rc1

--
Denys

[-- Attachment #2: Type: text/html, Size: 2642 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-arm] [PATCH] arm-bsp/corstone700-test-app: adding test recipe for systems comms
  2020-10-21 18:58     ` Denys Dmytriyenko
  2020-10-22 10:12       ` Abdellatif El Khlifi
@ 2020-10-22 14:03       ` Ross Burton
  2020-10-22 21:45         ` Denys Dmytriyenko
  1 sibling, 1 reply; 10+ messages in thread
From: Ross Burton @ 2020-10-22 14:03 UTC (permalink / raw)
  To: Denys Dmytriyenko
  Cc: Abdellatif El Khlifi, meta-arm, Lakshmi.Kailasanathan,
	Ross Burton, nd

On Wed, 21 Oct 2020 at 19:59, Denys Dmytriyenko <denis@denix.org> wrote:

> Yeah, I know this is Debian convention for things like -rc1
>
> And OpenEmbedded convention for this case historically was 0.9+1.0-rc1

That was because historically we didn't have ~ support.  We do now.

Ross

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-arm] [PATCH] arm-bsp/corstone700-test-app: adding test recipe for systems comms
  2020-10-22 14:03       ` Ross Burton
@ 2020-10-22 21:45         ` Denys Dmytriyenko
  2020-10-23  8:25           ` Ross Burton
  0 siblings, 1 reply; 10+ messages in thread
From: Denys Dmytriyenko @ 2020-10-22 21:45 UTC (permalink / raw)
  To: Ross Burton
  Cc: Abdellatif El Khlifi, meta-arm, Lakshmi.Kailasanathan,
	Ross Burton, nd

On Thu, Oct 22, 2020 at 03:03:33PM +0100, Ross Burton wrote:
> On Wed, 21 Oct 2020 at 19:59, Denys Dmytriyenko <denis@denix.org> wrote:
> 
> > Yeah, I know this is Debian convention for things like -rc1
> >
> > And OpenEmbedded convention for this case historically was 0.9+1.0-rc1
> 
> That was because historically we didn't have ~ support.  We do now.

Oh, great! Is it supported by all package managers, including opkg?

-- 
Denys

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-arm] [PATCH] arm-bsp/corstone700-test-app: adding test recipe for systems comms
  2020-10-22 21:45         ` Denys Dmytriyenko
@ 2020-10-23  8:25           ` Ross Burton
  0 siblings, 0 replies; 10+ messages in thread
From: Ross Burton @ 2020-10-23  8:25 UTC (permalink / raw)
  To: Denys Dmytriyenko; +Cc: Abdellatif El Khlifi, meta-arm, Lakshmi.Kailasanathan

Yes, it was actually RPM that was the holdout.  See
meta/lib/oeqa/selftest/cases/package.py:VersionOrdering() which
exercises the logic for each package manager.

Ross

On Thu, 22 Oct 2020 at 22:45, Denys Dmytriyenko <denis@denix.org> wrote:
>
> On Thu, Oct 22, 2020 at 03:03:33PM +0100, Ross Burton wrote:
> > On Wed, 21 Oct 2020 at 19:59, Denys Dmytriyenko <denis@denix.org> wrote:
> >
> > > Yeah, I know this is Debian convention for things like -rc1
> > >
> > > And OpenEmbedded convention for this case historically was 0.9+1.0-rc1
> >
> > That was because historically we didn't have ~ support.  We do now.
>
> Oh, great! Is it supported by all package managers, including opkg?
>
> --
> Denys
>
> 
>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-arm] [PATCH] arm-bsp/corstone700-test-app: adding test recipe for systems comms
  2020-10-21 17:10 [PATCH] arm-bsp/corstone700-test-app: adding test recipe for systems comms Abdellatif El Khlifi
  2020-10-21 17:23 ` [meta-arm] " Denys Dmytriyenko
@ 2020-10-25 15:01 ` Jon Mason
  2020-10-26 11:17   ` Abdellatif El Khlifi
  1 sibling, 1 reply; 10+ messages in thread
From: Jon Mason @ 2020-10-25 15:01 UTC (permalink / raw)
  To: Abdellatif El Khlifi; +Cc: meta-arm, Lakshmi.Kailasanathan, Ross.Burton, nd

On Wed, Oct 21, 2020 at 06:10:33PM +0100, Abdellatif El Khlifi wrote:
> From: Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>
> 
> This commit provides a recipe that generates a Linux userspace
> application used for testing the communication between Corstone700 cores.
> 
> Change-Id: I7c00653b0fcd6d9074510bbb70a838762aed0150
> Signed-off-by: Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>

Pulled into master.

Thanks,
Jon

> ---
>  .../corstone700-test-app_1.0.bb               | 21 +++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb
> 
> diff --git a/meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb b/meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb
> new file mode 100644
> index 0000000..d2bfb19
> --- /dev/null
> +++ b/meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb
> @@ -0,0 +1,21 @@
> +SUMMARY = "CORSTONE700 systems communications tests"
> +DESCRIPTION = "This is a Linux userspace tool to test the communication between Corstone700 cores"
> +HOMEPAGE = "https://git.linaro.org/landing-teams/working/arm/test-apps.git"
> +LICENSE = "BSD-3-Clause"
> +LIC_FILES_CHKSUM = "file://license.md;md5=e44b2531cd6ffe9dece394dbe988d9a0"
> +
> +SRC_URI = "git://git.linaro.org/landing-teams/working/arm/test-apps.git;protocol=https"
> +SRCREV = "ecd93a275d11cf08f670a97783110bd698250963"
> +PV .= "~git${SRCPV}"
> +
> +COMPATIBLE_MACHINE = "(corstone700)"
> +
> +S = "${WORKDIR}/git"
> +
> +do_compile() {
> +    ${CC} ${S}/test-app.c ${CFLAGS} ${LDFLAGS} -o ${S}/test-app
> +}
> +
> +do_install() {
> +    install -D -p -m 0755 ${S}/test-app ${D}${bindir}/test-app
> +}
> -- 
> 2.17.1
> 

> 
> 
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-arm] [PATCH] arm-bsp/corstone700-test-app: adding test recipe for systems comms
  2020-10-25 15:01 ` Jon Mason
@ 2020-10-26 11:17   ` Abdellatif El Khlifi
  0 siblings, 0 replies; 10+ messages in thread
From: Abdellatif El Khlifi @ 2020-10-26 11:17 UTC (permalink / raw)
  To: Jon Mason
  Cc: meta-arm@lists.yoctoproject.org, Lakshmi Kailasanathan,
	Ross Burton, nd

[-- Attachment #1: Type: text/plain, Size: 2291 bytes --]

Great. Thanks Jon.
________________________________
From: Jon Mason <jdmason@kudzu.us>
Sent: 25 October 2020 15:01
To: Abdellatif El Khlifi <Abdellatif.ElKhlifi@arm.com>
Cc: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org>; Lakshmi Kailasanathan <Lakshmi.Kailasanathan@arm.com>; Ross Burton <Ross.Burton@arm.com>; nd <nd@arm.com>
Subject: Re: [meta-arm] [PATCH] arm-bsp/corstone700-test-app: adding test recipe for systems comms

On Wed, Oct 21, 2020 at 06:10:33PM +0100, Abdellatif El Khlifi wrote:
> From: Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>
>
> This commit provides a recipe that generates a Linux userspace
> application used for testing the communication between Corstone700 cores.
>
> Change-Id: I7c00653b0fcd6d9074510bbb70a838762aed0150
> Signed-off-by: Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>

Pulled into master.

Thanks,
Jon

> ---
>  .../corstone700-test-app_1.0.bb               | 21 +++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb
>
> diff --git a/meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb b/meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb
> new file mode 100644
> index 0000000..d2bfb19
> --- /dev/null
> +++ b/meta-arm-bsp/recipes-test/corstone700-test-app/corstone700-test-app_1.0.bb
> @@ -0,0 +1,21 @@
> +SUMMARY = "CORSTONE700 systems communications tests"
> +DESCRIPTION = "This is a Linux userspace tool to test the communication between Corstone700 cores"
> +HOMEPAGE = "https://git.linaro.org/landing-teams/working/arm/test-apps.git"
> +LICENSE = "BSD-3-Clause"
> +LIC_FILES_CHKSUM = "file://license.md;md5=e44b2531cd6ffe9dece394dbe988d9a0"
> +
> +SRC_URI = "git://git.linaro.org/landing-teams/working/arm/test-apps.git;protocol=https"
> +SRCREV = "ecd93a275d11cf08f670a97783110bd698250963"
> +PV .= "~git${SRCPV}"
> +
> +COMPATIBLE_MACHINE = "(corstone700)"
> +
> +S = "${WORKDIR}/git"
> +
> +do_compile() {
> +    ${CC} ${S}/test-app.c ${CFLAGS} ${LDFLAGS} -o ${S}/test-app
> +}
> +
> +do_install() {
> +    install -D -p -m 0755 ${S}/test-app ${D}${bindir}/test-app
> +}
> --
> 2.17.1
>

>
> 
>


[-- Attachment #2: Type: text/html, Size: 3769 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-10-26 11:18 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-21 17:10 [PATCH] arm-bsp/corstone700-test-app: adding test recipe for systems comms Abdellatif El Khlifi
2020-10-21 17:23 ` [meta-arm] " Denys Dmytriyenko
2020-10-21 18:39   ` Ross Burton
2020-10-21 18:58     ` Denys Dmytriyenko
2020-10-22 10:12       ` Abdellatif El Khlifi
2020-10-22 14:03       ` Ross Burton
2020-10-22 21:45         ` Denys Dmytriyenko
2020-10-23  8:25           ` Ross Burton
2020-10-25 15:01 ` Jon Mason
2020-10-26 11:17   ` Abdellatif El Khlifi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.