All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Russell King <linux@armlinux.org.uk>,
	Kees Cook <keescook@chromium.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1] ARM: vfp: Use long jump to fix THUMB2 kernel compilation error
Date: Thu, 22 Oct 2020 01:57:37 +0300	[thread overview]
Message-ID: <20201021225737.739-1-digetx@gmail.com> (raw)

The vfp_kmode_exception() function now is unreachable using relative
branching in THUMB2 kernel configuration, resulting in a "relocation
truncated to fit: R_ARM_THM_JUMP19 against symbol `vfp_kmode_exception'"
linker error. Let's use long jump in order to fix the issue.

Fixes: eff8728fe698 ("vmlinux.lds.h: Add PGO and AutoFDO input sections")
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/arm/vfp/vfphw.S | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/vfp/vfphw.S b/arch/arm/vfp/vfphw.S
index 4fcff9f59947..6e2b29f0c48d 100644
--- a/arch/arm/vfp/vfphw.S
+++ b/arch/arm/vfp/vfphw.S
@@ -82,7 +82,8 @@ ENTRY(vfp_support_entry)
 	ldr	r3, [sp, #S_PSR]	@ Neither lazy restore nor FP exceptions
 	and	r3, r3, #MODE_MASK	@ are supported in kernel mode
 	teq	r3, #USR_MODE
-	bne	vfp_kmode_exception	@ Returns through lr
+	ldr	r1, =vfp_kmode_exception
+	bxne	r1			@ Returns through lr
 
 	VFPFMRX	r1, FPEXC		@ Is the VFP enabled?
 	DBGSTR1	"fpexc %08x", r1
-- 
2.27.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Russell King <linux@armlinux.org.uk>,
	Kees Cook <keescook@chromium.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Ingo Molnar <mingo@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1] ARM: vfp: Use long jump to fix THUMB2 kernel compilation error
Date: Thu, 22 Oct 2020 01:57:37 +0300	[thread overview]
Message-ID: <20201021225737.739-1-digetx@gmail.com> (raw)

The vfp_kmode_exception() function now is unreachable using relative
branching in THUMB2 kernel configuration, resulting in a "relocation
truncated to fit: R_ARM_THM_JUMP19 against symbol `vfp_kmode_exception'"
linker error. Let's use long jump in order to fix the issue.

Fixes: eff8728fe698 ("vmlinux.lds.h: Add PGO and AutoFDO input sections")
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/arm/vfp/vfphw.S | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/vfp/vfphw.S b/arch/arm/vfp/vfphw.S
index 4fcff9f59947..6e2b29f0c48d 100644
--- a/arch/arm/vfp/vfphw.S
+++ b/arch/arm/vfp/vfphw.S
@@ -82,7 +82,8 @@ ENTRY(vfp_support_entry)
 	ldr	r3, [sp, #S_PSR]	@ Neither lazy restore nor FP exceptions
 	and	r3, r3, #MODE_MASK	@ are supported in kernel mode
 	teq	r3, #USR_MODE
-	bne	vfp_kmode_exception	@ Returns through lr
+	ldr	r1, =vfp_kmode_exception
+	bxne	r1			@ Returns through lr
 
 	VFPFMRX	r1, FPEXC		@ Is the VFP enabled?
 	DBGSTR1	"fpexc %08x", r1
-- 
2.27.0


             reply	other threads:[~2020-10-21 23:03 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-21 22:57 Dmitry Osipenko [this message]
2020-10-21 22:57 ` [PATCH v1] ARM: vfp: Use long jump to fix THUMB2 kernel compilation error Dmitry Osipenko
2020-10-21 23:40 ` Kees Cook
2020-10-21 23:40   ` Kees Cook
2020-10-22  0:00   ` Dmitry Osipenko
2020-10-22  0:00     ` Dmitry Osipenko
2020-10-22  3:28     ` Kees Cook
2020-10-22  3:28       ` Kees Cook
2020-10-22  7:06       ` Ard Biesheuvel
2020-10-22  7:06         ` Ard Biesheuvel
2020-10-22 15:57         ` Dmitry Osipenko
2020-10-22 15:57           ` Dmitry Osipenko
2020-10-22 16:06           ` Ard Biesheuvel
2020-10-22 16:06             ` Ard Biesheuvel
2020-10-22 16:11             ` Russell King - ARM Linux admin
2020-10-22 16:11               ` Russell King - ARM Linux admin
2020-10-22 16:20               ` Ard Biesheuvel
2020-10-22 16:20                 ` Ard Biesheuvel
2020-10-22 16:23                 ` Russell King - ARM Linux admin
2020-10-22 16:23                   ` Russell King - ARM Linux admin
2020-10-22 16:33                   ` Ard Biesheuvel
2020-10-22 16:33                     ` Ard Biesheuvel
2020-10-22 17:48                     ` Russell King - ARM Linux admin
2020-10-22 17:48                       ` Russell King - ARM Linux admin
2020-10-22 17:59                       ` Ard Biesheuvel
2020-10-22 17:59                         ` Ard Biesheuvel
2020-10-26  8:58                         ` Ard Biesheuvel
2020-10-26  8:58                           ` Ard Biesheuvel
2020-10-29  9:56                           ` Ard Biesheuvel
2020-10-29  9:56                             ` Ard Biesheuvel
2020-11-03  7:24                             ` Ard Biesheuvel
2020-11-03  7:24                               ` Ard Biesheuvel
2020-11-03  8:43                               ` Dmitry Osipenko
2020-11-03  8:43                                 ` Dmitry Osipenko
2020-11-09  7:25                                 ` Ard Biesheuvel
2020-11-09  7:25                                   ` Ard Biesheuvel
2020-11-10  7:44                                   ` Dmitry Osipenko
2020-11-10  7:44                                     ` Dmitry Osipenko
2020-11-10  7:45                                     ` Ard Biesheuvel
2020-11-10  7:45                                       ` Ard Biesheuvel
2020-10-22 16:34                   ` Dmitry Osipenko
2020-10-22 16:34                     ` Dmitry Osipenko
2020-10-22 17:38                     ` Russell King - ARM Linux admin
2020-10-22 17:38                       ` Russell King - ARM Linux admin
2020-10-22 17:47                       ` Ard Biesheuvel
2020-10-22 17:47                         ` Ard Biesheuvel
2020-10-22 17:50                         ` Russell King - ARM Linux admin
2020-10-22 17:50                           ` Russell King - ARM Linux admin
2020-10-22 17:51                           ` Ard Biesheuvel
2020-10-22 17:51                             ` Ard Biesheuvel
2020-10-22 19:05                       ` Dmitry Osipenko
2020-10-22 19:05                         ` Dmitry Osipenko
2020-10-22 14:57 ` Russell King - ARM Linux admin
2020-10-22 14:57   ` Russell King - ARM Linux admin
2020-10-22 15:56   ` Dmitry Osipenko
2020-10-22 15:56     ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201021225737.739-1-digetx@gmail.com \
    --to=digetx@gmail.com \
    --cc=keescook@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mingo@kernel.org \
    --cc=ndesaulniers@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.