Re: [PATCH v4] x86: add failure injection to get/put/clear_user

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 6935 bytes --]

Hi Alexander,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/master]
[also build test WARNING on next-20201023]
[cannot apply to tip/x86/core hnaz-linux-mm/master v5.9]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Alexander-Potapenko/x86-add-failure-injection-to-get-put-clear_user/20201023-161920
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 95d591cca3b1851eaf66af066149183f18ff5ab3
config: i386-randconfig-s002-20201023 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-17-g2d3af347-dirty
        # https://github.com/0day-ci/linux/commit/fde54c64ea35d06708ec79201776bedb1533cb91
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Alexander-Potapenko/x86-add-failure-injection-to-get-put-clear_user/20201023-161920
        git checkout fde54c64ea35d06708ec79201776bedb1533cb91
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
>> arch/x86/events/core.c:2668:21: sparse: sparse: Using plain integer as NULL pointer
--
>> arch/x86/kernel/stacktrace.c:104:13: sparse: sparse: Using plain integer as NULL pointer

vim +2668 arch/x86/events/core.c

d7d59fb3238336 arch/x86/kernel/cpu/perf_counter.c Peter Zijlstra           2009-03-30  2635  
56962b4449af34 arch/x86/kernel/cpu/perf_event.c   Frederic Weisbecker      2010-06-30  2636  void
cfbcf468454ab4 arch/x86/events/core.c             Arnaldo Carvalho de Melo 2016-04-28  2637  perf_callchain_user(struct perf_callchain_entry_ctx *entry, struct pt_regs *regs)
d7d59fb3238336 arch/x86/kernel/cpu/perf_counter.c Peter Zijlstra           2009-03-30  2638  {
d7d59fb3238336 arch/x86/kernel/cpu/perf_counter.c Peter Zijlstra           2009-03-30  2639  	struct stack_frame frame;
c8e3dd86600a1a arch/x86/events/core.c             Al Viro                  2020-02-15  2640  	const struct stack_frame __user *fp;
d7d59fb3238336 arch/x86/kernel/cpu/perf_counter.c Peter Zijlstra           2009-03-30  2641  
927c7a9e92c4f6 arch/x86/kernel/cpu/perf_event.c   Frederic Weisbecker      2010-07-01  2642  	if (perf_guest_cbs && perf_guest_cbs->is_in_guest()) {
927c7a9e92c4f6 arch/x86/kernel/cpu/perf_event.c   Frederic Weisbecker      2010-07-01  2643  		/* TODO: We don't support guest os callchain now */
ed8052616680e7 arch/x86/kernel/cpu/perf_event.c   Peter Zijlstra           2010-08-20  2644  		return;
927c7a9e92c4f6 arch/x86/kernel/cpu/perf_event.c   Frederic Weisbecker      2010-07-01  2645  	}
5a6cec3abbdb74 arch/x86/kernel/cpu/perf_counter.c Ingo Molnar              2009-05-29  2646  
d07bdfd322d307 arch/x86/kernel/cpu/perf_event.c   Peter Zijlstra           2012-07-10  2647  	/*
d07bdfd322d307 arch/x86/kernel/cpu/perf_event.c   Peter Zijlstra           2012-07-10  2648  	 * We don't know what to do with VM86 stacks.. ignore them for now.
d07bdfd322d307 arch/x86/kernel/cpu/perf_event.c   Peter Zijlstra           2012-07-10  2649  	 */
d07bdfd322d307 arch/x86/kernel/cpu/perf_event.c   Peter Zijlstra           2012-07-10  2650  	if (regs->flags & (X86_VM_MASK | PERF_EFLAGS_VM))
d07bdfd322d307 arch/x86/kernel/cpu/perf_event.c   Peter Zijlstra           2012-07-10  2651  		return;
d07bdfd322d307 arch/x86/kernel/cpu/perf_event.c   Peter Zijlstra           2012-07-10  2652  
c8e3dd86600a1a arch/x86/events/core.c             Al Viro                  2020-02-15  2653  	fp = (void __user *)regs->bp;
d7d59fb3238336 arch/x86/kernel/cpu/perf_counter.c Peter Zijlstra           2009-03-30  2654  
70791ce9ba68a5 arch/x86/kernel/cpu/perf_event.c   Frederic Weisbecker      2010-06-29  2655  	perf_callchain_store(entry, regs->ip);
d7d59fb3238336 arch/x86/kernel/cpu/perf_counter.c Peter Zijlstra           2009-03-30  2656  
4012e77a903d11 arch/x86/events/core.c             Andy Lutomirski          2018-08-29  2657  	if (!nmi_uaccess_okay())
20afc60f892d28 arch/x86/kernel/cpu/perf_event.c   Andrey Vagin             2011-08-30  2658  		return;
20afc60f892d28 arch/x86/kernel/cpu/perf_event.c   Andrey Vagin             2011-08-30  2659  
257ef9d21f1b00 arch/x86/kernel/cpu/perf_event.c   Torok Edwin              2010-03-17  2660  	if (perf_callchain_user32(regs, entry))
257ef9d21f1b00 arch/x86/kernel/cpu/perf_event.c   Torok Edwin              2010-03-17  2661  		return;
257ef9d21f1b00 arch/x86/kernel/cpu/perf_event.c   Torok Edwin              2010-03-17  2662  
75925e1ad7f5a4 arch/x86/kernel/cpu/perf_event.c   Andi Kleen               2015-10-22  2663  	pagefault_disable();
3b1fff08038bd0 arch/x86/events/core.c             Arnaldo Carvalho de Melo 2016-05-10  2664  	while (entry->nr < entry->max_stack) {
ae31fe51a3ccea arch/x86/events/core.c             Johannes Weiner          2016-11-22  2665  		if (!valid_user_frame(fp, sizeof(frame)))
75925e1ad7f5a4 arch/x86/kernel/cpu/perf_event.c   Andi Kleen               2015-10-22  2666  			break;
75925e1ad7f5a4 arch/x86/kernel/cpu/perf_event.c   Andi Kleen               2015-10-22  2667  
c8e3dd86600a1a arch/x86/events/core.c             Al Viro                  2020-02-15 @2668  		if (__get_user(frame.next_frame, &fp->next_frame))
75925e1ad7f5a4 arch/x86/kernel/cpu/perf_event.c   Andi Kleen               2015-10-22  2669  			break;
c8e3dd86600a1a arch/x86/events/core.c             Al Viro                  2020-02-15  2670  		if (__get_user(frame.return_address, &fp->return_address))
d7d59fb3238336 arch/x86/kernel/cpu/perf_counter.c Peter Zijlstra           2009-03-30  2671  			break;
d7d59fb3238336 arch/x86/kernel/cpu/perf_counter.c Peter Zijlstra           2009-03-30  2672  
70791ce9ba68a5 arch/x86/kernel/cpu/perf_event.c   Frederic Weisbecker      2010-06-29  2673  		perf_callchain_store(entry, frame.return_address);
75925e1ad7f5a4 arch/x86/kernel/cpu/perf_event.c   Andi Kleen               2015-10-22  2674  		fp = (void __user *)frame.next_frame;
d7d59fb3238336 arch/x86/kernel/cpu/perf_counter.c Peter Zijlstra           2009-03-30  2675  	}
75925e1ad7f5a4 arch/x86/kernel/cpu/perf_event.c   Andi Kleen               2015-10-22  2676  	pagefault_enable();
d7d59fb3238336 arch/x86/kernel/cpu/perf_counter.c Peter Zijlstra           2009-03-30  2677  }
d7d59fb3238336 arch/x86/kernel/cpu/perf_counter.c Peter Zijlstra           2009-03-30  2678  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33322 bytes --]