Re: [PATCH 05/13] drm/ttm: new TT backend allocation pool

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3779 bytes --]

Hi "Christian,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-tip/drm-tip]
[cannot apply to drm-exynos/exynos-drm-next drm-intel/for-linux-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.9 next-20201023]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Christian-K-nig/drm-ttm-nuke-ttm_tt_set_-un-populated-again/20201026-004114
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: arc-randconfig-r024-20201026 (attached as .config)
compiler: arc-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/618def1bc3db379a76b7462ab38236bfeb3df3d3
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Christian-K-nig/drm-ttm-nuke-ttm_tt_set_-un-populated-again/20201026-004114
        git checkout 618def1bc3db379a76b7462ab38236bfeb3df3d3
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/ttm/ttm_pool.c:154:5: warning: no previous prototype for 'ttm_pool_apply_caching' [-Wmissing-prototypes]
     154 | int ttm_pool_apply_caching(struct page **first, struct page **last,
         |     ^~~~~~~~~~~~~~~~~~~~~~
   In file included from include/linux/list.h:9,
                    from include/linux/module.h:12,
                    from drivers/gpu/drm/ttm/ttm_pool.c:33:
   drivers/gpu/drm/ttm/ttm_pool.c: In function 'ttm_pool_alloc':
   include/linux/kernel.h:850:29: warning: comparison of distinct pointer types lacks a cast
     850 |   (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
         |                             ^~
   include/linux/kernel.h:864:4: note: in expansion of macro '__typecheck'
     864 |   (__typecheck(x, y) && __no_side_effects(x, y))
         |    ^~~~~~~~~~~
   include/linux/kernel.h:874:24: note: in expansion of macro '__safe_cmp'
     874 |  __builtin_choose_expr(__safe_cmp(x, y), \
         |                        ^~~~~~~~~~
   include/linux/kernel.h:883:19: note: in expansion of macro '__careful_cmp'
     883 | #define min(x, y) __careful_cmp(x, y, <)
         |                   ^~~~~~~~~~~~~
   drivers/gpu/drm/ttm/ttm_pool.c:378:15: note: in expansion of macro 'min'
     378 |  for (order = min(MAX_ORDER - 1UL, __fls(num_pages)); num_pages;
         |               ^~~

vim +/ttm_pool_apply_caching +154 drivers/gpu/drm/ttm/ttm_pool.c

   152	
   153	/* Apply a new caching to an array of pages */
 > 154	int ttm_pool_apply_caching(struct page **first, struct page **last,
   155				   enum ttm_caching caching)
   156	{
   157	#ifdef CONFIG_X86
   158		unsigned int num_pages = last - first;
   159	
   160		if (!num_pages)
   161			return 0;
   162	
   163		switch (caching) {
   164		case ttm_cached:
   165			break;
   166		case ttm_write_combined:
   167			return set_pages_array_wc(first, num_pages);
   168			break;
   169		case ttm_uncached:
   170			return set_pages_array_uc(first, num_pages);
   171			break;
   172		}
   173	#endif
   174		return 0;
   175	}
   176	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27899 bytes --]