drivers/net/xen-netback/interface.c:170:49: sparse: sparse: dubious: !x | !y

drivers/net/xen-netback/interface.c:170:49: sparse: sparse: dubious: !x | !y

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2941 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Juergen Gross <jgross@suse.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Wei Liu <wl@xen.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   986b9eacb25910865b50e5f298aa8e2df7642f1b
commit: 23025393dbeb3b8b3b60ebfa724cdae384992e27 xen/netback: use lateeoi irq binding
date:   6 days ago
:::::: branch date: 2 hours ago
:::::: commit date: 6 days ago
config: x86_64-randconfig-s031-20201026 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-56-gc09e8239-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=23025393dbeb3b8b3b60ebfa724cdae384992e27
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 23025393dbeb3b8b3b60ebfa724cdae384992e27
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
>> drivers/net/xen-netback/interface.c:170:49: sparse: sparse: dubious: !x | !y

vim +170 drivers/net/xen-netback/interface.c

f942dc2552b8bf Ian Campbell  2011-03-15  160  
f51de24356e49e Zoltan Kiss   2014-07-08  161  irqreturn_t xenvif_interrupt(int irq, void *dev_id)
e1f00a69ec26e3 Wei Liu       2013-05-22  162  {
23025393dbeb3b Juergen Gross 2020-09-07  163  	struct xenvif_queue *queue = dev_id;
23025393dbeb3b Juergen Gross 2020-09-07  164  	int old;
23025393dbeb3b Juergen Gross 2020-09-07  165  
23025393dbeb3b Juergen Gross 2020-09-07  166  	old = atomic_fetch_or(NETBK_COMMON_EOI, &queue->eoi_pending);
23025393dbeb3b Juergen Gross 2020-09-07  167  	WARN(old, "Interrupt while EOI pending\n");
23025393dbeb3b Juergen Gross 2020-09-07  168  
23025393dbeb3b Juergen Gross 2020-09-07  169  	/* Use bitwise or as we need to call both functions. */
23025393dbeb3b Juergen Gross 2020-09-07 @170  	if ((!xenvif_handle_tx_interrupt(queue) |
23025393dbeb3b Juergen Gross 2020-09-07  171  	     !xenvif_handle_rx_interrupt(queue))) {
23025393dbeb3b Juergen Gross 2020-09-07  172  		atomic_andnot(NETBK_COMMON_EOI, &queue->eoi_pending);
23025393dbeb3b Juergen Gross 2020-09-07  173  		xen_irq_lateeoi(irq, XEN_EOI_FLAG_SPURIOUS);
23025393dbeb3b Juergen Gross 2020-09-07  174  	}
e1f00a69ec26e3 Wei Liu       2013-05-22  175  
e1f00a69ec26e3 Wei Liu       2013-05-22  176  	return IRQ_HANDLED;
e1f00a69ec26e3 Wei Liu       2013-05-22  177  }
e1f00a69ec26e3 Wei Liu       2013-05-22  178  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36389 bytes --]