All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Subject: [PATCH 0/4] crypto: testmgr - always print the actual driver name
Date: Mon, 26 Oct 2020 09:16:58 -0700	[thread overview]
Message-ID: <20201026161702.39201-1-ebiggers@kernel.org> (raw)

When alg_test() is called from tcrypt.ko rather than from the algorithm
registration code, "driver" is actually the algorithm name, not the
driver name.  So it shouldn't be used in places where a driver name is
wanted, e.g. when reporting a test failure or when checking whether the
driver is the generic driver or not.

See https://lkml.kernel.org/r/20200910122248.GA22506@Red for an example
where this caused a problem.  The self-tests reported "alg: ahash: md5
test failed", but it wasn't mentioned which md5 implementation it was.

Fix this by getting the driver name from the crypto tfm object that
actually got allocated.

Eric Biggers (4):
  crypto: aead - add crypto_aead_driver_name()
  crypto: testmgr - always print the actual hash driver name
  crypto: testmgr - always print the actual AEAD driver name
  crypto: testmgr - always print the actual skcipher driver name

 crypto/testmgr.c      | 121 +++++++++++++++++++-----------------------
 include/crypto/aead.h |   5 ++
 2 files changed, 59 insertions(+), 67 deletions(-)


base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec
-- 
2.29.1


             reply	other threads:[~2020-10-26 16:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 16:16 Eric Biggers [this message]
2020-10-26 16:16 ` [PATCH 1/4] crypto: aead - add crypto_aead_driver_name() Eric Biggers
2020-10-26 16:17 ` [PATCH 2/4] crypto: testmgr - always print the actual hash driver name Eric Biggers
2020-10-26 16:17 ` [PATCH 3/4] crypto: testmgr - always print the actual AEAD " Eric Biggers
2020-10-26 16:17 ` [PATCH 4/4] crypto: testmgr - always print the actual skcipher " Eric Biggers
2020-11-06  7:00 ` [PATCH 0/4] crypto: testmgr - always print the actual " Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201026161702.39201-1-ebiggers@kernel.org \
    --to=ebiggers@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.