All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	Mike Snitzer <snitzer@redhat.com>,
	linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
	Song Liu <song@kernel.org>,
	dm-devel@redhat.com, linux-crypto@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Alasdair Kergon <agk@redhat.com>, Ofir Drang <ofir.drang@arm.com>
Subject: Re: [dm-devel] [PATCH 3/4] dm crypt: switch to EBOIV crypto API template
Date: Mon, 26 Oct 2020 10:52:31 -0700	[thread overview]
Message-ID: <20201026175231.GG858@sol.localdomain> (raw)
In-Reply-To: <20201026130450.6947-4-gilad@benyossef.com>

On Mon, Oct 26, 2020 at 03:04:46PM +0200, Gilad Ben-Yossef wrote:
> Replace the explicit EBOIV handling in the dm-crypt driver with calls
> into the crypto API, which now possesses the capability to perform
> this processing within the crypto subsystem.
> 
> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
> 
> ---
>  drivers/md/Kconfig    |  1 +
>  drivers/md/dm-crypt.c | 61 ++++++++++++++-----------------------------
>  2 files changed, 20 insertions(+), 42 deletions(-)
> 
> diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
> index 30ba3573626c..ca6e56a72281 100644
> --- a/drivers/md/Kconfig
> +++ b/drivers/md/Kconfig
> @@ -273,6 +273,7 @@ config DM_CRYPT
>  	select CRYPTO
>  	select CRYPTO_CBC
>  	select CRYPTO_ESSIV
> +	select CRYPTO_EBOIV
>  	help
>  	  This device-mapper target allows you to create a device that
>  	  transparently encrypts the data on it. You'll need to activate

Can CRYPTO_EBOIV please not be selected by default?  If someone really wants
Bitlocker compatibility support, they can select this option themselves.

- Eric

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel


WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com, Song Liu <song@kernel.org>,
	Ofir Drang <ofir.drang@arm.com>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-raid@vger.kernel.org
Subject: Re: [PATCH 3/4] dm crypt: switch to EBOIV crypto API template
Date: Mon, 26 Oct 2020 10:52:31 -0700	[thread overview]
Message-ID: <20201026175231.GG858@sol.localdomain> (raw)
In-Reply-To: <20201026130450.6947-4-gilad@benyossef.com>

On Mon, Oct 26, 2020 at 03:04:46PM +0200, Gilad Ben-Yossef wrote:
> Replace the explicit EBOIV handling in the dm-crypt driver with calls
> into the crypto API, which now possesses the capability to perform
> this processing within the crypto subsystem.
> 
> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
> 
> ---
>  drivers/md/Kconfig    |  1 +
>  drivers/md/dm-crypt.c | 61 ++++++++++++++-----------------------------
>  2 files changed, 20 insertions(+), 42 deletions(-)
> 
> diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
> index 30ba3573626c..ca6e56a72281 100644
> --- a/drivers/md/Kconfig
> +++ b/drivers/md/Kconfig
> @@ -273,6 +273,7 @@ config DM_CRYPT
>  	select CRYPTO
>  	select CRYPTO_CBC
>  	select CRYPTO_ESSIV
> +	select CRYPTO_EBOIV
>  	help
>  	  This device-mapper target allows you to create a device that
>  	  transparently encrypts the data on it. You'll need to activate

Can CRYPTO_EBOIV please not be selected by default?  If someone really wants
Bitlocker compatibility support, they can select this option themselves.

- Eric

  reply	other threads:[~2020-10-26 18:00 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 13:04 [dm-devel] [PATCH 0/4] crypto: switch to crypto API for EBOIV generation Gilad Ben-Yossef
2020-10-26 13:04 ` Gilad Ben-Yossef
2020-10-26 13:04 ` [dm-devel] [PATCH 1/4] crypto: add eboiv as a crypto API template Gilad Ben-Yossef
2020-10-26 13:04   ` Gilad Ben-Yossef
2020-10-26 18:24   ` [dm-devel] " Eric Biggers
2020-10-26 18:24     ` Eric Biggers
2020-10-26 18:26     ` [dm-devel] " Eric Biggers
2020-10-26 18:26       ` Eric Biggers
2020-10-27  6:53       ` [dm-devel] " Gilad Ben-Yossef
2020-10-27  6:53         ` Gilad Ben-Yossef
2020-10-26 13:04 ` [dm-devel] [PATCH 2/4] crypto: add eboiv(cbc(aes)) test vectors Gilad Ben-Yossef
2020-10-26 13:04   ` Gilad Ben-Yossef
2020-10-26 13:04 ` [dm-devel] [PATCH 3/4] dm crypt: switch to EBOIV crypto API template Gilad Ben-Yossef
2020-10-26 13:04   ` Gilad Ben-Yossef
2020-10-26 17:52   ` Eric Biggers [this message]
2020-10-26 17:52     ` Eric Biggers
2020-10-26 18:29     ` [dm-devel] " Milan Broz
2020-10-26 18:29       ` Milan Broz
2020-10-26 18:39       ` [dm-devel] " Eric Biggers
2020-10-26 18:39         ` Eric Biggers
2020-10-26 18:41         ` [dm-devel] " Herbert Xu
2020-10-26 18:41           ` Herbert Xu
2020-10-26 18:44           ` [dm-devel] " Herbert Xu
2020-10-26 18:44             ` Herbert Xu
2020-10-28 11:41             ` [dm-devel] " Gilad Ben-Yossef
2020-10-28 11:41               ` Gilad Ben-Yossef
2020-10-29  3:54               ` [dm-devel] " Herbert Xu
2020-10-29  3:54                 ` Herbert Xu
2020-10-26 19:04         ` [dm-devel] " Milan Broz
2020-10-26 19:04           ` Milan Broz
2020-10-27  6:59           ` [dm-devel] " Gilad Ben-Yossef
2020-10-27  6:59             ` Gilad Ben-Yossef
2020-10-27 13:05             ` [dm-devel] " Milan Broz
2020-10-27 13:05               ` Milan Broz
2020-10-26 18:19   ` [dm-devel] " kernel test robot
2020-10-26 18:19     ` kernel test robot
2020-10-26 18:19     ` kernel test robot
2020-10-26 13:04 ` [dm-devel] [PATCH 4/4] crypto: ccree: re-introduce ccree eboiv support Gilad Ben-Yossef
2020-10-26 13:04   ` Gilad Ben-Yossef
2020-10-26 21:47   ` [dm-devel] " kernel test robot
2020-10-26 21:47     ` kernel test robot
2020-10-26 21:47     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201026175231.GG858@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=agk@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dm-devel@redhat.com \
    --cc=gilad@benyossef.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=ofir.drang@arm.com \
    --cc=snitzer@redhat.com \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.