* [PATCH 1/2] ti-rpmsg-char-examples: Fix cross compile @ 2020-10-25 6:59 Khem Raj 2020-10-25 6:59 ` [PATCH 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific Khem Raj 2020-10-26 21:20 ` [meta-ti] [PATCH 1/2] ti-rpmsg-char-examples: Fix cross compile Denys Dmytriyenko 0 siblings, 2 replies; 14+ messages in thread From: Khem Raj @ 2020-10-25 6:59 UTC (permalink / raw) To: meta-ti; +Cc: Khem Raj This fixes problems during cross compile where it starts to peek into build host's include and library paths and causes errors with clang and QA warnings with gcc Signed-off-by: Khem Raj <raj.khem@gmail.com> --- ...-Remove-use-of-includedir-and-libdir.patch | 37 +++++++++++++++++++ recipes-ti/ipc/ti-rpmsg-char-examples_git.bb | 2 + 2 files changed, 39 insertions(+) create mode 100644 recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch diff --git a/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch b/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file mode 100644 index 00000000..34807152 --- /dev/null +++ b/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch @@ -0,0 +1,37 @@ +From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 2001 +From: Khem Raj <raj.khem@gmail.com> +Date: Sat, 24 Oct 2020 23:46:39 -0700 +Subject: [PATCH] examples: Remove use of includedir and libdir + +These point to standard include and library paths which already are used +from sysroot relative paths secondly, they use absolute paths which +means we are asking to add -I/usr/include which might be ok in a native +build but not in cross build. This helps mitigate QA errors found with +OE build system since it finds it adding host include and library search +paths to linker/compiler commandline + +Signed-off-by: Khem Raj <raj.khem@gmail.com> +--- + examples/Makefile.am | 5 +---- + 1 file changed, 1 insertion(+), 4 deletions(-) + +diff --git a/examples/Makefile.am b/examples/Makefile.am +index 5a9bedb..d547e41 100644 +--- a/examples/Makefile.am ++++ b/examples/Makefile.am +@@ -1,6 +1,4 @@ +-INCLUDE = -I${includedir} +- +-AM_CFLAGS = -Wall -g -O2 $(INCLUDE) ++AM_CFLAGS = -Wall -g -O2 + + bin_PROGRAMS = rpmsg_char_simple + +@@ -8,4 +6,3 @@ bin_PROGRAMS = rpmsg_char_simple + rpmsg_char_simple_SOURCES = rpmsg_char_simple.c + rpmsg_char_simple_CPPFLAGS = $(AM_CFLAGS) + rpmsg_char_simple_LDADD = -lpthread -lti_rpmsg_char +-rpmsg_char_simple_LDFLAGS = -L${libdir} +-- +2.29.1 + diff --git a/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb b/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb index 142e5bf0..cbe4d7fd 100644 --- a/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb +++ b/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb @@ -2,6 +2,8 @@ SUMMARY = "TI RPMsg Char Sample Applications and Tests" require ti-rpmsg-char.inc +SRC_URI += "file://0001-examples-Remove-use-of-includedir-and-libdir.patch" + DEPENDS = "ti-rpmsg-char" inherit autotools pkgconfig -- 2.29.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific 2020-10-25 6:59 [PATCH 1/2] ti-rpmsg-char-examples: Fix cross compile Khem Raj @ 2020-10-25 6:59 ` Khem Raj 2020-10-27 2:19 ` [meta-ti] " Suman Anna 2020-10-26 21:20 ` [meta-ti] [PATCH 1/2] ti-rpmsg-char-examples: Fix cross compile Denys Dmytriyenko 1 sibling, 1 reply; 14+ messages in thread From: Khem Raj @ 2020-10-25 6:59 UTC (permalink / raw) To: meta-ti; +Cc: Khem Raj Signed-off-by: Khem Raj <raj.khem@gmail.com> --- recipes-ti/ipc/ti-rpmsg-char.inc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/recipes-ti/ipc/ti-rpmsg-char.inc b/recipes-ti/ipc/ti-rpmsg-char.inc index b41e68eb..d08031cb 100644 --- a/recipes-ti/ipc/ti-rpmsg-char.inc +++ b/recipes-ti/ipc/ti-rpmsg-char.inc @@ -13,3 +13,6 @@ SRCREV = "9be402c2bf4053900b6b9a8092fbb42e7e303108" PV = "0.1.0+git${SRCPV}" S = "${WORKDIR}/git" + +COMPATIBLE_HOST ?= "null" +COMPATIBLE_HOST_ti-soc = "(.*)" -- 2.29.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [meta-ti] [PATCH 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific 2020-10-25 6:59 ` [PATCH 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific Khem Raj @ 2020-10-27 2:19 ` Suman Anna 2020-10-27 2:30 ` Khem Raj 2020-10-27 2:41 ` Denys Dmytriyenko 0 siblings, 2 replies; 14+ messages in thread From: Suman Anna @ 2020-10-27 2:19 UTC (permalink / raw) To: Khem Raj, meta-ti Hi Raj, On 10/25/20 1:59 AM, Khem Raj wrote: > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > recipes-ti/ipc/ti-rpmsg-char.inc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/recipes-ti/ipc/ti-rpmsg-char.inc b/recipes-ti/ipc/ti-rpmsg-char.inc > index b41e68eb..d08031cb 100644 > --- a/recipes-ti/ipc/ti-rpmsg-char.inc > +++ b/recipes-ti/ipc/ti-rpmsg-char.inc > @@ -13,3 +13,6 @@ SRCREV = "9be402c2bf4053900b6b9a8092fbb42e7e303108" > PV = "0.1.0+git${SRCPV}" > > S = "${WORKDIR}/git" > + > +COMPATIBLE_HOST ?= "null" > +COMPATIBLE_HOST_ti-soc = "(.*)" > This looks ok, but I am trying to understand why this is needed in general (am still getting familiar with OE). Aren't the recipes processed only on packagegroups that include them? regards Suman > > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-ti] [PATCH 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific 2020-10-27 2:19 ` [meta-ti] " Suman Anna @ 2020-10-27 2:30 ` Khem Raj 2020-10-27 2:45 ` Suman Anna [not found] ` <1641B95DDCF93CD1.11545@lists.yoctoproject.org> 2020-10-27 2:41 ` Denys Dmytriyenko 1 sibling, 2 replies; 14+ messages in thread From: Khem Raj @ 2020-10-27 2:30 UTC (permalink / raw) To: Suman Anna; +Cc: meta-ti On Mon, Oct 26, 2020 at 7:19 PM Suman Anna <s-anna@ti.com> wrote: > > Hi Raj, > > On 10/25/20 1:59 AM, Khem Raj wrote: > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > --- > > recipes-ti/ipc/ti-rpmsg-char.inc | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/recipes-ti/ipc/ti-rpmsg-char.inc b/recipes-ti/ipc/ti-rpmsg-char.inc > > index b41e68eb..d08031cb 100644 > > --- a/recipes-ti/ipc/ti-rpmsg-char.inc > > +++ b/recipes-ti/ipc/ti-rpmsg-char.inc > > @@ -13,3 +13,6 @@ SRCREV = "9be402c2bf4053900b6b9a8092fbb42e7e303108" > > PV = "0.1.0+git${SRCPV}" > > > > S = "${WORKDIR}/git" > > + > > +COMPATIBLE_HOST ?= "null" > > +COMPATIBLE_HOST_ti-soc = "(.*)" > > > > This looks ok, but I am trying to understand why this is needed in general (am > still getting familiar with OE). Aren't the recipes processed only on > packagegroups that include them? on image builds yes. however in yoe distro CI builds we test multi-BSP setups and do world builds which catch such issues, where BSP layers are exposing general packages which are not compatible with other BSPs. > > regards > Suman > > > > > > > > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-ti] [PATCH 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific 2020-10-27 2:30 ` Khem Raj @ 2020-10-27 2:45 ` Suman Anna [not found] ` <1641B95DDCF93CD1.11545@lists.yoctoproject.org> 1 sibling, 0 replies; 14+ messages in thread From: Suman Anna @ 2020-10-27 2:45 UTC (permalink / raw) To: Khem Raj; +Cc: meta-ti On 10/26/20 9:30 PM, Khem Raj wrote: > On Mon, Oct 26, 2020 at 7:19 PM Suman Anna <s-anna@ti.com> wrote: >> >> Hi Raj, >> >> On 10/25/20 1:59 AM, Khem Raj wrote: >>> Signed-off-by: Khem Raj <raj.khem@gmail.com> >>> --- >>> recipes-ti/ipc/ti-rpmsg-char.inc | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/recipes-ti/ipc/ti-rpmsg-char.inc b/recipes-ti/ipc/ti-rpmsg-char.inc >>> index b41e68eb..d08031cb 100644 >>> --- a/recipes-ti/ipc/ti-rpmsg-char.inc >>> +++ b/recipes-ti/ipc/ti-rpmsg-char.inc >>> @@ -13,3 +13,6 @@ SRCREV = "9be402c2bf4053900b6b9a8092fbb42e7e303108" >>> PV = "0.1.0+git${SRCPV}" >>> >>> S = "${WORKDIR}/git" >>> + >>> +COMPATIBLE_HOST ?= "null" >>> +COMPATIBLE_HOST_ti-soc = "(.*)" >>> >> >> This looks ok, but I am trying to understand why this is needed in general (am >> still getting familiar with OE). Aren't the recipes processed only on >> packagegroups that include them? > > on image builds yes. however in yoe distro CI builds we test multi-BSP > setups and do world builds which catch > such issues, where BSP layers are exposing general packages which are > not compatible with other BSPs. Thanks for the clarification! regards Suman > >> >> regards >> Suman >> >>> >>> >>> >>> >> ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <1641B95DDCF93CD1.11545@lists.yoctoproject.org>]
* Re: [meta-ti] [PATCH 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific [not found] ` <1641B95DDCF93CD1.11545@lists.yoctoproject.org> @ 2020-10-29 21:53 ` Suman Anna 0 siblings, 0 replies; 14+ messages in thread From: Suman Anna @ 2020-10-29 21:53 UTC (permalink / raw) To: Khem Raj; +Cc: meta-ti On 10/26/20 9:45 PM, Suman Anna via lists.yoctoproject.org wrote: > On 10/26/20 9:30 PM, Khem Raj wrote: >> On Mon, Oct 26, 2020 at 7:19 PM Suman Anna <s-anna@ti.com> wrote: >>> >>> Hi Raj, >>> >>> On 10/25/20 1:59 AM, Khem Raj wrote: >>>> Signed-off-by: Khem Raj <raj.khem@gmail.com> >>>> --- >>>> recipes-ti/ipc/ti-rpmsg-char.inc | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git a/recipes-ti/ipc/ti-rpmsg-char.inc b/recipes-ti/ipc/ti-rpmsg-char.inc >>>> index b41e68eb..d08031cb 100644 >>>> --- a/recipes-ti/ipc/ti-rpmsg-char.inc >>>> +++ b/recipes-ti/ipc/ti-rpmsg-char.inc >>>> @@ -13,3 +13,6 @@ SRCREV = "9be402c2bf4053900b6b9a8092fbb42e7e303108" >>>> PV = "0.1.0+git${SRCPV}" >>>> >>>> S = "${WORKDIR}/git" >>>> + >>>> +COMPATIBLE_HOST ?= "null" >>>> +COMPATIBLE_HOST_ti-soc = "(.*)" >>>> >>> >>> This looks ok, but I am trying to understand why this is needed in general (am >>> still getting familiar with OE). Aren't the recipes processed only on >>> packagegroups that include them? >> >> on image builds yes. however in yoe distro CI builds we test multi-BSP >> setups and do world builds which catch >> such issues, where BSP layers are exposing general packages which are >> not compatible with other BSPs. > > Thanks for the clarification! Reviewed-by: Suman Anna <s-anna@ti.com> regards Suman ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-ti] [PATCH 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific 2020-10-27 2:19 ` [meta-ti] " Suman Anna 2020-10-27 2:30 ` Khem Raj @ 2020-10-27 2:41 ` Denys Dmytriyenko 1 sibling, 0 replies; 14+ messages in thread From: Denys Dmytriyenko @ 2020-10-27 2:41 UTC (permalink / raw) To: s-anna; +Cc: Khem Raj, meta-ti On Mon, Oct 26, 2020 at 09:19:29PM -0500, Suman Anna via lists.yoctoproject.org wrote: > Hi Raj, > > On 10/25/20 1:59 AM, Khem Raj wrote: > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > --- > > recipes-ti/ipc/ti-rpmsg-char.inc | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/recipes-ti/ipc/ti-rpmsg-char.inc b/recipes-ti/ipc/ti-rpmsg-char.inc > > index b41e68eb..d08031cb 100644 > > --- a/recipes-ti/ipc/ti-rpmsg-char.inc > > +++ b/recipes-ti/ipc/ti-rpmsg-char.inc > > @@ -13,3 +13,6 @@ SRCREV = "9be402c2bf4053900b6b9a8092fbb42e7e303108" > > PV = "0.1.0+git${SRCPV}" > > > > S = "${WORKDIR}/git" > > + > > +COMPATIBLE_HOST ?= "null" > > +COMPATIBLE_HOST_ti-soc = "(.*)" > > > > This looks ok, but I am trying to understand why this is needed in general (am > still getting familiar with OE). Aren't the recipes processed only on > packagegroups that include them? Suman, Some people like Khem do world builds - kind of like building kernel with "allyesconfig" to see any conflicts or incompatibilities... -- Denys ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-ti] [PATCH 1/2] ti-rpmsg-char-examples: Fix cross compile 2020-10-25 6:59 [PATCH 1/2] ti-rpmsg-char-examples: Fix cross compile Khem Raj 2020-10-25 6:59 ` [PATCH 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific Khem Raj @ 2020-10-26 21:20 ` Denys Dmytriyenko 2020-10-26 23:24 ` Khem Raj 1 sibling, 1 reply; 14+ messages in thread From: Denys Dmytriyenko @ 2020-10-26 21:20 UTC (permalink / raw) To: Khem Raj; +Cc: meta-ti On Sat, Oct 24, 2020 at 11:59:33PM -0700, Khem Raj wrote: > This fixes problems during cross compile where it starts to peek into > build host's include and library paths and causes errors with clang and > QA warnings with gcc > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > ...-Remove-use-of-includedir-and-libdir.patch | 37 +++++++++++++++++++ > recipes-ti/ipc/ti-rpmsg-char-examples_git.bb | 2 + > 2 files changed, 39 insertions(+) > create mode 100644 recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch > > diff --git a/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch b/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch > new file mode 100644 > index 00000000..34807152 > --- /dev/null > +++ b/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch > @@ -0,0 +1,37 @@ > +From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 2001 > +From: Khem Raj <raj.khem@gmail.com> > +Date: Sat, 24 Oct 2020 23:46:39 -0700 > +Subject: [PATCH] examples: Remove use of includedir and libdir > + > +These point to standard include and library paths which already are used > +from sysroot relative paths secondly, they use absolute paths which > +means we are asking to add -I/usr/include which might be ok in a native > +build but not in cross build. This helps mitigate QA errors found with > +OE build system since it finds it adding host include and library search > +paths to linker/compiler commandline What's the Upstream-Status on this? Should it be "Inappropriate [OE-specific]"? > +Signed-off-by: Khem Raj <raj.khem@gmail.com> > +--- > + examples/Makefile.am | 5 +---- > + 1 file changed, 1 insertion(+), 4 deletions(-) > + > +diff --git a/examples/Makefile.am b/examples/Makefile.am > +index 5a9bedb..d547e41 100644 > +--- a/examples/Makefile.am > ++++ b/examples/Makefile.am > +@@ -1,6 +1,4 @@ > +-INCLUDE = -I${includedir} > +- > +-AM_CFLAGS = -Wall -g -O2 $(INCLUDE) > ++AM_CFLAGS = -Wall -g -O2 > + > + bin_PROGRAMS = rpmsg_char_simple > + > +@@ -8,4 +6,3 @@ bin_PROGRAMS = rpmsg_char_simple > + rpmsg_char_simple_SOURCES = rpmsg_char_simple.c > + rpmsg_char_simple_CPPFLAGS = $(AM_CFLAGS) > + rpmsg_char_simple_LDADD = -lpthread -lti_rpmsg_char > +-rpmsg_char_simple_LDFLAGS = -L${libdir} > +-- > +2.29.1 > + > diff --git a/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb b/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb > index 142e5bf0..cbe4d7fd 100644 > --- a/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb > +++ b/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb > @@ -2,6 +2,8 @@ SUMMARY = "TI RPMsg Char Sample Applications and Tests" > > require ti-rpmsg-char.inc > > +SRC_URI += "file://0001-examples-Remove-use-of-includedir-and-libdir.patch" > + > DEPENDS = "ti-rpmsg-char" > > inherit autotools pkgconfig > -- > 2.29.1 > > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-ti] [PATCH 1/2] ti-rpmsg-char-examples: Fix cross compile 2020-10-26 21:20 ` [meta-ti] [PATCH 1/2] ti-rpmsg-char-examples: Fix cross compile Denys Dmytriyenko @ 2020-10-26 23:24 ` Khem Raj 2020-10-27 2:43 ` Denys Dmytriyenko [not found] ` <1641B93D38E82508.16876@lists.yoctoproject.org> 0 siblings, 2 replies; 14+ messages in thread From: Khem Raj @ 2020-10-26 23:24 UTC (permalink / raw) To: Denys Dmytriyenko; +Cc: meta-ti I think it should be applied but then I don't know how else this component is used. maybe there are some toolchains which don't have sysrooots used to compile this On Mon, Oct 26, 2020 at 2:20 PM Denys Dmytriyenko <denys@ti.com> wrote: > > On Sat, Oct 24, 2020 at 11:59:33PM -0700, Khem Raj wrote: > > This fixes problems during cross compile where it starts to peek into > > build host's include and library paths and causes errors with clang and > > QA warnings with gcc > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > --- > > ...-Remove-use-of-includedir-and-libdir.patch | 37 +++++++++++++++++++ > > recipes-ti/ipc/ti-rpmsg-char-examples_git.bb | 2 + > > 2 files changed, 39 insertions(+) > > create mode 100644 recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch > > > > diff --git a/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch b/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch > > new file mode 100644 > > index 00000000..34807152 > > --- /dev/null > > +++ b/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch > > @@ -0,0 +1,37 @@ > > +From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 2001 > > +From: Khem Raj <raj.khem@gmail.com> > > +Date: Sat, 24 Oct 2020 23:46:39 -0700 > > +Subject: [PATCH] examples: Remove use of includedir and libdir > > + > > +These point to standard include and library paths which already are used > > +from sysroot relative paths secondly, they use absolute paths which > > +means we are asking to add -I/usr/include which might be ok in a native > > +build but not in cross build. This helps mitigate QA errors found with > > +OE build system since it finds it adding host include and library search > > +paths to linker/compiler commandline > > What's the Upstream-Status on this? Should it be "Inappropriate [OE-specific]"? > > > > +Signed-off-by: Khem Raj <raj.khem@gmail.com> > > +--- > > + examples/Makefile.am | 5 +---- > > + 1 file changed, 1 insertion(+), 4 deletions(-) > > + > > +diff --git a/examples/Makefile.am b/examples/Makefile.am > > +index 5a9bedb..d547e41 100644 > > +--- a/examples/Makefile.am > > ++++ b/examples/Makefile.am > > +@@ -1,6 +1,4 @@ > > +-INCLUDE = -I${includedir} > > +- > > +-AM_CFLAGS = -Wall -g -O2 $(INCLUDE) > > ++AM_CFLAGS = -Wall -g -O2 > > + > > + bin_PROGRAMS = rpmsg_char_simple > > + > > +@@ -8,4 +6,3 @@ bin_PROGRAMS = rpmsg_char_simple > > + rpmsg_char_simple_SOURCES = rpmsg_char_simple.c > > + rpmsg_char_simple_CPPFLAGS = $(AM_CFLAGS) > > + rpmsg_char_simple_LDADD = -lpthread -lti_rpmsg_char > > +-rpmsg_char_simple_LDFLAGS = -L${libdir} > > +-- > > +2.29.1 > > + > > diff --git a/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb b/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb > > index 142e5bf0..cbe4d7fd 100644 > > --- a/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb > > +++ b/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb > > @@ -2,6 +2,8 @@ SUMMARY = "TI RPMsg Char Sample Applications and Tests" > > > > require ti-rpmsg-char.inc > > > > +SRC_URI += "file://0001-examples-Remove-use-of-includedir-and-libdir.patch" > > + > > DEPENDS = "ti-rpmsg-char" > > > > inherit autotools pkgconfig > > -- > > 2.29.1 > > > > > > > > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-ti] [PATCH 1/2] ti-rpmsg-char-examples: Fix cross compile 2020-10-26 23:24 ` Khem Raj @ 2020-10-27 2:43 ` Denys Dmytriyenko [not found] ` <1641B93D38E82508.16876@lists.yoctoproject.org> 1 sibling, 0 replies; 14+ messages in thread From: Denys Dmytriyenko @ 2020-10-27 2:43 UTC (permalink / raw) To: Khem Raj; +Cc: meta-ti On Mon, Oct 26, 2020 at 04:24:11PM -0700, Khem Raj wrote: > I think it should be applied but then I don't know how else this > component is used. maybe there are some toolchains which don't have > sysrooots used to compile this This is meant to be cross-compiled for the target, in which case accessing host headers or libraries is a bad idea regardless of the toolchain... > On Mon, Oct 26, 2020 at 2:20 PM Denys Dmytriyenko <denys@ti.com> wrote: > > > > On Sat, Oct 24, 2020 at 11:59:33PM -0700, Khem Raj wrote: > > > This fixes problems during cross compile where it starts to peek into > > > build host's include and library paths and causes errors with clang and > > > QA warnings with gcc > > > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > > --- > > > ...-Remove-use-of-includedir-and-libdir.patch | 37 +++++++++++++++++++ > > > recipes-ti/ipc/ti-rpmsg-char-examples_git.bb | 2 + > > > 2 files changed, 39 insertions(+) > > > create mode 100644 recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch > > > > > > diff --git a/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch b/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch > > > new file mode 100644 > > > index 00000000..34807152 > > > --- /dev/null > > > +++ b/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch > > > @@ -0,0 +1,37 @@ > > > +From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 2001 > > > +From: Khem Raj <raj.khem@gmail.com> > > > +Date: Sat, 24 Oct 2020 23:46:39 -0700 > > > +Subject: [PATCH] examples: Remove use of includedir and libdir > > > + > > > +These point to standard include and library paths which already are used > > > +from sysroot relative paths secondly, they use absolute paths which > > > +means we are asking to add -I/usr/include which might be ok in a native > > > +build but not in cross build. This helps mitigate QA errors found with > > > +OE build system since it finds it adding host include and library search > > > +paths to linker/compiler commandline > > > > What's the Upstream-Status on this? Should it be "Inappropriate [OE-specific]"? > > > > > > > +Signed-off-by: Khem Raj <raj.khem@gmail.com> > > > +--- > > > + examples/Makefile.am | 5 +---- > > > + 1 file changed, 1 insertion(+), 4 deletions(-) > > > + > > > +diff --git a/examples/Makefile.am b/examples/Makefile.am > > > +index 5a9bedb..d547e41 100644 > > > +--- a/examples/Makefile.am > > > ++++ b/examples/Makefile.am > > > +@@ -1,6 +1,4 @@ > > > +-INCLUDE = -I${includedir} > > > +- > > > +-AM_CFLAGS = -Wall -g -O2 $(INCLUDE) > > > ++AM_CFLAGS = -Wall -g -O2 > > > + > > > + bin_PROGRAMS = rpmsg_char_simple > > > + > > > +@@ -8,4 +6,3 @@ bin_PROGRAMS = rpmsg_char_simple > > > + rpmsg_char_simple_SOURCES = rpmsg_char_simple.c > > > + rpmsg_char_simple_CPPFLAGS = $(AM_CFLAGS) > > > + rpmsg_char_simple_LDADD = -lpthread -lti_rpmsg_char > > > +-rpmsg_char_simple_LDFLAGS = -L${libdir} > > > +-- > > > +2.29.1 > > > + > > > diff --git a/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb b/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb > > > index 142e5bf0..cbe4d7fd 100644 > > > --- a/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb > > > +++ b/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb > > > @@ -2,6 +2,8 @@ SUMMARY = "TI RPMsg Char Sample Applications and Tests" > > > > > > require ti-rpmsg-char.inc > > > > > > +SRC_URI += "file://0001-examples-Remove-use-of-includedir-and-libdir.patch" > > > + > > > DEPENDS = "ti-rpmsg-char" > > > > > > inherit autotools pkgconfig > > > -- > > > 2.29.1 > > > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <1641B93D38E82508.16876@lists.yoctoproject.org>]
* Re: [meta-ti] [PATCH 1/2] ti-rpmsg-char-examples: Fix cross compile [not found] ` <1641B93D38E82508.16876@lists.yoctoproject.org> @ 2020-10-29 18:09 ` Denys Dmytriyenko 2020-10-29 20:09 ` Khem Raj 0 siblings, 1 reply; 14+ messages in thread From: Denys Dmytriyenko @ 2020-10-29 18:09 UTC (permalink / raw) To: Khem Raj, meta-ti On Mon, Oct 26, 2020 at 10:43:32PM -0400, Denys Dmytriyenko via lists.yoctoproject.org wrote: > On Mon, Oct 26, 2020 at 04:24:11PM -0700, Khem Raj wrote: > > I think it should be applied but then I don't know how else this > > component is used. maybe there are some toolchains which don't have > > sysrooots used to compile this > > This is meant to be cross-compiled for the target, in which case accessing > host headers or libraries is a bad idea regardless of the toolchain... Khem, Suman, Any conclusion here? Should this change be taken upstream by Suman? Or should this reside here as a patch with "Upstream-Status: Inappropriate [OE-specific]"? Denys > > On Mon, Oct 26, 2020 at 2:20 PM Denys Dmytriyenko <denys@ti.com> wrote: > > > > > > On Sat, Oct 24, 2020 at 11:59:33PM -0700, Khem Raj wrote: > > > > This fixes problems during cross compile where it starts to peek into > > > > build host's include and library paths and causes errors with clang and > > > > QA warnings with gcc > > > > > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > > > --- > > > > ...-Remove-use-of-includedir-and-libdir.patch | 37 +++++++++++++++++++ > > > > recipes-ti/ipc/ti-rpmsg-char-examples_git.bb | 2 + > > > > 2 files changed, 39 insertions(+) > > > > create mode 100644 recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch > > > > > > > > diff --git a/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch b/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch > > > > new file mode 100644 > > > > index 00000000..34807152 > > > > --- /dev/null > > > > +++ b/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch > > > > @@ -0,0 +1,37 @@ > > > > +From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 2001 > > > > +From: Khem Raj <raj.khem@gmail.com> > > > > +Date: Sat, 24 Oct 2020 23:46:39 -0700 > > > > +Subject: [PATCH] examples: Remove use of includedir and libdir > > > > + > > > > +These point to standard include and library paths which already are used > > > > +from sysroot relative paths secondly, they use absolute paths which > > > > +means we are asking to add -I/usr/include which might be ok in a native > > > > +build but not in cross build. This helps mitigate QA errors found with > > > > +OE build system since it finds it adding host include and library search > > > > +paths to linker/compiler commandline > > > > > > What's the Upstream-Status on this? Should it be "Inappropriate [OE-specific]"? > > > > > > > > > > +Signed-off-by: Khem Raj <raj.khem@gmail.com> > > > > +--- > > > > + examples/Makefile.am | 5 +---- > > > > + 1 file changed, 1 insertion(+), 4 deletions(-) > > > > + > > > > +diff --git a/examples/Makefile.am b/examples/Makefile.am > > > > +index 5a9bedb..d547e41 100644 > > > > +--- a/examples/Makefile.am > > > > ++++ b/examples/Makefile.am > > > > +@@ -1,6 +1,4 @@ > > > > +-INCLUDE = -I${includedir} > > > > +- > > > > +-AM_CFLAGS = -Wall -g -O2 $(INCLUDE) > > > > ++AM_CFLAGS = -Wall -g -O2 > > > > + > > > > + bin_PROGRAMS = rpmsg_char_simple > > > > + > > > > +@@ -8,4 +6,3 @@ bin_PROGRAMS = rpmsg_char_simple > > > > + rpmsg_char_simple_SOURCES = rpmsg_char_simple.c > > > > + rpmsg_char_simple_CPPFLAGS = $(AM_CFLAGS) > > > > + rpmsg_char_simple_LDADD = -lpthread -lti_rpmsg_char > > > > +-rpmsg_char_simple_LDFLAGS = -L${libdir} > > > > +-- > > > > +2.29.1 > > > > + > > > > diff --git a/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb b/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb > > > > index 142e5bf0..cbe4d7fd 100644 > > > > --- a/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb > > > > +++ b/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb > > > > @@ -2,6 +2,8 @@ SUMMARY = "TI RPMsg Char Sample Applications and Tests" > > > > > > > > require ti-rpmsg-char.inc > > > > > > > > +SRC_URI += "file://0001-examples-Remove-use-of-includedir-and-libdir.patch" > > > > + > > > > DEPENDS = "ti-rpmsg-char" > > > > > > > > inherit autotools pkgconfig > > > > -- > > > > 2.29.1 > > > > > > > > > > > > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-ti] [PATCH 1/2] ti-rpmsg-char-examples: Fix cross compile 2020-10-29 18:09 ` Denys Dmytriyenko @ 2020-10-29 20:09 ` Khem Raj 2020-10-29 21:50 ` Suman Anna 0 siblings, 1 reply; 14+ messages in thread From: Khem Raj @ 2020-10-29 20:09 UTC (permalink / raw) To: Denys Dmytriyenko; +Cc: meta-ti On Thu, Oct 29, 2020 at 11:09 AM Denys Dmytriyenko <denys@ti.com> wrote: > > On Mon, Oct 26, 2020 at 10:43:32PM -0400, Denys Dmytriyenko via lists.yoctoproject.org wrote: > > On Mon, Oct 26, 2020 at 04:24:11PM -0700, Khem Raj wrote: > > > I think it should be applied but then I don't know how else this > > > component is used. maybe there are some toolchains which don't have > > > sysrooots used to compile this > > > > This is meant to be cross-compiled for the target, in which case accessing > > host headers or libraries is a bad idea regardless of the toolchain... > > Khem, Suman, > > Any conclusion here? Should this change be taken upstream by Suman? Or should > this reside here as a patch with "Upstream-Status: Inappropriate [OE-specific]"? > its needed in OE for sure. Other places I don't know so literally your call. > Denys > > > > > On Mon, Oct 26, 2020 at 2:20 PM Denys Dmytriyenko <denys@ti.com> wrote: > > > > > > > > On Sat, Oct 24, 2020 at 11:59:33PM -0700, Khem Raj wrote: > > > > > This fixes problems during cross compile where it starts to peek into > > > > > build host's include and library paths and causes errors with clang and > > > > > QA warnings with gcc > > > > > > > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > > > > --- > > > > > ...-Remove-use-of-includedir-and-libdir.patch | 37 +++++++++++++++++++ > > > > > recipes-ti/ipc/ti-rpmsg-char-examples_git.bb | 2 + > > > > > 2 files changed, 39 insertions(+) > > > > > create mode 100644 recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch > > > > > > > > > > diff --git a/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch b/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch > > > > > new file mode 100644 > > > > > index 00000000..34807152 > > > > > --- /dev/null > > > > > +++ b/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch > > > > > @@ -0,0 +1,37 @@ > > > > > +From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 2001 > > > > > +From: Khem Raj <raj.khem@gmail.com> > > > > > +Date: Sat, 24 Oct 2020 23:46:39 -0700 > > > > > +Subject: [PATCH] examples: Remove use of includedir and libdir > > > > > + > > > > > +These point to standard include and library paths which already are used > > > > > +from sysroot relative paths secondly, they use absolute paths which > > > > > +means we are asking to add -I/usr/include which might be ok in a native > > > > > +build but not in cross build. This helps mitigate QA errors found with > > > > > +OE build system since it finds it adding host include and library search > > > > > +paths to linker/compiler commandline > > > > > > > > What's the Upstream-Status on this? Should it be "Inappropriate [OE-specific]"? > > > > > > > > > > > > > +Signed-off-by: Khem Raj <raj.khem@gmail.com> > > > > > +--- > > > > > + examples/Makefile.am | 5 +---- > > > > > + 1 file changed, 1 insertion(+), 4 deletions(-) > > > > > + > > > > > +diff --git a/examples/Makefile.am b/examples/Makefile.am > > > > > +index 5a9bedb..d547e41 100644 > > > > > +--- a/examples/Makefile.am > > > > > ++++ b/examples/Makefile.am > > > > > +@@ -1,6 +1,4 @@ > > > > > +-INCLUDE = -I${includedir} > > > > > +- > > > > > +-AM_CFLAGS = -Wall -g -O2 $(INCLUDE) > > > > > ++AM_CFLAGS = -Wall -g -O2 > > > > > + > > > > > + bin_PROGRAMS = rpmsg_char_simple > > > > > + > > > > > +@@ -8,4 +6,3 @@ bin_PROGRAMS = rpmsg_char_simple > > > > > + rpmsg_char_simple_SOURCES = rpmsg_char_simple.c > > > > > + rpmsg_char_simple_CPPFLAGS = $(AM_CFLAGS) > > > > > + rpmsg_char_simple_LDADD = -lpthread -lti_rpmsg_char > > > > > +-rpmsg_char_simple_LDFLAGS = -L${libdir} > > > > > +-- > > > > > +2.29.1 > > > > > + > > > > > diff --git a/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb b/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb > > > > > index 142e5bf0..cbe4d7fd 100644 > > > > > --- a/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb > > > > > +++ b/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb > > > > > @@ -2,6 +2,8 @@ SUMMARY = "TI RPMsg Char Sample Applications and Tests" > > > > > > > > > > require ti-rpmsg-char.inc > > > > > > > > > > +SRC_URI += "file://0001-examples-Remove-use-of-includedir-and-libdir.patch" > > > > > + > > > > > DEPENDS = "ti-rpmsg-char" > > > > > > > > > > inherit autotools pkgconfig > > > > > -- > > > > > 2.29.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-ti] [PATCH 1/2] ti-rpmsg-char-examples: Fix cross compile 2020-10-29 20:09 ` Khem Raj @ 2020-10-29 21:50 ` Suman Anna 2020-10-29 21:56 ` Denys Dmytriyenko 0 siblings, 1 reply; 14+ messages in thread From: Suman Anna @ 2020-10-29 21:50 UTC (permalink / raw) To: Khem Raj, Denys Dmytriyenko; +Cc: meta-ti Hi Denys, On 10/29/20 3:09 PM, Khem Raj wrote: > On Thu, Oct 29, 2020 at 11:09 AM Denys Dmytriyenko <denys@ti.com> wrote: >> >> On Mon, Oct 26, 2020 at 10:43:32PM -0400, Denys Dmytriyenko via lists.yoctoproject.org wrote: >>> On Mon, Oct 26, 2020 at 04:24:11PM -0700, Khem Raj wrote: >>>> I think it should be applied but then I don't know how else this >>>> component is used. maybe there are some toolchains which don't have >>>> sysrooots used to compile this >>> >>> This is meant to be cross-compiled for the target, in which case accessing >>> host headers or libraries is a bad idea regardless of the toolchain... >> >> Khem, Suman, >> >> Any conclusion here? Should this change be taken upstream by Suman? Or should >> this reside here as a patch with "Upstream-Status: Inappropriate [OE-specific]"? >> > > its needed in OE for sure. Other places I don't know so literally your call. If it is needed by OE, I am ok with this going in for now. I will leave it to your expertise for the ack for this patch. I need to look into this a bit more to see if I need to revise the build stuff in the actual source repo, or I need to tweak the OE recipe to keep both happy. I also cross-compile on my host machine when directly using automake, and as such I don't use --prefix as /usr. I need to have a successful OE environment for me to evaluate a proper fix, but I am currently running into various issues when building tisdk-default-image (tisdk-tiny-image and tisdk-base-image were ok). regards Suman > >> Denys >> >> >>>> On Mon, Oct 26, 2020 at 2:20 PM Denys Dmytriyenko <denys@ti.com> wrote: >>>>> >>>>> On Sat, Oct 24, 2020 at 11:59:33PM -0700, Khem Raj wrote: >>>>>> This fixes problems during cross compile where it starts to peek into >>>>>> build host's include and library paths and causes errors with clang and >>>>>> QA warnings with gcc >>>>>> >>>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com> >>>>>> --- >>>>>> ...-Remove-use-of-includedir-and-libdir.patch | 37 +++++++++++++++++++ >>>>>> recipes-ti/ipc/ti-rpmsg-char-examples_git.bb | 2 + >>>>>> 2 files changed, 39 insertions(+) >>>>>> create mode 100644 recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch >>>>>> >>>>>> diff --git a/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch b/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch >>>>>> new file mode 100644 >>>>>> index 00000000..34807152 >>>>>> --- /dev/null >>>>>> +++ b/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch >>>>>> @@ -0,0 +1,37 @@ >>>>>> +From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 2001 >>>>>> +From: Khem Raj <raj.khem@gmail.com> >>>>>> +Date: Sat, 24 Oct 2020 23:46:39 -0700 >>>>>> +Subject: [PATCH] examples: Remove use of includedir and libdir >>>>>> + >>>>>> +These point to standard include and library paths which already are used >>>>>> +from sysroot relative paths secondly, they use absolute paths which >>>>>> +means we are asking to add -I/usr/include which might be ok in a native >>>>>> +build but not in cross build. This helps mitigate QA errors found with >>>>>> +OE build system since it finds it adding host include and library search >>>>>> +paths to linker/compiler commandline >>>>> >>>>> What's the Upstream-Status on this? Should it be "Inappropriate [OE-specific]"? >>>>> >>>>> >>>>>> +Signed-off-by: Khem Raj <raj.khem@gmail.com> >>>>>> +--- >>>>>> + examples/Makefile.am | 5 +---- >>>>>> + 1 file changed, 1 insertion(+), 4 deletions(-) >>>>>> + >>>>>> +diff --git a/examples/Makefile.am b/examples/Makefile.am >>>>>> +index 5a9bedb..d547e41 100644 >>>>>> +--- a/examples/Makefile.am >>>>>> ++++ b/examples/Makefile.am >>>>>> +@@ -1,6 +1,4 @@ >>>>>> +-INCLUDE = -I${includedir} >>>>>> +- >>>>>> +-AM_CFLAGS = -Wall -g -O2 $(INCLUDE) >>>>>> ++AM_CFLAGS = -Wall -g -O2 >>>>>> + >>>>>> + bin_PROGRAMS = rpmsg_char_simple >>>>>> + >>>>>> +@@ -8,4 +6,3 @@ bin_PROGRAMS = rpmsg_char_simple >>>>>> + rpmsg_char_simple_SOURCES = rpmsg_char_simple.c >>>>>> + rpmsg_char_simple_CPPFLAGS = $(AM_CFLAGS) >>>>>> + rpmsg_char_simple_LDADD = -lpthread -lti_rpmsg_char >>>>>> +-rpmsg_char_simple_LDFLAGS = -L${libdir} >>>>>> +-- >>>>>> +2.29.1 >>>>>> + >>>>>> diff --git a/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb b/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb >>>>>> index 142e5bf0..cbe4d7fd 100644 >>>>>> --- a/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb >>>>>> +++ b/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb >>>>>> @@ -2,6 +2,8 @@ SUMMARY = "TI RPMsg Char Sample Applications and Tests" >>>>>> >>>>>> require ti-rpmsg-char.inc >>>>>> >>>>>> +SRC_URI += "file://0001-examples-Remove-use-of-includedir-and-libdir.patch" >>>>>> + >>>>>> DEPENDS = "ti-rpmsg-char" >>>>>> >>>>>> inherit autotools pkgconfig >>>>>> -- >>>>>> 2.29.1 >>>>>> >>>>> >>>>>> >>>>>> >>>>>> >>>>> >> >>> >>> >>> >> >> >> >> >> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-ti] [PATCH 1/2] ti-rpmsg-char-examples: Fix cross compile 2020-10-29 21:50 ` Suman Anna @ 2020-10-29 21:56 ` Denys Dmytriyenko 0 siblings, 0 replies; 14+ messages in thread From: Denys Dmytriyenko @ 2020-10-29 21:56 UTC (permalink / raw) To: Suman Anna; +Cc: Khem Raj, meta-ti On Thu, Oct 29, 2020 at 04:50:24PM -0500, Suman Anna wrote: > Hi Denys, > > On 10/29/20 3:09 PM, Khem Raj wrote: > > On Thu, Oct 29, 2020 at 11:09 AM Denys Dmytriyenko <denys@ti.com> wrote: > >> > >> On Mon, Oct 26, 2020 at 10:43:32PM -0400, Denys Dmytriyenko via lists.yoctoproject.org wrote: > >>> On Mon, Oct 26, 2020 at 04:24:11PM -0700, Khem Raj wrote: > >>>> I think it should be applied but then I don't know how else this > >>>> component is used. maybe there are some toolchains which don't have > >>>> sysrooots used to compile this > >>> > >>> This is meant to be cross-compiled for the target, in which case accessing > >>> host headers or libraries is a bad idea regardless of the toolchain... > >> > >> Khem, Suman, > >> > >> Any conclusion here? Should this change be taken upstream by Suman? Or should > >> this reside here as a patch with "Upstream-Status: Inappropriate [OE-specific]"? > >> > > > > its needed in OE for sure. Other places I don't know so literally your call. > > If it is needed by OE, I am ok with this going in for now. I will leave it to > your expertise for the ack for this patch. > > I need to look into this a bit more to see if I need to revise the build stuff > in the actual source repo, or I need to tweak the OE recipe to keep both happy. > I also cross-compile on my host machine when directly using automake, and as > such I don't use --prefix as /usr. > > I need to have a successful OE environment for me to evaluate a proper fix, but > I am currently running into various issues when building tisdk-default-image > (tisdk-tiny-image and tisdk-base-image were ok). Thanks, Suman. So I guess we can carry this patch in meta-ti for now, until you get a chance to look into it a bit closer. Khem, Do you want to send v2 with Upstream-Statu: either Pending or Inappropriate? Denys > regards > Suman > > > > >> Denys > >> > >> > >>>> On Mon, Oct 26, 2020 at 2:20 PM Denys Dmytriyenko <denys@ti.com> wrote: > >>>>> > >>>>> On Sat, Oct 24, 2020 at 11:59:33PM -0700, Khem Raj wrote: > >>>>>> This fixes problems during cross compile where it starts to peek into > >>>>>> build host's include and library paths and causes errors with clang and > >>>>>> QA warnings with gcc > >>>>>> > >>>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com> > >>>>>> --- > >>>>>> ...-Remove-use-of-includedir-and-libdir.patch | 37 +++++++++++++++++++ > >>>>>> recipes-ti/ipc/ti-rpmsg-char-examples_git.bb | 2 + > >>>>>> 2 files changed, 39 insertions(+) > >>>>>> create mode 100644 recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch > >>>>>> > >>>>>> diff --git a/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch b/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch > >>>>>> new file mode 100644 > >>>>>> index 00000000..34807152 > >>>>>> --- /dev/null > >>>>>> +++ b/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch > >>>>>> @@ -0,0 +1,37 @@ > >>>>>> +From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 2001 > >>>>>> +From: Khem Raj <raj.khem@gmail.com> > >>>>>> +Date: Sat, 24 Oct 2020 23:46:39 -0700 > >>>>>> +Subject: [PATCH] examples: Remove use of includedir and libdir > >>>>>> + > >>>>>> +These point to standard include and library paths which already are used > >>>>>> +from sysroot relative paths secondly, they use absolute paths which > >>>>>> +means we are asking to add -I/usr/include which might be ok in a native > >>>>>> +build but not in cross build. This helps mitigate QA errors found with > >>>>>> +OE build system since it finds it adding host include and library search > >>>>>> +paths to linker/compiler commandline > >>>>> > >>>>> What's the Upstream-Status on this? Should it be "Inappropriate [OE-specific]"? > >>>>> > >>>>> > >>>>>> +Signed-off-by: Khem Raj <raj.khem@gmail.com> > >>>>>> +--- > >>>>>> + examples/Makefile.am | 5 +---- > >>>>>> + 1 file changed, 1 insertion(+), 4 deletions(-) > >>>>>> + > >>>>>> +diff --git a/examples/Makefile.am b/examples/Makefile.am > >>>>>> +index 5a9bedb..d547e41 100644 > >>>>>> +--- a/examples/Makefile.am > >>>>>> ++++ b/examples/Makefile.am > >>>>>> +@@ -1,6 +1,4 @@ > >>>>>> +-INCLUDE = -I${includedir} > >>>>>> +- > >>>>>> +-AM_CFLAGS = -Wall -g -O2 $(INCLUDE) > >>>>>> ++AM_CFLAGS = -Wall -g -O2 > >>>>>> + > >>>>>> + bin_PROGRAMS = rpmsg_char_simple > >>>>>> + > >>>>>> +@@ -8,4 +6,3 @@ bin_PROGRAMS = rpmsg_char_simple > >>>>>> + rpmsg_char_simple_SOURCES = rpmsg_char_simple.c > >>>>>> + rpmsg_char_simple_CPPFLAGS = $(AM_CFLAGS) > >>>>>> + rpmsg_char_simple_LDADD = -lpthread -lti_rpmsg_char > >>>>>> +-rpmsg_char_simple_LDFLAGS = -L${libdir} > >>>>>> +-- > >>>>>> +2.29.1 > >>>>>> + > >>>>>> diff --git a/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb b/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb > >>>>>> index 142e5bf0..cbe4d7fd 100644 > >>>>>> --- a/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb > >>>>>> +++ b/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb > >>>>>> @@ -2,6 +2,8 @@ SUMMARY = "TI RPMsg Char Sample Applications and Tests" > >>>>>> > >>>>>> require ti-rpmsg-char.inc > >>>>>> > >>>>>> +SRC_URI += "file://0001-examples-Remove-use-of-includedir-and-libdir.patch" > >>>>>> + > >>>>>> DEPENDS = "ti-rpmsg-char" > >>>>>> > >>>>>> inherit autotools pkgconfig > >>>>>> -- > >>>>>> 2.29.1 > >>>>>> > >>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>> > >> > >>> > >>> > >>> > >> > >> > >> > >> > >> > ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2020-10-29 21:56 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-25 6:59 [PATCH 1/2] ti-rpmsg-char-examples: Fix cross compile Khem Raj
2020-10-25 6:59 ` [PATCH 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific Khem Raj
2020-10-27 2:19 ` [meta-ti] " Suman Anna
2020-10-27 2:30 ` Khem Raj
2020-10-27 2:45 ` Suman Anna
[not found] ` <1641B95DDCF93CD1.11545@lists.yoctoproject.org>
2020-10-29 21:53 ` Suman Anna
2020-10-27 2:41 ` Denys Dmytriyenko
2020-10-26 21:20 ` [meta-ti] [PATCH 1/2] ti-rpmsg-char-examples: Fix cross compile Denys Dmytriyenko
2020-10-26 23:24 ` Khem Raj
2020-10-27 2:43 ` Denys Dmytriyenko
[not found] ` <1641B93D38E82508.16876@lists.yoctoproject.org>
2020-10-29 18:09 ` Denys Dmytriyenko
2020-10-29 20:09 ` Khem Raj
2020-10-29 21:50 ` Suman Anna
2020-10-29 21:56 ` Denys Dmytriyenko
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.