From: "hch@lst.de" <hch@lst.de>
To: "Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>
Cc: "iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
Robin Murphy <robin.murphy@arm.com>, "hch@lst.de" <hch@lst.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dma: Per-NUMA-node CMA should depend on NUMA
Date: Tue, 27 Oct 2020 08:54:52 +0100 [thread overview]
Message-ID: <20201027075452.GA22487@lst.de> (raw)
In-Reply-To: <75cad228694b4f1587265a887069b241@hisilicon.com>
On Mon, Oct 26, 2020 at 08:07:43PM +0000, Song Bao Hua (Barry Song) wrote:
> > diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig
> > index c99de4a21458..964b74c9b7e3 100644
> > --- a/kernel/dma/Kconfig
> > +++ b/kernel/dma/Kconfig
> > @@ -125,7 +125,8 @@ if DMA_CMA
> >
> > config DMA_PERNUMA_CMA
> > bool "Enable separate DMA Contiguous Memory Area for each NUMA
> > Node"
> > - default NUMA && ARM64
> > + depends on NUMA
> > + default ARM64
>
> On the other hand, at this moment, only ARM64 is calling the init code
> to get per_numa cma. Do we need to
> depends on NUMA && ARM64 ?
> so that this is not enabled by non-arm64?
I actually hate having arch symbols in common code. A new
ARCH_HAS_DMA_PERNUMA_CMA, only selected by arm64 for now would be more
clean I think.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: "hch@lst.de" <hch@lst.de>
To: "Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>
Cc: Robin Murphy <robin.murphy@arm.com>, "hch@lst.de" <hch@lst.de>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dma: Per-NUMA-node CMA should depend on NUMA
Date: Tue, 27 Oct 2020 08:54:52 +0100 [thread overview]
Message-ID: <20201027075452.GA22487@lst.de> (raw)
In-Reply-To: <75cad228694b4f1587265a887069b241@hisilicon.com>
On Mon, Oct 26, 2020 at 08:07:43PM +0000, Song Bao Hua (Barry Song) wrote:
> > diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig
> > index c99de4a21458..964b74c9b7e3 100644
> > --- a/kernel/dma/Kconfig
> > +++ b/kernel/dma/Kconfig
> > @@ -125,7 +125,8 @@ if DMA_CMA
> >
> > config DMA_PERNUMA_CMA
> > bool "Enable separate DMA Contiguous Memory Area for each NUMA
> > Node"
> > - default NUMA && ARM64
> > + depends on NUMA
> > + default ARM64
>
> On the other hand, at this moment, only ARM64 is calling the init code
> to get per_numa cma. Do we need to
> depends on NUMA && ARM64 ?
> so that this is not enabled by non-arm64?
I actually hate having arch symbols in common code. A new
ARCH_HAS_DMA_PERNUMA_CMA, only selected by arm64 for now would be more
clean I think.
next prev parent reply other threads:[~2020-10-27 7:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 12:24 [PATCH] dma: Per-NUMA-node CMA should depend on NUMA Robin Murphy
2020-10-26 12:24 ` Robin Murphy
2020-10-26 20:07 ` Song Bao Hua (Barry Song)
2020-10-26 20:07 ` Song Bao Hua (Barry Song)
2020-10-27 7:54 ` hch [this message]
2020-10-27 7:54 ` hch
2020-10-27 8:22 ` Song Bao Hua (Barry Song)
2020-10-27 8:22 ` Song Bao Hua (Barry Song)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027075452.GA22487@lst.de \
--to=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=song.bao.hua@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.