From: Kees Cook <keescook@chromium.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: catalin.marinas@arm.com,
Nick Desaulniers <ndesaulniers@google.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Jessica Yu <jeyu@kernel.org>,
will@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: vmlinux.lds: account for spurious empty .igot.plt sections
Date: Wed, 28 Oct 2020 08:56:14 -0700 [thread overview]
Message-ID: <202010280855.DE2EFB5DD@keescook> (raw)
In-Reply-To: <20201028133332.5571-1-ardb@kernel.org>
On Wed, Oct 28, 2020 at 02:33:32PM +0100, Ard Biesheuvel wrote:
> Now that we started making the linker warn about orphan sections
> (input sections that are not explicitly consumed by an output section),
> some configurations produce the following warning:
>
> aarch64-linux-gnu-ld: warning: orphan section `.igot.plt' from
> `arch/arm64/kernel/head.o' being placed in section `.igot.plt'
>
> It could be any file that triggers this - head.o is simply the first
> input file in the link - and the resulting .igot.plt section never
> actually appears in vmlinux as it turns out to be empty.
>
> So let's add .igot.plt to our collection of input sections to disregard
> unless they are empty.
typo: "non-empty"?
> Cc: Jessica Yu <jeyu@kernel.org>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Nick Desaulniers <ndesaulniers@google.com>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Thanks! Any idea what causes this?
Reviewed-by: Kees Cook <keescook@chromium.org>
Though I think Will already snagged the patch :)
--
Kees Cook
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-28 15:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 13:33 [PATCH] arm64: vmlinux.lds: account for spurious empty .igot.plt sections Ard Biesheuvel
2020-10-28 15:12 ` Will Deacon
2020-10-28 15:56 ` Kees Cook [this message]
2020-10-28 15:58 ` Ard Biesheuvel
2020-10-28 17:47 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202010280855.DE2EFB5DD@keescook \
--to=keescook@chromium.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=geert@linux-m68k.org \
--cc=jeyu@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=ndesaulniers@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.