From: Christoph Hellwig <hch@lst.de>
To: Jongpil Jung <jongpuls@gmail.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
gloria.tsai@ssstc.com, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, Jens Axboe <axboe@fb.com>,
jongpil19.jung@samsung.com, dj54.sohn@samsung.com,
Keith Busch <kbusch@kernel.org>,
jongheony.kim@samsung.com, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001
Date: Wed, 28 Oct 2020 18:17:26 +0100 [thread overview]
Message-ID: <20201028171726.GA9897@lst.de> (raw)
In-Reply-To: <20201028091421.GA667673@image-900X5T-900X5U>
On Wed, Oct 28, 2020 at 06:14:21PM +0900, Jongpil Jung wrote:
> LiteON(SSSTC) CL1 device running FW 220TQ,22001 has bugs with simple
> suspend.
>
> When NVMe device receive D3hot from host, NVMe firmware will do
> garbage collection. While NVMe device do Garbage collection,
> firmware has chance to going incorrect address.
I'm still lost on what this means. The device doesn't receive 'D3hot'
from the host, it receives a shutdown request. And we don't just do
that when hibernating, but also when doing an actual shutdown, a suspend
to disk, unbinding the driver, etc. So if the device has a problem
with shutdowns we really are in trouble.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jongpil Jung <jongpuls@gmail.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
gloria.tsai@ssstc.com, jongpil19.jung@samsung.com,
jongheony.kim@samsung.com, dj54.sohn@samsung.com
Subject: Re: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001
Date: Wed, 28 Oct 2020 18:17:26 +0100 [thread overview]
Message-ID: <20201028171726.GA9897@lst.de> (raw)
In-Reply-To: <20201028091421.GA667673@image-900X5T-900X5U>
On Wed, Oct 28, 2020 at 06:14:21PM +0900, Jongpil Jung wrote:
> LiteON(SSSTC) CL1 device running FW 220TQ,22001 has bugs with simple
> suspend.
>
> When NVMe device receive D3hot from host, NVMe firmware will do
> garbage collection. While NVMe device do Garbage collection,
> firmware has chance to going incorrect address.
I'm still lost on what this means. The device doesn't receive 'D3hot'
from the host, it receives a shutdown request. And we don't just do
that when hibernating, but also when doing an actual shutdown, a suspend
to disk, unbinding the driver, etc. So if the device has a problem
with shutdowns we really are in trouble.
next prev parent reply other threads:[~2020-10-28 17:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 9:14 [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001 Jongpil Jung
2020-10-28 9:14 ` Jongpil Jung
2020-10-28 17:17 ` Christoph Hellwig [this message]
2020-10-28 17:17 ` Christoph Hellwig
2020-10-29 2:20 ` Gloria Tsai
2020-10-29 2:20 ` Gloria Tsai
2020-10-29 2:33 ` Keith Busch
2020-10-29 2:33 ` Keith Busch
2020-10-29 3:15 ` Keith Busch
2020-10-29 3:15 ` Keith Busch
2020-10-29 3:21 ` Gloria Tsai
2020-10-29 3:21 ` Gloria Tsai
2020-10-29 14:55 ` Christoph Hellwig
2020-10-29 14:55 ` Christoph Hellwig
2020-11-02 18:13 ` Christoph Hellwig
2020-11-02 18:13 ` Christoph Hellwig
2020-11-03 2:21 ` Gloria Tsai
2020-11-03 2:21 ` Gloria Tsai
2020-11-03 9:23 ` Christoph Hellwig
2020-11-03 9:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028171726.GA9897@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=dj54.sohn@samsung.com \
--cc=gloria.tsai@ssstc.com \
--cc=jongheony.kim@samsung.com \
--cc=jongpil19.jung@samsung.com \
--cc=jongpuls@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.