Re: [PATCH RESEND v2 1/3] arm64: wrap and generalise counter read functions

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2914 bytes --]

Hi Ionela,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 3650b228f83adda7e5ee532e2b90429c03f7b9ec]

url:    https://github.com/0day-ci/linux/commits/Ionela-Voinescu/arm64-cppc-add-FFH-support-using-AMUs/20201028-004534
base:    3650b228f83adda7e5ee532e2b90429c03f7b9ec
config: arm64-randconfig-r001-20201028 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 50dfa19cc799ae7cddd39a95dbfce675a12672ad)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/bcdb8bb7da562e2438f66eeb357a724c6484e6bb
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ionela-Voinescu/arm64-cppc-add-FFH-support-using-AMUs/20201028-004534
        git checkout bcdb8bb7da562e2438f66eeb357a724c6484e6bb
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> arch/arm64/kernel/topology.c:281:6: warning: no previous prototype for function 'topology_scale_freq_tick' [-Wmissing-prototypes]
   void topology_scale_freq_tick(void)
        ^
   arch/arm64/kernel/topology.c:281:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void topology_scale_freq_tick(void)
   ^
   static 
   arch/arm64/kernel/topology.c:140:1: warning: unused function 'store_corecnt' [-Wunused-function]
   COUNTER_READ_STORE(corecnt, 0);
   ^
   arch/arm64/kernel/topology.c:131:20: note: expanded from macro 'COUNTER_READ_STORE'
   static inline void store_##NAME(void *val) \
                      ^
   <scratch space>:206:1: note: expanded from here
   store_corecnt
   ^
   arch/arm64/kernel/topology.c:141:1: warning: unused function 'store_constcnt' [-Wunused-function]
   COUNTER_READ_STORE(constcnt, 0);
   ^
   arch/arm64/kernel/topology.c:131:20: note: expanded from macro 'COUNTER_READ_STORE'
   static inline void store_##NAME(void *val) \
                      ^
   <scratch space>:209:1: note: expanded from here
   store_constcnt
   ^
   3 warnings generated.

vim +/topology_scale_freq_tick +281 arch/arm64/kernel/topology.c

cd0ed03a8903a0b Ionela Voinescu 2020-03-05  280  
cd0ed03a8903a0b Ionela Voinescu 2020-03-05 @281  void topology_scale_freq_tick(void)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33937 bytes --]