From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Waiman Long <longman@redhat.com>
Cc: Nathan Lynch <nathanl@linux.ibm.com>,
Gautham R Shenoy <ego@linux.vnet.ibm.com>,
Phil Auld <pauld@redhat.com>, Juri Lelli <juri.lelli@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Valentin Schneider <valentin.schneider@arm.com>
Subject: Re: [PATCH 0/4] Powerpc: Better preemption for shared processor
Date: Thu, 29 Oct 2020 12:44:20 +0530 [thread overview]
Message-ID: <20201029071420.GA528281@linux.vnet.ibm.com> (raw)
In-Reply-To: <da67d6ce-f120-f61a-19ff-0ae4f1f5dac0@redhat.com>
* Waiman Long <longman@redhat.com> [2020-10-28 20:01:30]:
> > Srikar Dronamraju (4):
> > powerpc: Refactor is_kvm_guest declaration to new header
> > powerpc: Rename is_kvm_guest to check_kvm_guest
> > powerpc: Reintroduce is_kvm_guest
> > powerpc/paravirt: Use is_kvm_guest in vcpu_is_preempted
> >
> > arch/powerpc/include/asm/firmware.h | 6 ------
> > arch/powerpc/include/asm/kvm_guest.h | 25 +++++++++++++++++++++++++
> > arch/powerpc/include/asm/kvm_para.h | 2 +-
> > arch/powerpc/include/asm/paravirt.h | 18 ++++++++++++++++++
> > arch/powerpc/kernel/firmware.c | 5 ++++-
> > arch/powerpc/platforms/pseries/smp.c | 3 ++-
> > 6 files changed, 50 insertions(+), 9 deletions(-)
> > create mode 100644 arch/powerpc/include/asm/kvm_guest.h
> >
> This patch series looks good to me and the performance is nice too.
>
> Acked-by: Waiman Long <longman@redhat.com>
Thank you.
>
> Just curious, is the performance mainly from the use of static_branch
> (patches 1 - 3) or from reducing call to yield_count_of().
Because of the reduced call to yield_count
>
> Cheers,
> Longman
>
--
Thanks and Regards
Srikar Dronamraju
WARNING: multiple messages have this Message-ID (diff)
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Waiman Long <longman@redhat.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
LKML <linux-kernel@vger.kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
Nathan Lynch <nathanl@linux.ibm.com>,
Gautham R Shenoy <ego@linux.vnet.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
Valentin Schneider <valentin.schneider@arm.com>,
Juri Lelli <juri.lelli@redhat.com>, Phil Auld <pauld@redhat.com>
Subject: Re: [PATCH 0/4] Powerpc: Better preemption for shared processor
Date: Thu, 29 Oct 2020 12:44:20 +0530 [thread overview]
Message-ID: <20201029071420.GA528281@linux.vnet.ibm.com> (raw)
In-Reply-To: <da67d6ce-f120-f61a-19ff-0ae4f1f5dac0@redhat.com>
* Waiman Long <longman@redhat.com> [2020-10-28 20:01:30]:
> > Srikar Dronamraju (4):
> > powerpc: Refactor is_kvm_guest declaration to new header
> > powerpc: Rename is_kvm_guest to check_kvm_guest
> > powerpc: Reintroduce is_kvm_guest
> > powerpc/paravirt: Use is_kvm_guest in vcpu_is_preempted
> >
> > arch/powerpc/include/asm/firmware.h | 6 ------
> > arch/powerpc/include/asm/kvm_guest.h | 25 +++++++++++++++++++++++++
> > arch/powerpc/include/asm/kvm_para.h | 2 +-
> > arch/powerpc/include/asm/paravirt.h | 18 ++++++++++++++++++
> > arch/powerpc/kernel/firmware.c | 5 ++++-
> > arch/powerpc/platforms/pseries/smp.c | 3 ++-
> > 6 files changed, 50 insertions(+), 9 deletions(-)
> > create mode 100644 arch/powerpc/include/asm/kvm_guest.h
> >
> This patch series looks good to me and the performance is nice too.
>
> Acked-by: Waiman Long <longman@redhat.com>
Thank you.
>
> Just curious, is the performance mainly from the use of static_branch
> (patches 1 - 3) or from reducing call to yield_count_of().
Because of the reduced call to yield_count
>
> Cheers,
> Longman
>
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2020-10-29 7:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 12:35 [PATCH 0/4] Powerpc: Better preemption for shared processor Srikar Dronamraju
2020-10-28 12:35 ` Srikar Dronamraju
2020-10-28 12:35 ` [PATCH 1/4] powerpc: Refactor is_kvm_guest declaration to new header Srikar Dronamraju
2020-10-28 12:35 ` Srikar Dronamraju
2020-10-28 12:35 ` [PATCH 2/4] powerpc: Rename is_kvm_guest to check_kvm_guest Srikar Dronamraju
2020-10-28 12:35 ` Srikar Dronamraju
2020-10-28 12:35 ` [PATCH 3/4] powerpc: Reintroduce is_kvm_guest in a new avatar Srikar Dronamraju
2020-10-28 12:35 ` Srikar Dronamraju
2020-10-28 12:35 ` [PATCH 4/4] powerpc/paravirt: Use is_kvm_guest in vcpu_is_preempted Srikar Dronamraju
2020-10-28 12:35 ` Srikar Dronamraju
2020-10-29 0:01 ` [PATCH 0/4] Powerpc: Better preemption for shared processor Waiman Long
2020-10-29 0:01 ` Waiman Long
2020-10-29 7:14 ` Srikar Dronamraju [this message]
2020-10-29 7:14 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029071420.GA528281@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=ego@linux.vnet.ibm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=longman@redhat.com \
--cc=nathanl@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.