From: Greg KH <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] proc: switch over direct seq_read method calls to seq_read_iter
Date: Thu, 29 Oct 2020 11:32:55 +0100 [thread overview]
Message-ID: <20201029103255.GD3764182@kroah.com> (raw)
In-Reply-To: <20201029100950.46668-4-hch@lst.de>
On Thu, Oct 29, 2020 at 11:09:50AM +0100, Christoph Hellwig wrote:
> Switch over all instances used directly as methods using these sed
> expressions:
>
> sed -i -e 's/\.proc_read\(\s*=\s*\)seq_read/\.proc_read_iter\1seq_read_iter/g'
>
> This fixes a problem with the Android bionic test suite using /proc/cpuinfo
> and /proc/version for its splice based tests.
>
> Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
> Reported-by: Greg KH <gregkh@linuxfoundation.org>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
I tested some of these files, so might as well add my "mark":
Tested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2020-10-29 10:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 10:09 support splice reads on seq_file based procfs files Christoph Hellwig
2020-10-29 10:09 ` [PATCH 1/3] seq_file: add seq_read_iter Christoph Hellwig
2020-10-29 10:32 ` Greg KH
2020-10-29 10:09 ` [PATCH 2/3] proc: wire up generic_file_splice_read for iter ops Christoph Hellwig
2020-10-29 10:32 ` Greg KH
2020-10-29 10:09 ` [PATCH 3/3] proc: switch over direct seq_read method calls to seq_read_iter Christoph Hellwig
2020-10-29 10:32 ` Greg KH [this message]
2020-11-03 18:48 ` support splice reads on seq_file based procfs files Christoph Hellwig
2020-11-03 18:57 ` Linus Torvalds
2020-11-03 19:02 ` Christoph Hellwig
2020-11-03 19:07 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029103255.GD3764182@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adobriyan@gmail.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.