From: Christoph Hellwig <hch@lst.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
Greg KH <gregkh@linuxfoundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: support splice reads on seq_file based procfs files
Date: Tue, 3 Nov 2020 20:02:53 +0100 [thread overview]
Message-ID: <20201103190253.GA24382@lst.de> (raw)
In-Reply-To: <CAHk-=wha+F9-my8=3KO7TNJ7r-fVobMrXRdUuSs5c2bbqk1edA@mail.gmail.com>
On Tue, Nov 03, 2020 at 10:57:10AM -0800, Linus Torvalds wrote:
> On Tue, Nov 3, 2020 at 10:48 AM Christoph Hellwig <hch@lst.de> wrote:
> >
> > ping?
>
> It looked fine by me, although honestly, I'd prefer that last patch to
> be the minimum possible if we want this for 5.10.
>
> Yeah, that might technically be just cpuinfo, but I'd be ok with the
> other read-only core proc files (ie I would *not* add it to anything
> that has a .proc_write operation like the ones in proc_net.c).
>
> IOW, I'd start with just cpuinfo_proc_ops, proc_seq_ops,
> proc_single_ops, and stat_proc_ops.
I think Greg reported another test case hitting /proc/version
>
> Because honestly, I'd rather restrict splice() as much as possible
> than try to say "everything should be able to do splice".
sure.
next prev parent reply other threads:[~2020-11-03 19:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 10:09 support splice reads on seq_file based procfs files Christoph Hellwig
2020-10-29 10:09 ` [PATCH 1/3] seq_file: add seq_read_iter Christoph Hellwig
2020-10-29 10:32 ` Greg KH
2020-10-29 10:09 ` [PATCH 2/3] proc: wire up generic_file_splice_read for iter ops Christoph Hellwig
2020-10-29 10:32 ` Greg KH
2020-10-29 10:09 ` [PATCH 3/3] proc: switch over direct seq_read method calls to seq_read_iter Christoph Hellwig
2020-10-29 10:32 ` Greg KH
2020-11-03 18:48 ` support splice reads on seq_file based procfs files Christoph Hellwig
2020-11-03 18:57 ` Linus Torvalds
2020-11-03 19:02 ` Christoph Hellwig [this message]
2020-11-03 19:07 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103190253.GA24382@lst.de \
--to=hch@lst.de \
--cc=adobriyan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.