From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Zou Wei <zou_wei@huawei.com>
Cc: airlied@linux.ie, intel-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH -next] drm/i915: Remove unused variable ret
Date: Thu, 29 Oct 2020 15:27:43 +0200 [thread overview]
Message-ID: <20201029132743.GZ6112@intel.com> (raw)
In-Reply-To: <1603937925-53176-1-git-send-email-zou_wei@huawei.com>
On Thu, Oct 29, 2020 at 10:18:45AM +0800, Zou Wei wrote:
> This patch fixes below warnings reported by coccicheck
>
> ./drivers/gpu/drm/i915/i915_debugfs.c:789:5-8: Unneeded variable: "ret". Return "0" on line 1012
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Thanks. Applied.
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index ea46916..200f6b8 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -786,7 +786,6 @@ static int i915_frequency_info(struct seq_file *m, void *unused)
> struct intel_uncore *uncore = &dev_priv->uncore;
> struct intel_rps *rps = &dev_priv->gt.rps;
> intel_wakeref_t wakeref;
> - int ret = 0;
>
> wakeref = intel_runtime_pm_get(&dev_priv->runtime_pm);
>
> @@ -1009,7 +1008,7 @@ static int i915_frequency_info(struct seq_file *m, void *unused)
> seq_printf(m, "Max pixel clock frequency: %d kHz\n", dev_priv->max_dotclk_freq);
>
> intel_runtime_pm_put(&dev_priv->runtime_pm, wakeref);
> - return ret;
> + return 0;
> }
>
> static int i915_ring_freq_table(struct seq_file *m, void *unused)
> --
> 2.6.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Zou Wei <zou_wei@huawei.com>
Cc: airlied@linux.ie, intel-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
rodrigo.vivi@intel.com
Subject: Re: [PATCH -next] drm/i915: Remove unused variable ret
Date: Thu, 29 Oct 2020 15:27:43 +0200 [thread overview]
Message-ID: <20201029132743.GZ6112@intel.com> (raw)
In-Reply-To: <1603937925-53176-1-git-send-email-zou_wei@huawei.com>
On Thu, Oct 29, 2020 at 10:18:45AM +0800, Zou Wei wrote:
> This patch fixes below warnings reported by coccicheck
>
> ./drivers/gpu/drm/i915/i915_debugfs.c:789:5-8: Unneeded variable: "ret". Return "0" on line 1012
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Thanks. Applied.
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index ea46916..200f6b8 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -786,7 +786,6 @@ static int i915_frequency_info(struct seq_file *m, void *unused)
> struct intel_uncore *uncore = &dev_priv->uncore;
> struct intel_rps *rps = &dev_priv->gt.rps;
> intel_wakeref_t wakeref;
> - int ret = 0;
>
> wakeref = intel_runtime_pm_get(&dev_priv->runtime_pm);
>
> @@ -1009,7 +1008,7 @@ static int i915_frequency_info(struct seq_file *m, void *unused)
> seq_printf(m, "Max pixel clock frequency: %d kHz\n", dev_priv->max_dotclk_freq);
>
> intel_runtime_pm_put(&dev_priv->runtime_pm, wakeref);
> - return ret;
> + return 0;
> }
>
> static int i915_ring_freq_table(struct seq_file *m, void *unused)
> --
> 2.6.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Zou Wei <zou_wei@huawei.com>
Cc: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH -next] drm/i915: Remove unused variable ret
Date: Thu, 29 Oct 2020 15:27:43 +0200 [thread overview]
Message-ID: <20201029132743.GZ6112@intel.com> (raw)
In-Reply-To: <1603937925-53176-1-git-send-email-zou_wei@huawei.com>
On Thu, Oct 29, 2020 at 10:18:45AM +0800, Zou Wei wrote:
> This patch fixes below warnings reported by coccicheck
>
> ./drivers/gpu/drm/i915/i915_debugfs.c:789:5-8: Unneeded variable: "ret". Return "0" on line 1012
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Thanks. Applied.
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index ea46916..200f6b8 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -786,7 +786,6 @@ static int i915_frequency_info(struct seq_file *m, void *unused)
> struct intel_uncore *uncore = &dev_priv->uncore;
> struct intel_rps *rps = &dev_priv->gt.rps;
> intel_wakeref_t wakeref;
> - int ret = 0;
>
> wakeref = intel_runtime_pm_get(&dev_priv->runtime_pm);
>
> @@ -1009,7 +1008,7 @@ static int i915_frequency_info(struct seq_file *m, void *unused)
> seq_printf(m, "Max pixel clock frequency: %d kHz\n", dev_priv->max_dotclk_freq);
>
> intel_runtime_pm_put(&dev_priv->runtime_pm, wakeref);
> - return ret;
> + return 0;
> }
>
> static int i915_ring_freq_table(struct seq_file *m, void *unused)
> --
> 2.6.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2020-10-29 13:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 2:18 [Intel-gfx] [PATCH -next] drm/i915: Remove unused variable ret Zou Wei
2020-10-29 2:18 ` Zou Wei
2020-10-29 2:18 ` Zou Wei
2020-10-29 13:27 ` Ville Syrjälä [this message]
2020-10-29 13:27 ` Ville Syrjälä
2020-10-29 13:27 ` Ville Syrjälä
2020-10-29 17:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029132743.GZ6112@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.