All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Łukasz Stelmach" <l.stelmach@samsung.com>
Cc: "Heiner Kallweit" <hkallweit1@gmail.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Jakub Kicinski" <kuba@kernel.org>,
	netdev@vger.kernel.org, "Russell King" <linux@armlinux.org.uk>,
	linux-samsung-soc@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	jim.cromie@gmail.com,
	"Bartłomiej Żolnierkiewicz" <b.zolnierkie@samsung.com>,
	"Andrew Lunn" <andrew@lunn.ch>,
	devicetree@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
	linux-kernel@vger.kernel.org, "Kukjin Kim" <kgene@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	"Marek Szyprowski" <m.szyprowski@samsung.com>
Subject: Re: [PATCH v4 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter
Date: Thu, 29 Oct 2020 10:28:25 -0500	[thread overview]
Message-ID: <20201029152825.GA1904089@bogus> (raw)
In-Reply-To: <20201028214012.9712-3-l.stelmach@samsung.com>

On Wed, 28 Oct 2020 22:40:09 +0100, Łukasz Stelmach wrote:
> Add bindings for AX88796C SPI Ethernet Adapter.
> 
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
>  .../bindings/net/asix,ax88796c.yaml           | 69 +++++++++++++++++++
>  1 file changed, 69 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/asix,ax88796c.yaml
> 


My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/net/asix,ax88796c.example.dts:23.13-25: Warning (reg_format): /example-0/ethernet@0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
Documentation/devicetree/bindings/net/asix,ax88796c.example.dt.yaml: Warning (pci_device_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/net/asix,ax88796c.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/net/asix,ax88796c.example.dt.yaml: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/net/asix,ax88796c.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/net/asix,ax88796c.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/asix,ax88796c.example.dt.yaml: example-0: ethernet@0:reg:0: [0] is too short
	From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/asix,ax88796c.example.dt.yaml: ethernet@0: 'interrupt-parrent' is a required property
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/asix,ax88796c.yaml


See https://patchwork.ozlabs.org/patch/1389785

The base for the patch is generally the last rc1. Any dependencies
should be noted.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Łukasz Stelmach" <l.stelmach@samsung.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
	linux-samsung-soc@vger.kernel.org,
	"Bartłomiej Żolnierkiewicz" <b.zolnierkie@samsung.com>,
	jim.cromie@gmail.com, netdev@vger.kernel.org,
	"Russell King" <linux@armlinux.org.uk>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	"Rob Herring" <robh+dt@kernel.org>,
	"Kukjin Kim" <kgene@kernel.org>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org,
	"Heiner Kallweit" <hkallweit1@gmail.com>
Subject: Re: [PATCH v4 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter
Date: Thu, 29 Oct 2020 10:28:25 -0500	[thread overview]
Message-ID: <20201029152825.GA1904089@bogus> (raw)
In-Reply-To: <20201028214012.9712-3-l.stelmach@samsung.com>

On Wed, 28 Oct 2020 22:40:09 +0100, Łukasz Stelmach wrote:
> Add bindings for AX88796C SPI Ethernet Adapter.
> 
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
>  .../bindings/net/asix,ax88796c.yaml           | 69 +++++++++++++++++++
>  1 file changed, 69 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/asix,ax88796c.yaml
> 


My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/net/asix,ax88796c.example.dts:23.13-25: Warning (reg_format): /example-0/ethernet@0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
Documentation/devicetree/bindings/net/asix,ax88796c.example.dt.yaml: Warning (pci_device_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/net/asix,ax88796c.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/net/asix,ax88796c.example.dt.yaml: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/net/asix,ax88796c.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/net/asix,ax88796c.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/asix,ax88796c.example.dt.yaml: example-0: ethernet@0:reg:0: [0] is too short
	From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/asix,ax88796c.example.dt.yaml: ethernet@0: 'interrupt-parrent' is a required property
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/asix,ax88796c.yaml


See https://patchwork.ozlabs.org/patch/1389785

The base for the patch is generally the last rc1. Any dependencies
should be noted.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-10-29 15:28 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20201028214017eucas1p21a93b489acce80ff8a2fd1adfc9c1649@eucas1p2.samsung.com>
2020-10-28 21:40 ` [PATCH v4 0/5] AX88796C SPI Ethernet Adapter Łukasz Stelmach
2020-10-28 21:40   ` Łukasz Stelmach
2020-10-28 21:40   ` [PATCH v4 1/5] dt-bindings: vendor-prefixes: Add asix prefix Łukasz Stelmach
2020-10-28 21:40     ` Łukasz Stelmach
2020-10-28 21:40   ` [PATCH v4 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter Łukasz Stelmach
2020-10-28 21:40     ` Łukasz Stelmach
2020-10-29 15:28     ` Rob Herring [this message]
2020-10-29 15:28       ` Rob Herring
2020-10-29 17:06     ` Marc Kleine-Budde
2020-10-29 17:06       ` Marc Kleine-Budde
2020-10-29 20:06       ` Lukasz Stelmach
2020-10-29 20:06         ` Lukasz Stelmach
2020-10-28 21:40   ` [PATCH v4 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver Łukasz Stelmach
2020-10-28 21:40     ` Łukasz Stelmach
2020-10-29  0:31     ` Andrew Lunn
2020-10-29  0:31       ` Andrew Lunn
2020-10-29 13:09       ` Lukasz Stelmach
2020-10-29 13:09         ` Lukasz Stelmach
2020-10-29 20:31       ` Lukasz Stelmach
2020-10-29 20:31         ` Lukasz Stelmach
2020-10-29 21:06         ` Andrew Lunn
2020-10-29 21:06           ` Andrew Lunn
2020-10-29 17:27     ` Marc Kleine-Budde
2020-10-29 17:27       ` Marc Kleine-Budde
2020-10-29 23:01       ` Lukasz Stelmach
2020-10-29 23:01         ` Lukasz Stelmach
2020-10-28 21:40   ` [PATCH v4 4/5] ARM: dts: exynos: Add Ethernet to Artik 5 board Łukasz Stelmach
2020-10-28 21:40     ` Łukasz Stelmach
2020-10-28 21:40   ` [PATCH v4 5/5] ARM: defconfig: Enable ax88796c driver Łukasz Stelmach
2020-10-28 21:40     ` Łukasz Stelmach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201029152825.GA1904089@bogus \
    --to=robh@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=b.zolnierkie@samsung.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=jim.cromie@gmail.com \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kuba@kernel.org \
    --cc=l.stelmach@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=m.szyprowski@samsung.com \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.