From: mka@chromium.org
To: Akhil P Oommen <akhilpo@codeaurora.org>
Cc: freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
dianders@chromium.org, dri-devel@freedesktop.org
Subject: Re: [v4,1/3] drm/msm: Add support for GPU cooling
Date: Thu, 29 Oct 2020 13:48:42 -0700 [thread overview]
Message-ID: <20201029204842.GC1855806@google.com> (raw)
In-Reply-To: <1603958841-20233-1-git-send-email-akhilpo@codeaurora.org>
On Thu, Oct 29, 2020 at 01:37:19PM +0530, Akhil P Oommen wrote:
> Register GPU as a devfreq cooling device so that it can be passively
> cooled by the thermal framework.
>
> Signed-off-by: Akhil P Oommen <akhilpo@codeaurora.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Wait, I did not post a 'Reviewed-by' tag for this patch!
I think the patch should be ok, but I'm still not super happy
about the resource management involving devfreq in general (see
discussion on https://patchwork.freedesktop.org/patch/394291/?series=82476&rev=1).
It's not really something introduced by this patch, but if it ever
gets fixed releasing the cooling device at the end of
msm_gpu_cleanup() after everything else might cause trouble.
In summary, I'm supportive of landing this patch, but reluctant to
'sign it off' because of the above.
In any case:
Tested-by: Matthias Kaehlcke <mka@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: mka@chromium.org
To: Akhil P Oommen <akhilpo@codeaurora.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
dianders@chromium.org, linux-kernel@vger.kernel.org,
dri-devel@freedesktop.org, freedreno@lists.freedesktop.org
Subject: Re: [v4,1/3] drm/msm: Add support for GPU cooling
Date: Thu, 29 Oct 2020 13:48:42 -0700 [thread overview]
Message-ID: <20201029204842.GC1855806@google.com> (raw)
In-Reply-To: <1603958841-20233-1-git-send-email-akhilpo@codeaurora.org>
On Thu, Oct 29, 2020 at 01:37:19PM +0530, Akhil P Oommen wrote:
> Register GPU as a devfreq cooling device so that it can be passively
> cooled by the thermal framework.
>
> Signed-off-by: Akhil P Oommen <akhilpo@codeaurora.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Wait, I did not post a 'Reviewed-by' tag for this patch!
I think the patch should be ok, but I'm still not super happy
about the resource management involving devfreq in general (see
discussion on https://patchwork.freedesktop.org/patch/394291/?series=82476&rev=1).
It's not really something introduced by this patch, but if it ever
gets fixed releasing the cooling device at the end of
msm_gpu_cleanup() after everything else might cause trouble.
In summary, I'm supportive of landing this patch, but reluctant to
'sign it off' because of the above.
In any case:
Tested-by: Matthias Kaehlcke <mka@chromium.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-10-29 20:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 8:07 [PATCH v4 1/3] drm/msm: Add support for GPU cooling Akhil P Oommen
2020-10-29 8:07 ` Akhil P Oommen
2020-10-29 8:07 ` [PATCH v4 2/3] arm64: dts: qcom: sc7180: Add gpu cooling support Akhil P Oommen
2020-10-29 8:07 ` Akhil P Oommen
2020-10-29 8:07 ` [PATCH v4 3/3] dt-bindings: drm/msm/gpu: Add cooling device support Akhil P Oommen
2020-10-29 8:07 ` Akhil P Oommen
2020-10-30 13:38 ` Rob Herring
2020-10-30 13:38 ` Rob Herring
2020-10-29 20:48 ` mka [this message]
2020-10-29 20:48 ` [v4,1/3] drm/msm: Add support for GPU cooling mka
2020-10-30 5:07 ` Akhil P Oommen
2020-10-30 5:07 ` Akhil P Oommen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029204842.GC1855806@google.com \
--to=mka@chromium.org \
--cc=akhilpo@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.