* [PATCH v2 1/2] ti-rpmsg-char-examples: Fix cross compile
@ 2020-10-30 1:46 Khem Raj
2020-10-30 1:46 ` [PATCH v2 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific Khem Raj
2020-10-30 4:15 ` [meta-ti] [PATCH v2 1/2] ti-rpmsg-char-examples: Fix cross compile Denys Dmytriyenko
0 siblings, 2 replies; 5+ messages in thread
From: Khem Raj @ 2020-10-30 1:46 UTC (permalink / raw)
To: meta-ti; +Cc: Khem Raj
This fixes problems during cross compile where it starts to peek into
build host's include and library paths and causes errors with clang and
QA warnings with gcc
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
v2: Add upstream status
...-Remove-use-of-includedir-and-libdir.patch | 38 +++++++++++++++++++
recipes-ti/ipc/ti-rpmsg-char-examples_git.bb | 2 +
2 files changed, 40 insertions(+)
create mode 100644 recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch
diff --git a/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch b/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch
new file mode 100644
index 00000000..71fca1b0
--- /dev/null
+++ b/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch
@@ -0,0 +1,38 @@
+From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Sat, 24 Oct 2020 23:46:39 -0700
+Subject: [PATCH] examples: Remove use of includedir and libdir
+
+These point to standard include and library paths which already are used
+from sysroot relative paths secondly, they use absolute paths which
+means we are asking to add -I/usr/include which might be ok in a native
+build but not in cross build. This helps mitigate QA errors found with
+OE build system since it finds it adding host include and library search
+paths to linker/compiler commandline
+
+Upstream-Status: Pending
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+---
+ examples/Makefile.am | 5 +----
+ 1 file changed, 1 insertion(+), 4 deletions(-)
+
+diff --git a/examples/Makefile.am b/examples/Makefile.am
+index 5a9bedb..d547e41 100644
+--- a/examples/Makefile.am
++++ b/examples/Makefile.am
+@@ -1,6 +1,4 @@
+-INCLUDE = -I${includedir}
+-
+-AM_CFLAGS = -Wall -g -O2 $(INCLUDE)
++AM_CFLAGS = -Wall -g -O2
+
+ bin_PROGRAMS = rpmsg_char_simple
+
+@@ -8,4 +6,3 @@ bin_PROGRAMS = rpmsg_char_simple
+ rpmsg_char_simple_SOURCES = rpmsg_char_simple.c
+ rpmsg_char_simple_CPPFLAGS = $(AM_CFLAGS)
+ rpmsg_char_simple_LDADD = -lpthread -lti_rpmsg_char
+-rpmsg_char_simple_LDFLAGS = -L${libdir}
+--
+2.29.1
+
diff --git a/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb b/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb
index 142e5bf0..cbe4d7fd 100644
--- a/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb
+++ b/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb
@@ -2,6 +2,8 @@ SUMMARY = "TI RPMsg Char Sample Applications and Tests"
require ti-rpmsg-char.inc
+SRC_URI += "file://0001-examples-Remove-use-of-includedir-and-libdir.patch"
+
DEPENDS = "ti-rpmsg-char"
inherit autotools pkgconfig
--
2.29.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific
2020-10-30 1:46 [PATCH v2 1/2] ti-rpmsg-char-examples: Fix cross compile Khem Raj
@ 2020-10-30 1:46 ` Khem Raj
2020-10-30 4:15 ` [meta-ti] " Denys Dmytriyenko
2020-10-30 4:15 ` [meta-ti] [PATCH v2 1/2] ti-rpmsg-char-examples: Fix cross compile Denys Dmytriyenko
1 sibling, 1 reply; 5+ messages in thread
From: Khem Raj @ 2020-10-30 1:46 UTC (permalink / raw)
To: meta-ti; +Cc: Khem Raj
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
recipes-ti/ipc/ti-rpmsg-char.inc | 3 +++
1 file changed, 3 insertions(+)
diff --git a/recipes-ti/ipc/ti-rpmsg-char.inc b/recipes-ti/ipc/ti-rpmsg-char.inc
index b41e68eb..d08031cb 100644
--- a/recipes-ti/ipc/ti-rpmsg-char.inc
+++ b/recipes-ti/ipc/ti-rpmsg-char.inc
@@ -13,3 +13,6 @@ SRCREV = "9be402c2bf4053900b6b9a8092fbb42e7e303108"
PV = "0.1.0+git${SRCPV}"
S = "${WORKDIR}/git"
+
+COMPATIBLE_HOST ?= "null"
+COMPATIBLE_HOST_ti-soc = "(.*)"
--
2.29.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [meta-ti] [PATCH v2 1/2] ti-rpmsg-char-examples: Fix cross compile
2020-10-30 1:46 [PATCH v2 1/2] ti-rpmsg-char-examples: Fix cross compile Khem Raj
2020-10-30 1:46 ` [PATCH v2 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific Khem Raj
@ 2020-10-30 4:15 ` Denys Dmytriyenko
1 sibling, 0 replies; 5+ messages in thread
From: Denys Dmytriyenko @ 2020-10-30 4:15 UTC (permalink / raw)
To: Khem Raj; +Cc: meta-ti
On Thu, Oct 29, 2020 at 06:46:00PM -0700, Khem Raj wrote:
> This fixes problems during cross compile where it starts to peek into
> build host's include and library paths and causes errors with clang and
> QA warnings with gcc
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Reviewed-by: Denys Dmytriyenko <denys@ti.com>
> ---
> v2: Add upstream status
>
> ...-Remove-use-of-includedir-and-libdir.patch | 38 +++++++++++++++++++
> recipes-ti/ipc/ti-rpmsg-char-examples_git.bb | 2 +
> 2 files changed, 40 insertions(+)
> create mode 100644 recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch
>
> diff --git a/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch b/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch
> new file mode 100644
> index 00000000..71fca1b0
> --- /dev/null
> +++ b/recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch
> @@ -0,0 +1,38 @@
> +From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 2001
> +From: Khem Raj <raj.khem@gmail.com>
> +Date: Sat, 24 Oct 2020 23:46:39 -0700
> +Subject: [PATCH] examples: Remove use of includedir and libdir
> +
> +These point to standard include and library paths which already are used
> +from sysroot relative paths secondly, they use absolute paths which
> +means we are asking to add -I/usr/include which might be ok in a native
> +build but not in cross build. This helps mitigate QA errors found with
> +OE build system since it finds it adding host include and library search
> +paths to linker/compiler commandline
> +
> +Upstream-Status: Pending
> +Signed-off-by: Khem Raj <raj.khem@gmail.com>
> +---
> + examples/Makefile.am | 5 +----
> + 1 file changed, 1 insertion(+), 4 deletions(-)
> +
> +diff --git a/examples/Makefile.am b/examples/Makefile.am
> +index 5a9bedb..d547e41 100644
> +--- a/examples/Makefile.am
> ++++ b/examples/Makefile.am
> +@@ -1,6 +1,4 @@
> +-INCLUDE = -I${includedir}
> +-
> +-AM_CFLAGS = -Wall -g -O2 $(INCLUDE)
> ++AM_CFLAGS = -Wall -g -O2
> +
> + bin_PROGRAMS = rpmsg_char_simple
> +
> +@@ -8,4 +6,3 @@ bin_PROGRAMS = rpmsg_char_simple
> + rpmsg_char_simple_SOURCES = rpmsg_char_simple.c
> + rpmsg_char_simple_CPPFLAGS = $(AM_CFLAGS)
> + rpmsg_char_simple_LDADD = -lpthread -lti_rpmsg_char
> +-rpmsg_char_simple_LDFLAGS = -L${libdir}
> +--
> +2.29.1
> +
> diff --git a/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb b/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb
> index 142e5bf0..cbe4d7fd 100644
> --- a/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb
> +++ b/recipes-ti/ipc/ti-rpmsg-char-examples_git.bb
> @@ -2,6 +2,8 @@ SUMMARY = "TI RPMsg Char Sample Applications and Tests"
>
> require ti-rpmsg-char.inc
>
> +SRC_URI += "file://0001-examples-Remove-use-of-includedir-and-libdir.patch"
> +
> DEPENDS = "ti-rpmsg-char"
>
> inherit autotools pkgconfig
> --
> 2.29.1
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-ti] [PATCH v2 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific
2020-10-30 1:46 ` [PATCH v2 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific Khem Raj
@ 2020-10-30 4:15 ` Denys Dmytriyenko
2020-10-30 4:19 ` Suman Anna
0 siblings, 1 reply; 5+ messages in thread
From: Denys Dmytriyenko @ 2020-10-30 4:15 UTC (permalink / raw)
To: Khem Raj; +Cc: meta-ti
On Thu, Oct 29, 2020 at 06:46:01PM -0700, Khem Raj wrote:
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Reviewed-by: Denys Dmytriyenko <denys@ti.com>
> ---
> recipes-ti/ipc/ti-rpmsg-char.inc | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/recipes-ti/ipc/ti-rpmsg-char.inc b/recipes-ti/ipc/ti-rpmsg-char.inc
> index b41e68eb..d08031cb 100644
> --- a/recipes-ti/ipc/ti-rpmsg-char.inc
> +++ b/recipes-ti/ipc/ti-rpmsg-char.inc
> @@ -13,3 +13,6 @@ SRCREV = "9be402c2bf4053900b6b9a8092fbb42e7e303108"
> PV = "0.1.0+git${SRCPV}"
>
> S = "${WORKDIR}/git"
> +
> +COMPATIBLE_HOST ?= "null"
> +COMPATIBLE_HOST_ti-soc = "(.*)"
> --
> 2.29.1
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-ti] [PATCH v2 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific
2020-10-30 4:15 ` [meta-ti] " Denys Dmytriyenko
@ 2020-10-30 4:19 ` Suman Anna
0 siblings, 0 replies; 5+ messages in thread
From: Suman Anna @ 2020-10-30 4:19 UTC (permalink / raw)
To: denys, Khem Raj; +Cc: meta-ti
On 10/29/20 11:15 PM, Denys Dmytriyenko via lists.yoctoproject.org wrote:
> On Thu, Oct 29, 2020 at 06:46:01PM -0700, Khem Raj wrote:
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>
> Reviewed-by: Denys Dmytriyenko <denys@ti.com>
Adding mine back again,
Reviewed-by: Suman Anna <s-anna@ti.com>
regards
Suman
>
>
>> ---
>> recipes-ti/ipc/ti-rpmsg-char.inc | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/recipes-ti/ipc/ti-rpmsg-char.inc b/recipes-ti/ipc/ti-rpmsg-char.inc
>> index b41e68eb..d08031cb 100644
>> --- a/recipes-ti/ipc/ti-rpmsg-char.inc
>> +++ b/recipes-ti/ipc/ti-rpmsg-char.inc
>> @@ -13,3 +13,6 @@ SRCREV = "9be402c2bf4053900b6b9a8092fbb42e7e303108"
>> PV = "0.1.0+git${SRCPV}"
>>
>> S = "${WORKDIR}/git"
>> +
>> +COMPATIBLE_HOST ?= "null"
>> +COMPATIBLE_HOST_ti-soc = "(.*)"
>> --
>> 2.29.1
>>
>
>>
>>
>>
>
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-30 4:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-30 1:46 [PATCH v2 1/2] ti-rpmsg-char-examples: Fix cross compile Khem Raj
2020-10-30 1:46 ` [PATCH v2 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific Khem Raj
2020-10-30 4:15 ` [meta-ti] " Denys Dmytriyenko
2020-10-30 4:19 ` Suman Anna
2020-10-30 4:15 ` [meta-ti] [PATCH v2 1/2] ti-rpmsg-char-examples: Fix cross compile Denys Dmytriyenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.