From: Christoph Hellwig <hch@infradead.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: akpm@linux-foundation.org, Randy Dunlap <rdunlap@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
kernel test robot <lkp@intel.com>,
Joao Martins <joao.m.martins@oracle.com>,
x86@kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org
Subject: Re: [PATCH] x86/mm: Fix phys_to_target_node() export
Date: Sat, 31 Oct 2020 09:10:12 +0000 [thread overview]
Message-ID: <20201031091012.GA27844@infradead.org> (raw)
In-Reply-To: <160402498564.4173389.2743697400148832021.stgit@dwillia2-desk3.amr.corp.intel.com>
On Thu, Oct 29, 2020 at 07:29:45PM -0700, Dan Williams wrote:
> The core-mm has a default __weak implementation of phys_to_target_node()
> when the architecture does not override it. That symbol is exported
> for modules. However, while the export in mm/memory_hotplug.c exported
> the symbol in the configuration cases of:
Which just means that we should never export weak symbols. So instead
of hacking around this introduce a symbol that indicates that the
architecture impements phys_to_target_node, and don't defined it at all
in common code for that case.
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -365,9 +365,14 @@ int __weak phys_to_target_node(u64 start)
> start);
> return 0;
> }
> +
> +/* If the arch did not export a strong symbol, export the weak one. */
> +#ifndef CONFIG_NUMA_KEEP_MEMINFO
> EXPORT_SYMBOL_GPL(phys_to_target_node);
> #endif
>
> +#endif
i.e. move the ifdef to include the actual phys_to_target_node
definition, and remove the __weak from it here.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: akpm@linux-foundation.org, Randy Dunlap <rdunlap@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
kernel test robot <lkp@intel.com>,
Joao Martins <joao.m.martins@oracle.com>,
x86@kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org
Subject: Re: [PATCH] x86/mm: Fix phys_to_target_node() export
Date: Sat, 31 Oct 2020 09:10:12 +0000 [thread overview]
Message-ID: <20201031091012.GA27844@infradead.org> (raw)
In-Reply-To: <160402498564.4173389.2743697400148832021.stgit@dwillia2-desk3.amr.corp.intel.com>
On Thu, Oct 29, 2020 at 07:29:45PM -0700, Dan Williams wrote:
> The core-mm has a default __weak implementation of phys_to_target_node()
> when the architecture does not override it. That symbol is exported
> for modules. However, while the export in mm/memory_hotplug.c exported
> the symbol in the configuration cases of:
Which just means that we should never export weak symbols. So instead
of hacking around this introduce a symbol that indicates that the
architecture impements phys_to_target_node, and don't defined it at all
in common code for that case.
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -365,9 +365,14 @@ int __weak phys_to_target_node(u64 start)
> start);
> return 0;
> }
> +
> +/* If the arch did not export a strong symbol, export the weak one. */
> +#ifndef CONFIG_NUMA_KEEP_MEMINFO
> EXPORT_SYMBOL_GPL(phys_to_target_node);
> #endif
>
> +#endif
i.e. move the ifdef to include the actual phys_to_target_node
definition, and remove the __weak from it here.
next prev parent reply other threads:[~2020-10-31 9:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 2:29 [PATCH] x86/mm: Fix phys_to_target_node() export Dan Williams
2020-10-30 2:29 ` Dan Williams
2020-10-30 3:05 ` Randy Dunlap
2020-10-30 3:05 ` Randy Dunlap
2020-10-30 11:34 ` David Hildenbrand
2020-10-30 11:34 ` David Hildenbrand
2020-10-31 1:54 ` Dan Williams
2020-10-31 1:54 ` Dan Williams
2020-10-31 3:01 ` Thomas Gleixner
2020-10-31 3:01 ` Thomas Gleixner
2020-10-31 4:45 ` Dan Williams
2020-10-31 4:45 ` Dan Williams
2020-10-31 9:10 ` Christoph Hellwig [this message]
2020-10-31 9:10 ` Christoph Hellwig
2020-11-02 23:52 ` Dan Williams
2020-11-02 23:52 ` Dan Williams
2020-11-03 0:59 ` Randy Dunlap
2020-11-03 0:59 ` Randy Dunlap
2020-11-03 8:33 ` Christoph Hellwig
2020-11-03 8:33 ` Christoph Hellwig
2020-11-03 10:39 ` Thomas Gleixner
2020-11-03 10:39 ` Thomas Gleixner
2020-11-04 1:38 ` Andrew Morton
2020-11-04 1:38 ` Andrew Morton
2020-11-04 1:49 ` Dan Williams
2020-11-04 1:49 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201031091012.GA27844@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=joao.m.martins@oracle.com \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=lkp@intel.com \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.