From: Marcos Antonio de Jesus Filho <mdejesusfilho@gmail.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Forest Bond <forest@alittletooquiet.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 0/3] staging: vt6655: Remove else after return
Date: Sat, 31 Oct 2020 07:25:19 -0700 [thread overview]
Message-ID: <20201031142519.GA1965@Zangetsu> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2010311036290.2733@hadrien>
On Sat, Oct 31, 2020 at 10:37:02AM +0100, Julia Lawall wrote:
>
>
> On Sat, 31 Oct 2020, Marcos Antonio de Jesus Filho wrote:
>
> > This patchset removes multiples useless else statements after return statements. Reported by check patch.
> >
> > Observation
> > -----------
> >
> > After cleaning up the code I noticed that the code from 530 to 548 repeats at 551,569 and that it can be removed and one of the conditional statements can be simplified.
> >
> > Marcos Antonio de Jesus Filho (3):
> > staging: vt6655: Remove useless else
> > staging: vt6655: Remove useless else
> > staging: vt6655: Remove useless else
>
> The patches need different subject lines.
How would I name patchs like this, that do the same thing but in different parts of the code?
>
> julia
>
> >
> > drivers/staging/vt6655/rxtx.c | 99 ++++++++++++++++++-----------------
> > 1 file changed, 51 insertions(+), 48 deletions(-)
> >
> > --
> > 2.28.0
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1604133727.git.mdejesusfilho%40gmail.com.
> >
next prev parent reply other threads:[~2020-10-31 14:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 9:00 [PATCH 0/3] staging: vt6655: Remove else after return Marcos Antonio de Jesus Filho
2020-10-31 9:00 ` [PATCH 1/3] staging: vt6655: Remove useless else Marcos Antonio de Jesus Filho
2020-10-31 9:01 ` [PATCH 2/3] " Marcos Antonio de Jesus Filho
2020-10-31 9:01 ` [PATCH 3/3] " Marcos Antonio de Jesus Filho
2020-10-31 9:25 ` [Outreachy kernel] " Julia Lawall
2020-10-31 9:28 ` Julia Lawall
2020-10-31 14:48 ` Marcos Antonio de Jesus Filho
2020-10-31 9:37 ` [Outreachy kernel] [PATCH 0/3] staging: vt6655: Remove else after return Julia Lawall
2020-10-31 14:25 ` Marcos Antonio de Jesus Filho [this message]
2020-10-31 15:05 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201031142519.GA1965@Zangetsu \
--to=mdejesusfilho@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.