Re: [Outreachy kernel] [PATCH 3/3] staging: vt6655: Remove useless else

[Marcos Antonio de Jesus Filho <mdejesusfilho@gmail.com>]

On Sat, Oct 31, 2020 at 10:28:18AM +0100, Julia Lawall wrote:
> 
> 
> On Sat, 31 Oct 2020, Marcos Antonio de Jesus Filho wrote:
> 
> > The else statement is not useful due to the presence of a return
> > statement on the if block. Remove the else statement, adjust the
> > indentation of the code and remove useless return statement. Reported by checkpatch.
> >
> > Signed-off-by: Marcos Antonio de Jesus Filho <mdejesusfilho@gmail.com>
> > ---
> >  drivers/staging/vt6655/rxtx.c | 38 +++++++++++++++++------------------
> >  1 file changed, 19 insertions(+), 19 deletions(-)
> >
> > diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> > index 9db4317f9a42..508e1bd7d76e 100644
> > --- a/drivers/staging/vt6655/rxtx.c
> > +++ b/drivers/staging/vt6655/rxtx.c
> > @@ -440,6 +440,8 @@ s_uFillDataHead(
> >  	bool is_pspoll
> >  )
> >  {
> > +	struct vnt_tx_datahead_ab *buf = pTxDataHead;
> > +
> 
> I'm not sure what was the goal of the above addition, but it also looks
> strange to declare the variable buf and then, on immediately the next
> line, not to use it.

The goal of this change is to make the fix and not introduce a build warning,
because I can not mix variable declaration and code, otherwise I would get an
"ISO C90 forbids mixed declarations and code in C" warning.

Marcos