All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	"Ian Rogers" <irogers@google.com>, "Al Grant" <Al.Grant@arm.com>,
	"Mathieu Poirier" <mathieu.poirier@linaro.org>,
	"Kemeng Shi" <shikemeng@huawei.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Wei Li" <liwei391@huawei.com>,
	"John Garry" <john.garry@huawei.com>,
	linux-kernel@vger.kernel.org,
	"Arnaldo Carvalho de Melo" <acme@kernel.org>,
	"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
	"Ingo Molnar" <mingo@redhat.com>,
	"James Clark" <james.clark@arm.com>,
	"André Przywara" <andre.przywara@arm.com>,
	"Namhyung Kim" <namhyung@kernel.org>,
	"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
	"Will Deacon" <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 6/9] perf c2c: Support AUX trace
Date: Sat, 31 Oct 2020 21:21:03 +0100	[thread overview]
Message-ID: <20201031202103.GA3380099@krava> (raw)
In-Reply-To: <20201028063813.8562-7-leo.yan@linaro.org>

On Wed, Oct 28, 2020 at 02:38:10PM +0800, Leo Yan wrote:
> This patches adds the AUX callbacks in session structure, so support
> AUX trace for "perf c2c" tool.
> 
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
>  tools/perf/builtin-c2c.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> index 4d1a08e38233..24f4af997aab 100644
> --- a/tools/perf/builtin-c2c.c
> +++ b/tools/perf/builtin-c2c.c
> @@ -369,6 +369,10 @@ static struct perf_c2c c2c = {
>  		.exit		= perf_event__process_exit,
>  		.fork		= perf_event__process_fork,
>  		.lost		= perf_event__process_lost,
> +		.attr		= perf_event__process_attr,
> +		.auxtrace_info  = perf_event__process_auxtrace_info,
> +		.auxtrace       = perf_event__process_auxtrace,
> +		.auxtrace_error = perf_event__process_auxtrace_error,

so this will process aux data, but don't you have to
say which events you want to synthesize?

like in script/report via --itrace option?

aybe arm differs from x86 in this, and it's happening
in the background.. I have no idea ;-)

jirka

>  		.ordered_events	= true,
>  		.ordering_requires_timestamps = true,
>  	},
> -- 
> 2.17.1
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Jiri Olsa <jolsa@redhat.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: "Arnaldo Carvalho de Melo" <acme@kernel.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
	"Namhyung Kim" <namhyung@kernel.org>,
	"John Garry" <john.garry@huawei.com>,
	"Will Deacon" <will@kernel.org>,
	"Mathieu Poirier" <mathieu.poirier@linaro.org>,
	"Kemeng Shi" <shikemeng@huawei.com>,
	"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
	"Ian Rogers" <irogers@google.com>, "Al Grant" <Al.Grant@arm.com>,
	"James Clark" <james.clark@arm.com>,
	"Wei Li" <liwei391@huawei.com>,
	"André Przywara" <andre.przywara@arm.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 6/9] perf c2c: Support AUX trace
Date: Sat, 31 Oct 2020 21:21:03 +0100	[thread overview]
Message-ID: <20201031202103.GA3380099@krava> (raw)
In-Reply-To: <20201028063813.8562-7-leo.yan@linaro.org>

On Wed, Oct 28, 2020 at 02:38:10PM +0800, Leo Yan wrote:
> This patches adds the AUX callbacks in session structure, so support
> AUX trace for "perf c2c" tool.
> 
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
>  tools/perf/builtin-c2c.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> index 4d1a08e38233..24f4af997aab 100644
> --- a/tools/perf/builtin-c2c.c
> +++ b/tools/perf/builtin-c2c.c
> @@ -369,6 +369,10 @@ static struct perf_c2c c2c = {
>  		.exit		= perf_event__process_exit,
>  		.fork		= perf_event__process_fork,
>  		.lost		= perf_event__process_lost,
> +		.attr		= perf_event__process_attr,
> +		.auxtrace_info  = perf_event__process_auxtrace_info,
> +		.auxtrace       = perf_event__process_auxtrace,
> +		.auxtrace_error = perf_event__process_auxtrace_error,

so this will process aux data, but don't you have to
say which events you want to synthesize?

like in script/report via --itrace option?

aybe arm differs from x86 in this, and it's happening
in the background.. I have no idea ;-)

jirka

>  		.ordered_events	= true,
>  		.ordering_requires_timestamps = true,
>  	},
> -- 
> 2.17.1
> 


  reply	other threads:[~2020-10-31 20:22 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28  6:38 [PATCH v3 0/9] perf mem/c2c: Support AUX trace Leo Yan
2020-10-28  6:38 ` Leo Yan
2020-10-28  6:38 ` [PATCH v3 1/9] perf mem: Search event name with more flexible path Leo Yan
2020-10-28  6:38   ` Leo Yan
2020-10-28  6:38 ` [PATCH v3 2/9] perf mem: Introduce weak function perf_mem_events__ptr() Leo Yan
2020-10-28  6:38   ` Leo Yan
2020-10-28  6:38 ` [PATCH v3 3/9] perf mem: Support new memory event PERF_MEM_EVENTS__LOAD_STORE Leo Yan
2020-10-28  6:38   ` Leo Yan
2020-10-31 20:23   ` Jiri Olsa
2020-10-31 20:23     ` Jiri Olsa
2020-11-02  9:38     ` Leo Yan
2020-11-02  9:38       ` Leo Yan
2020-10-28  6:38 ` [PATCH v3 4/9] perf mem: Only initialize memory event for recording Leo Yan
2020-10-28  6:38   ` Leo Yan
2020-10-30  1:04   ` Ian Rogers
2020-10-30  1:04     ` Ian Rogers
2020-10-28  6:38 ` [PATCH v3 5/9] perf mem: Support AUX trace Leo Yan
2020-10-28  6:38   ` Leo Yan
2020-10-28  6:38 ` [PATCH v3 6/9] perf c2c: " Leo Yan
2020-10-28  6:38   ` Leo Yan
2020-10-31 20:21   ` Jiri Olsa [this message]
2020-10-31 20:21     ` Jiri Olsa
2020-11-02 10:08     ` Leo Yan
2020-11-02 10:08       ` Leo Yan
2020-11-02 16:35       ` Jiri Olsa
2020-11-02 16:35         ` Jiri Olsa
2020-10-28  6:38 ` [PATCH v3 7/9] perf mem: Support Arm SPE events Leo Yan
2020-10-28  6:38   ` Leo Yan
2020-10-28  6:38 ` [PATCH v3 8/9] perf mem: Return NULL for event 'ldst' on PowerPC Leo Yan
2020-10-28  6:38   ` Leo Yan
2020-10-28  9:35   ` Naveen N. Rao
2020-10-28  9:35     ` Naveen N. Rao
2020-10-28  6:38 ` [PATCH v3 9/9] perf mem: Document event type 'ldst' Leo Yan
2020-10-28  6:38   ` Leo Yan
2020-10-30  1:10   ` Ian Rogers
2020-10-30  1:10     ` Ian Rogers
2020-10-30  1:49     ` Leo Yan
2020-10-30  1:49       ` Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201031202103.GA3380099@krava \
    --to=jolsa@redhat.com \
    --cc=Al.Grant@arm.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=andre.przywara@arm.com \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=john.garry@huawei.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liwei391@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=shikemeng@huawei.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.