From: Peilin Ye <yepeilin.cs@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
gregkh@linuxfoundation.org, daniel.vetter@ffwll.ch,
b.zolnierkie@samsung.com, jirislaby@kernel.org,
gustavoars@kernel.org, peda@axentia.se, jingxiangfeng@huawei.com,
natechancellor@gmail.com, george.kennedy@oracle.com,
yepeilin.cs@gmail.com, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] video/fbdev/core: Mark debug-only variable as __maybe_unused
Date: Sun, 1 Nov 2020 05:09:05 -0500 [thread overview]
Message-ID: <20201101100905.GA1504836@PWN> (raw)
In-Reply-To: <20201101094718.GD1166694@ravnborg.org>
Hi Sam,
On Sun, Nov 01, 2020 at 10:47:18AM +0100, Sam Ravnborg wrote:
> Hi Thomas.
>
> On Wed, Oct 21, 2020 at 02:15:12PM +0200, Thomas Zimmermann wrote:
> > Compiling fbcon.c gives
> >
> > ../drivers/video/fbdev/core/fbcon.c: In function 'fbcon_exit':
> > ../drivers/video/fbdev/core/fbcon.c:3358:7: warning: variable 'pending' set but not used [-Wunused-but-set-variable]
> > 3358 | int pending = 0;
> > | ^~~~~~~
> >
> > The variable pending is only used for fbcon debugging. It's unused
> > otherwise. Mark it accordingly.
> >
> > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> A better fix would be to replace the few uses of DPRINTK() with
> pr_dbg(). pr_info() is alread in use.
>
> ofc, the next step would be to replace all prink() with their pr_
> counterparts.
>
> Peilin, maybe this is one for your nice cleanups in fbcon?
Sure, I will send a patch replacing all printk() except DPRINTK(). Thank
you for the suggestion!
Peilin
WARNING: multiple messages have this Message-ID (diff)
From: Peilin Ye <yepeilin.cs@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-fbdev@vger.kernel.org, b.zolnierkie@samsung.com,
gregkh@linuxfoundation.org, gustavoars@kernel.org,
dri-devel@lists.freedesktop.org, jingxiangfeng@huawei.com,
george.kennedy@oracle.com,
Thomas Zimmermann <tzimmermann@suse.de>,
daniel.vetter@ffwll.ch, yepeilin.cs@gmail.com,
natechancellor@gmail.com, jirislaby@kernel.org, peda@axentia.se
Subject: Re: [PATCH] video/fbdev/core: Mark debug-only variable as __maybe_unused
Date: Sun, 1 Nov 2020 05:09:05 -0500 [thread overview]
Message-ID: <20201101100905.GA1504836@PWN> (raw)
In-Reply-To: <20201101094718.GD1166694@ravnborg.org>
Hi Sam,
On Sun, Nov 01, 2020 at 10:47:18AM +0100, Sam Ravnborg wrote:
> Hi Thomas.
>
> On Wed, Oct 21, 2020 at 02:15:12PM +0200, Thomas Zimmermann wrote:
> > Compiling fbcon.c gives
> >
> > ../drivers/video/fbdev/core/fbcon.c: In function 'fbcon_exit':
> > ../drivers/video/fbdev/core/fbcon.c:3358:7: warning: variable 'pending' set but not used [-Wunused-but-set-variable]
> > 3358 | int pending = 0;
> > | ^~~~~~~
> >
> > The variable pending is only used for fbcon debugging. It's unused
> > otherwise. Mark it accordingly.
> >
> > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> A better fix would be to replace the few uses of DPRINTK() with
> pr_dbg(). pr_info() is alread in use.
>
> ofc, the next step would be to replace all prink() with their pr_
> counterparts.
>
> Peilin, maybe this is one for your nice cleanups in fbcon?
Sure, I will send a patch replacing all printk() except DPRINTK(). Thank
you for the suggestion!
Peilin
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-01 10:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 12:15 [PATCH] video/fbdev/core: Mark debug-only variable as __maybe_unused Thomas Zimmermann
2020-10-21 12:15 ` Thomas Zimmermann
2020-11-01 9:47 ` Sam Ravnborg
2020-11-01 9:47 ` Sam Ravnborg
2020-11-01 10:09 ` Peilin Ye [this message]
2020-11-01 10:09 ` Peilin Ye
2020-11-01 14:49 ` [PATCH] fbcon: Replace printk() with pr_*() Peilin Ye
2020-11-01 14:49 ` Peilin Ye
2020-11-01 15:41 ` Greg Kroah-Hartman
2020-11-01 15:41 ` Greg Kroah-Hartman
2020-11-01 16:08 ` Peilin Ye
2020-11-01 16:08 ` Peilin Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201101100905.GA1504836@PWN \
--to=yepeilin.cs@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=george.kennedy@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=jingxiangfeng@huawei.com \
--cc=jirislaby@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=peda@axentia.se \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.