From: Boris Brezillon <boris.brezillon@collabora.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: stable@vger.kernel.org, Steven Price <steven.price@arm.com>,
Rob Herring <robh+dt@kernel.org>,
dri-devel@lists.freedesktop.org,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Subject: Re: [PATCH v2] drm/panfrost: Move the GPU reset bits outside the timeout handler
Date: Mon, 2 Nov 2020 09:45:20 +0100 [thread overview]
Message-ID: <20201102094520.66f62b2a@collabora.com> (raw)
In-Reply-To: <7c840f9f-a6cb-af80-0c21-da5608e00fbb@arm.com>
On Fri, 30 Oct 2020 14:29:32 +0000
Robin Murphy <robin.murphy@arm.com> wrote:
> On 2020-10-30 10:53, Boris Brezillon wrote:
> [...]
> > + /* Schedule a reset if there's no reset in progress. */
> > + if (!atomic_cmpxchg(&pfdev->reset.pending, 0, 1))
>
> Nit: this could just be a simple xchg with 1 - you don't need the
> compare aspect, since setting it to true when it was already true is
> still harmless ;)
Yep, I'll post a new version using atomic_xchg() here.
Thanks,
Boris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Tomeu Vizoso <tomeu@tomeuvizoso.net>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Steven Price <steven.price@arm.com>,
dri-devel@lists.freedesktop.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] drm/panfrost: Move the GPU reset bits outside the timeout handler
Date: Mon, 2 Nov 2020 09:45:20 +0100 [thread overview]
Message-ID: <20201102094520.66f62b2a@collabora.com> (raw)
In-Reply-To: <7c840f9f-a6cb-af80-0c21-da5608e00fbb@arm.com>
On Fri, 30 Oct 2020 14:29:32 +0000
Robin Murphy <robin.murphy@arm.com> wrote:
> On 2020-10-30 10:53, Boris Brezillon wrote:
> [...]
> > + /* Schedule a reset if there's no reset in progress. */
> > + if (!atomic_cmpxchg(&pfdev->reset.pending, 0, 1))
>
> Nit: this could just be a simple xchg with 1 - you don't need the
> compare aspect, since setting it to true when it was already true is
> still harmless ;)
Yep, I'll post a new version using atomic_xchg() here.
Thanks,
Boris
next prev parent reply other threads:[~2020-11-02 8:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 10:53 [PATCH v2] drm/panfrost: Move the GPU reset bits outside the timeout handler Boris Brezillon
2020-10-30 10:53 ` Boris Brezillon
2020-10-30 11:10 ` Steven Price
2020-10-30 11:10 ` Steven Price
2020-10-30 14:29 ` Robin Murphy
2020-10-30 14:29 ` Robin Murphy
2020-11-02 8:45 ` Boris Brezillon [this message]
2020-11-02 8:45 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102094520.66f62b2a@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=stable@vger.kernel.org \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.