All of lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Perret <qperret@google.com>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-doc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
	amitk@kernel.org, corbet@lwn.net, daniel.lezcano@linaro.org,
	Dietmar.Eggemann@arm.com, morten.rasmussen@arm.com,
	dianders@chromium.org, mka@chromium.org, rnayak@codeaurora.org,
	rafael@kernel.org, sudeep.holla@arm.com, viresh.kumar@linaro.org,
	sboyd@kernel.org, nm@ti.com
Subject: Re: [PATCH v3 1/4] PM / EM: Add a flag indicating units of power values in Energy Model
Date: Mon, 2 Nov 2020 13:43:23 +0000	[thread overview]
Message-ID: <20201102134323.GA2221764@google.com> (raw)
In-Reply-To: <20201019140601.3047-2-lukasz.luba@arm.com>

On Monday 19 Oct 2020 at 15:05:58 (+0100), Lukasz Luba wrote:
> diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h
> index b67a51c574b9..2c31d79bb922 100644
> --- a/include/linux/energy_model.h
> +++ b/include/linux/energy_model.h
> @@ -29,6 +29,8 @@ struct em_perf_state {
>   * em_perf_domain - Performance domain
>   * @table:		List of performance states, in ascending order
>   * @nr_perf_states:	Number of performance states
> + * @milliwatts:		Flag indicating the power values are in milli-Watts
> + *			or some other scale.
>   * @cpus:		Cpumask covering the CPUs of the domain. It's here
>   *			for performance reasons to avoid potential cache
>   *			misses during energy calculations in the scheduler
> @@ -43,6 +45,7 @@ struct em_perf_state {
>  struct em_perf_domain {
>  	struct em_perf_state *table;
>  	int nr_perf_states;
> +	bool milliwatts;
>  	unsigned long cpus[];
>  };

Make that an int please, sizeof(bool) is impdef.

With that:

Reviewed-by: Quentin Perret <qperret@google.com>

WARNING: multiple messages have this Message-ID (diff)
From: Quentin Perret <qperret@google.com>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: dianders@chromium.org, devicetree@vger.kernel.org, nm@ti.com,
	amitk@kernel.org, rnayak@codeaurora.org,
	daniel.lezcano@linaro.org, linux-doc@vger.kernel.org,
	sboyd@kernel.org, viresh.kumar@linaro.org, mka@chromium.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	morten.rasmussen@arm.com, robh+dt@kernel.org,
	sudeep.holla@arm.com, rafael@kernel.org, corbet@lwn.net,
	Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/4] PM / EM: Add a flag indicating units of power values in Energy Model
Date: Mon, 2 Nov 2020 13:43:23 +0000	[thread overview]
Message-ID: <20201102134323.GA2221764@google.com> (raw)
In-Reply-To: <20201019140601.3047-2-lukasz.luba@arm.com>

On Monday 19 Oct 2020 at 15:05:58 (+0100), Lukasz Luba wrote:
> diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h
> index b67a51c574b9..2c31d79bb922 100644
> --- a/include/linux/energy_model.h
> +++ b/include/linux/energy_model.h
> @@ -29,6 +29,8 @@ struct em_perf_state {
>   * em_perf_domain - Performance domain
>   * @table:		List of performance states, in ascending order
>   * @nr_perf_states:	Number of performance states
> + * @milliwatts:		Flag indicating the power values are in milli-Watts
> + *			or some other scale.
>   * @cpus:		Cpumask covering the CPUs of the domain. It's here
>   *			for performance reasons to avoid potential cache
>   *			misses during energy calculations in the scheduler
> @@ -43,6 +45,7 @@ struct em_perf_state {
>  struct em_perf_domain {
>  	struct em_perf_state *table;
>  	int nr_perf_states;
> +	bool milliwatts;
>  	unsigned long cpus[];
>  };

Make that an int please, sizeof(bool) is impdef.

With that:

Reviewed-by: Quentin Perret <qperret@google.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-11-02 13:43 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19 14:05 [PATCH v3 0/4] Clarify abstract scale usage for power values in Energy Model, EAS and IPA Lukasz Luba
2020-10-19 14:05 ` Lukasz Luba
2020-10-19 14:05 ` [PATCH v3 1/4] PM / EM: Add a flag indicating units of power values in Energy Model Lukasz Luba
2020-10-19 14:05   ` Lukasz Luba
2020-10-20  0:17   ` Doug Anderson
2020-10-20  0:17     ` Doug Anderson
2020-10-29 12:08     ` Lukasz Luba
2020-10-29 12:08       ` Lukasz Luba
2020-11-02 13:43   ` Quentin Perret [this message]
2020-11-02 13:43     ` Quentin Perret
2020-11-03  8:26     ` Lukasz Luba
2020-11-03  8:26       ` Lukasz Luba
2020-10-19 14:05 ` [PATCH v3 2/4] docs: Clarify abstract scale usage for " Lukasz Luba
2020-10-19 14:05   ` Lukasz Luba
2020-11-02 13:45   ` Quentin Perret
2020-11-02 13:45     ` Quentin Perret
2020-11-03  8:28     ` Lukasz Luba
2020-11-03  8:28       ` Lukasz Luba
2020-10-19 14:06 ` [PATCH v3 3/4] PM / EM: update the comments related to power scale Lukasz Luba
2020-10-19 14:06   ` Lukasz Luba
2020-11-02 13:48   ` Quentin Perret
2020-11-02 13:48     ` Quentin Perret
2020-10-19 14:06 ` [PATCH v3 4/4] docs: power: Update Energy Model with new flag indicating " Lukasz Luba
2020-10-19 14:06   ` Lukasz Luba
2020-11-02 13:51   ` Quentin Perret
2020-11-02 13:51     ` Quentin Perret
2020-10-20  0:15 ` [PATCH v3 0/4] Clarify abstract scale usage for power values in Energy Model, EAS and IPA Doug Anderson
2020-10-20  0:15   ` Doug Anderson
2020-10-29 12:37   ` Lukasz Luba
2020-10-29 12:37     ` Lukasz Luba
2020-10-29 15:39     ` Doug Anderson
2020-10-29 15:39       ` Doug Anderson
2020-10-29 16:15       ` Lukasz Luba
2020-10-29 16:15         ` Lukasz Luba
2020-11-02  8:54 ` Lukasz Luba
2020-11-02  8:54   ` Lukasz Luba
2020-11-02 13:54   ` Quentin Perret
2020-11-02 13:54     ` Quentin Perret
2020-11-03  0:41     ` Doug Anderson
2020-11-03  0:41       ` Doug Anderson
2020-11-03  8:29     ` Lukasz Luba
2020-11-03  8:29       ` Lukasz Luba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201102134323.GA2221764@google.com \
    --to=qperret@google.com \
    --cc=Dietmar.Eggemann@arm.com \
    --cc=amitk@kernel.org \
    --cc=corbet@lwn.net \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=mka@chromium.org \
    --cc=morten.rasmussen@arm.com \
    --cc=nm@ti.com \
    --cc=rafael@kernel.org \
    --cc=rnayak@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.