* Stable backport request for "xen/events: don't use chip_data for legacy IRQs"
@ 2020-10-30 13:29 Ross Lagerwall
2020-10-30 14:17 ` Jürgen Groß
0 siblings, 1 reply; 6+ messages in thread
From: Ross Lagerwall @ 2020-10-30 13:29 UTC (permalink / raw)
To: stable; +Cc: Greg KH, Juergen Gross
Hi,
Please backport [1] to 4.4, 4.9, 4.14, 4.19.
It fixes a commit that has been backported to all the current stable releases but for some reason the fixup was only backported to 5.4 & 5.8.
Debian 9 no longer boots as a Xen HVM guest because it is missing the fixup patch.
Thanks,
Ross
[1]:
commit 0891fb39ba67bd7ae023ea0d367297ffff010781
Author: Juergen Gross <jgross@suse.com>
Date: Wed Sep 30 11:16:14 2020 +0200
xen/events: don't use chip_data for legacy IRQs
Since commit c330fb1ddc0a ("XEN uses irqdesc::irq_data_common::handler_data to store a per interrupt XEN data pointer which contains XEN specific information.")
Xen is using the chip_data pointer for storing IRQ specific data. When
running as a HVM domain this can result in problems for legacy IRQs, as
those might use chip_data for their own purposes.
Use a local array for this purpose in case of legacy IRQs, avoiding the
double use.
Cc: stable@vger.kernel.org
Fixes: c330fb1ddc0a ("XEN uses irqdesc::irq_data_common::handler_data to store a per interrupt XEN data pointer which contains XEN specific information.")
Signed-off-by: Juergen Gross <jgross@suse.com>
Tested-by: Stefan Bader <stefan.bader@canonical.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Link: https://lore.kernel.org/r/20200930091614.13660-1-jgross@suse.com
Signed-off-by: Juergen Gross <jgross@suse.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Stable backport request for "xen/events: don't use chip_data for legacy IRQs"
2020-10-30 13:29 Stable backport request for "xen/events: don't use chip_data for legacy IRQs" Ross Lagerwall
@ 2020-10-30 14:17 ` Jürgen Groß
2020-10-31 10:03 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Jürgen Groß @ 2020-10-30 14:17 UTC (permalink / raw)
To: Ross Lagerwall, stable; +Cc: Greg KH
On 30.10.20 14:29, Ross Lagerwall wrote:
> Hi,
>
> Please backport [1] to 4.4, 4.9, 4.14, 4.19.
>
> It fixes a commit that has been backported to all the current stable releases but for some reason the fixup was only backported to 5.4 & 5.8.
Greg has told me he queued my backport already.
Juergen
>
> Debian 9 no longer boots as a Xen HVM guest because it is missing the fixup patch.
>
> Thanks,
> Ross
>
> [1]:
>
> commit 0891fb39ba67bd7ae023ea0d367297ffff010781
> Author: Juergen Gross <jgross@suse.com>
> Date: Wed Sep 30 11:16:14 2020 +0200
>
> xen/events: don't use chip_data for legacy IRQs
>
> Since commit c330fb1ddc0a ("XEN uses irqdesc::irq_data_common::handler_data to store a per interrupt XEN data pointer which contains XEN specific information.")
> Xen is using the chip_data pointer for storing IRQ specific data. When
> running as a HVM domain this can result in problems for legacy IRQs, as
> those might use chip_data for their own purposes.
>
> Use a local array for this purpose in case of legacy IRQs, avoiding the
> double use.
>
> Cc: stable@vger.kernel.org
> Fixes: c330fb1ddc0a ("XEN uses irqdesc::irq_data_common::handler_data to store a per interrupt XEN data pointer which contains XEN specific information.")
> Signed-off-by: Juergen Gross <jgross@suse.com>
> Tested-by: Stefan Bader <stefan.bader@canonical.com>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Link: https://lore.kernel.org/r/20200930091614.13660-1-jgross@suse.com
> Signed-off-by: Juergen Gross <jgross@suse.com>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Stable backport request for "xen/events: don't use chip_data for legacy IRQs"
2020-10-30 14:17 ` Jürgen Groß
@ 2020-10-31 10:03 ` Greg KH
2020-11-02 13:40 ` Ross Lagerwall
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2020-10-31 10:03 UTC (permalink / raw)
To: Jürgen Groß; +Cc: Ross Lagerwall, stable
On Fri, Oct 30, 2020 at 03:17:09PM +0100, Jürgen Groß wrote:
> On 30.10.20 14:29, Ross Lagerwall wrote:
> > Hi,
> >
> > Please backport [1] to 4.4, 4.9, 4.14, 4.19.
> >
> > It fixes a commit that has been backported to all the current stable releases but for some reason the fixup was only backported to 5.4 & 5.8.
>
> Greg has told me he queued my backport already.
I did? I don't see that commit backported anywhere, did you get
confused with some other patch?
I need a backported version of this patch if we are able to accept it,
as it does not apply cleanly to those kernel releases. Can someone
please provide it and send it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Stable backport request for "xen/events: don't use chip_data for legacy IRQs"
2020-10-31 10:03 ` Greg KH
@ 2020-11-02 13:40 ` Ross Lagerwall
2020-11-02 16:07 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Ross Lagerwall @ 2020-11-02 13:40 UTC (permalink / raw)
To: Greg KH, Jürgen Groß; +Cc: stable
On 2020-10-31 10:03, Greg KH wrote:
> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe.
>
> On Fri, Oct 30, 2020 at 03:17:09PM +0100, Jürgen Groß wrote:
>> On 30.10.20 14:29, Ross Lagerwall wrote:
>>> Hi,
>>>
>>> Please backport [1] to 4.4, 4.9, 4.14, 4.19.
>>>
>>> It fixes a commit that has been backported to all the current stable releases but for some reason the fixup was only backported to 5.4 & 5.8.
>>
>> Greg has told me he queued my backport already.
>
> I did? I don't see that commit backported anywhere, did you get
> confused with some other patch?
>
> I need a backported version of this patch if we are able to accept it,
> as it does not apply cleanly to those kernel releases. Can someone
> please provide it and send it?
>
The clean backport to older releases was sent by Jürgen on Oct 5th (subject [PATCH] xen/events: don't use chip_data for legacy IRQs).
https://lists.linaro.org/pipermail/linux-stable-mirror/2020-October/221081.html
It was queued for 5.4 but not older releases even though it applies cleanly to 4.4..4.19.
Regards,
Ross
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Stable backport request for "xen/events: don't use chip_data for legacy IRQs"
2020-11-02 13:40 ` Ross Lagerwall
@ 2020-11-02 16:07 ` Greg KH
2020-11-02 16:09 ` Jürgen Groß
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2020-11-02 16:07 UTC (permalink / raw)
To: Ross Lagerwall; +Cc: Jürgen Groß, stable
On Mon, Nov 02, 2020 at 01:40:07PM +0000, Ross Lagerwall wrote:
> On 2020-10-31 10:03, Greg KH wrote:
> > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe.
> >
> > On Fri, Oct 30, 2020 at 03:17:09PM +0100, Jürgen Groß wrote:
> >> On 30.10.20 14:29, Ross Lagerwall wrote:
> >>> Hi,
> >>>
> >>> Please backport [1] to 4.4, 4.9, 4.14, 4.19.
> >>>
> >>> It fixes a commit that has been backported to all the current stable releases but for some reason the fixup was only backported to 5.4 & 5.8.
> >>
> >> Greg has told me he queued my backport already.
> >
> > I did? I don't see that commit backported anywhere, did you get
> > confused with some other patch?
> >
> > I need a backported version of this patch if we are able to accept it,
> > as it does not apply cleanly to those kernel releases. Can someone
> > please provide it and send it?
> >
>
> The clean backport to older releases was sent by Jürgen on Oct 5th (subject [PATCH] xen/events: don't use chip_data for legacy IRQs).
>
> https://lists.linaro.org/pipermail/linux-stable-mirror/2020-October/221081.html
>
> It was queued for 5.4 but not older releases even though it applies cleanly to 4.4..4.19.
Can you please resend it, that's long out of my mboxes...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Stable backport request for "xen/events: don't use chip_data for legacy IRQs"
2020-11-02 16:07 ` Greg KH
@ 2020-11-02 16:09 ` Jürgen Groß
0 siblings, 0 replies; 6+ messages in thread
From: Jürgen Groß @ 2020-11-02 16:09 UTC (permalink / raw)
To: Greg KH, Ross Lagerwall; +Cc: stable
On 02.11.20 17:07, Greg KH wrote:
> On Mon, Nov 02, 2020 at 01:40:07PM +0000, Ross Lagerwall wrote:
>> On 2020-10-31 10:03, Greg KH wrote:
>>> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe.
>>>
>>> On Fri, Oct 30, 2020 at 03:17:09PM +0100, Jürgen Groß wrote:
>>>> On 30.10.20 14:29, Ross Lagerwall wrote:
>>>>> Hi,
>>>>>
>>>>> Please backport [1] to 4.4, 4.9, 4.14, 4.19.
>>>>>
>>>>> It fixes a commit that has been backported to all the current stable releases but for some reason the fixup was only backported to 5.4 & 5.8.
>>>>
>>>> Greg has told me he queued my backport already.
>>>
>>> I did? I don't see that commit backported anywhere, did you get
>>> confused with some other patch?
>>>
>>> I need a backported version of this patch if we are able to accept it,
>>> as it does not apply cleanly to those kernel releases. Can someone
>>> please provide it and send it?
>>>
>>
>> The clean backport to older releases was sent by Jürgen on Oct 5th (subject [PATCH] xen/events: don't use chip_data for legacy IRQs).
>>
>> https://lists.linaro.org/pipermail/linux-stable-mirror/2020-October/221081.html
>>
>> It was queued for 5.4 but not older releases even though it applies cleanly to 4.4..4.19.
>
> Can you please resend it, that's long out of my mboxes...
I have included it in the series I've already sent to you for 4.19 and
4.14, and will do so for 4.9 and 4.4, too.
Juergen
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-02 16:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-30 13:29 Stable backport request for "xen/events: don't use chip_data for legacy IRQs" Ross Lagerwall
2020-10-30 14:17 ` Jürgen Groß
2020-10-31 10:03 ` Greg KH
2020-11-02 13:40 ` Ross Lagerwall
2020-11-02 16:07 ` Greg KH
2020-11-02 16:09 ` Jürgen Groß
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.