From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 1/1] f2fs-toos:fsck.f2fs Fix bad return value
Date: Mon, 2 Nov 2020 08:09:50 -0800 [thread overview]
Message-ID: <20201102160950.GB529594@google.com> (raw)
In-Reply-To: <299c9027-e137-83ff-b2ba-8af07144a488@huawei.com>
On 10/28, Chao Yu wrote:
> On 2020/10/26 17:40, Robin Hsu via Linux-f2fs-devel wrote:
> > 'ret' should not have been used here: otherwise, it would be wrongly used
> > as the error code and then be returned from main().
> >
> > Signed-off-by: Robin Hsu <robinhsu@google.com>
>
> BTW, how about changing 'ret = EXIT_ERR_CODE' to
> 'ret = FSCK_ERRORS_LEFT_UNCORRECTED', it's not critical though.
>
> Reviewed-by: Chao Yu <yuchao0@huawei.com>
I think it'd be good to go as is for now. :)
>
> Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: Robin Hsu <robinhsu@google.com>,
linux-f2fs-devel@lists.sourceforge.net, chao@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 1/1] f2fs-toos:fsck.f2fs Fix bad return value
Date: Mon, 2 Nov 2020 08:09:50 -0800 [thread overview]
Message-ID: <20201102160950.GB529594@google.com> (raw)
In-Reply-To: <299c9027-e137-83ff-b2ba-8af07144a488@huawei.com>
On 10/28, Chao Yu wrote:
> On 2020/10/26 17:40, Robin Hsu via Linux-f2fs-devel wrote:
> > 'ret' should not have been used here: otherwise, it would be wrongly used
> > as the error code and then be returned from main().
> >
> > Signed-off-by: Robin Hsu <robinhsu@google.com>
>
> BTW, how about changing 'ret = EXIT_ERR_CODE' to
> 'ret = FSCK_ERRORS_LEFT_UNCORRECTED', it's not critical though.
>
> Reviewed-by: Chao Yu <yuchao0@huawei.com>
I think it'd be good to go as is for now. :)
>
> Thanks,
next prev parent reply other threads:[~2020-11-02 16:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 9:40 [f2fs-dev] [PATCH 1/1] f2fs-toos:fsck.f2fs Fix bad return value Robin Hsu via Linux-f2fs-devel
2020-10-26 9:40 ` Robin Hsu
2020-10-28 6:57 ` [f2fs-dev] " Chao Yu
2020-10-28 6:57 ` Chao Yu
2020-11-02 16:09 ` Jaegeuk Kim [this message]
2020-11-02 16:09 ` Jaegeuk Kim
2020-11-03 2:52 ` Eric Biggers
2020-11-03 2:52 ` Eric Biggers
2020-11-03 3:23 ` Jaegeuk Kim
2020-11-03 3:23 ` Jaegeuk Kim
[not found] ` <CAH7-xNRd1QBJUaxajijjrMbWdKKO1AKS2-1Q5HAAkHSUF628ug@mail.gmail.com>
2020-11-04 18:53 ` Jaegeuk Kim
2020-11-04 18:53 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102160950.GB529594@google.com \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.