From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: alsa-devel@alsa-project.org, kvm@vger.kernel.org,
"Michael S . Tsirkin" <mst@redhat.com>,
"David Airlie" <airlied@linux.ie>,
"Gustavo Padovan" <gustavo@padovan.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
dri-devel@lists.freedesktop.org, linux-mm@kvack.org,
"Christoph Lameter" <cl@linux.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"David Rientjes" <rientjes@google.com>,
virtualization@lists.linux-foundation.org,
"Jason Wang" <jasowang@redhat.com>,
linux-media@vger.kernel.org, "Robert Richter" <rric@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
linaro-mm-sig@lists.linaro.org, linux-gpio@vger.kernel.org,
"Borislav Petkov" <bp@alien8.de>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Joonsoo Kim" <iamjoonsoo.kim@lge.com>,
linux-edac@vger.kernel.org, "Tony Luck" <tony.luck@intel.com>,
netdev@vger.kernel.org, "Takashi Iwai" <tiwai@suse.com>,
linux-kernel@vger.kernel.org, "Pekka Enberg" <penberg@kernel.org>,
"James Morse" <james.morse@arm.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH v2 8/8] dma-buf: use krealloc_array()
Date: Mon, 2 Nov 2020 18:10:16 +0200 [thread overview]
Message-ID: <20201102161016.GN4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201102152037.963-9-brgl@bgdev.pl>
On Mon, Nov 02, 2020 at 04:20:37PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Use the helper that checks for overflows internally instead of manually
> calculating the size of the new array.
...
> + nfences = krealloc_array(fences, i,
> + sizeof(*fences), GFP_KERNEL);
On 80 position is closing parenthesis, which, I think, makes it okay to put on
one line.
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: "Sumit Semwal" <sumit.semwal@linaro.org>,
"Gustavo Padovan" <gustavo@padovan.org>,
"Christian König" <christian.koenig@amd.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Borislav Petkov" <bp@alien8.de>,
"Tony Luck" <tony.luck@intel.com>,
"James Morse" <james.morse@arm.com>,
"Robert Richter" <rric@kernel.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Christoph Lameter" <cl@linux.com>,
"Pekka Enberg" <penberg@kernel.org>,
"David Rientjes" <rientjes@google.com>,
"Joonsoo Kim" <iamjoonsoo.kim@lge.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org,
linux-edac@vger.kernel.org, linux-gpio@vger.kernel.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-mm@kvack.org,
alsa-devel@alsa-project.org,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v2 8/8] dma-buf: use krealloc_array()
Date: Mon, 2 Nov 2020 18:10:16 +0200 [thread overview]
Message-ID: <20201102161016.GN4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201102152037.963-9-brgl@bgdev.pl>
On Mon, Nov 02, 2020 at 04:20:37PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Use the helper that checks for overflows internally instead of manually
> calculating the size of the new array.
...
> + nfences = krealloc_array(fences, i,
> + sizeof(*fences), GFP_KERNEL);
On 80 position is closing parenthesis, which, I think, makes it okay to put on
one line.
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: alsa-devel@alsa-project.org, kvm@vger.kernel.org,
"Michael S . Tsirkin" <mst@redhat.com>,
"David Airlie" <airlied@linux.ie>,
"Gustavo Padovan" <gustavo@padovan.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
dri-devel@lists.freedesktop.org,
"Jaroslav Kysela" <perex@perex.cz>,
linux-mm@kvack.org, "Christoph Lameter" <cl@linux.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"David Rientjes" <rientjes@google.com>,
virtualization@lists.linux-foundation.org,
linux-media@vger.kernel.org, "Robert Richter" <rric@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
linaro-mm-sig@lists.linaro.org, linux-gpio@vger.kernel.org,
"Borislav Petkov" <bp@alien8.de>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Joonsoo Kim" <iamjoonsoo.kim@lge.com>,
linux-edac@vger.kernel.org, "Tony Luck" <tony.luck@intel.com>,
netdev@vger.kernel.org, "Takashi Iwai" <tiwai@suse.com>,
linux-kernel@vger.kernel.org, "Pekka Enberg" <penberg@kernel.org>,
"James Morse" <james.morse@arm.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH v2 8/8] dma-buf: use krealloc_array()
Date: Mon, 2 Nov 2020 18:10:16 +0200 [thread overview]
Message-ID: <20201102161016.GN4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201102152037.963-9-brgl@bgdev.pl>
On Mon, Nov 02, 2020 at 04:20:37PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Use the helper that checks for overflows internally instead of manually
> calculating the size of the new array.
...
> + nfences = krealloc_array(fences, i,
> + sizeof(*fences), GFP_KERNEL);
On 80 position is closing parenthesis, which, I think, makes it okay to put on
one line.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: alsa-devel@alsa-project.org, kvm@vger.kernel.org,
"Michael S . Tsirkin" <mst@redhat.com>,
"David Airlie" <airlied@linux.ie>,
"Gustavo Padovan" <gustavo@padovan.org>,
dri-devel@lists.freedesktop.org,
"Jaroslav Kysela" <perex@perex.cz>,
linux-mm@kvack.org, "Christoph Lameter" <cl@linux.com>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"David Rientjes" <rientjes@google.com>,
virtualization@lists.linux-foundation.org,
"Jason Wang" <jasowang@redhat.com>,
linux-media@vger.kernel.org, "Robert Richter" <rric@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
linaro-mm-sig@lists.linaro.org, linux-gpio@vger.kernel.org,
"Borislav Petkov" <bp@alien8.de>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Joonsoo Kim" <iamjoonsoo.kim@lge.com>,
linux-edac@vger.kernel.org, "Tony Luck" <tony.luck@intel.com>,
netdev@vger.kernel.org, "Takashi Iwai" <tiwai@suse.com>,
linux-kernel@vger.kernel.org, "Pekka Enberg" <penberg@kernel.org>,
"James Morse" <james.morse@arm.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH v2 8/8] dma-buf: use krealloc_array()
Date: Mon, 2 Nov 2020 18:10:16 +0200 [thread overview]
Message-ID: <20201102161016.GN4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201102152037.963-9-brgl@bgdev.pl>
On Mon, Nov 02, 2020 at 04:20:37PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Use the helper that checks for overflows internally instead of manually
> calculating the size of the new array.
...
> + nfences = krealloc_array(fences, i,
> + sizeof(*fences), GFP_KERNEL);
On 80 position is closing parenthesis, which, I think, makes it okay to put on
one line.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-03 7:55 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 15:20 [PATCH v2 0/8] slab: provide and use krealloc_array() Bartosz Golaszewski
2020-11-02 15:20 ` Bartosz Golaszewski
2020-11-02 15:20 ` Bartosz Golaszewski
2020-11-02 15:20 ` [PATCH v2 1/8] mm: slab: provide krealloc_array() Bartosz Golaszewski
2020-11-02 15:20 ` Bartosz Golaszewski
2020-11-02 15:20 ` Bartosz Golaszewski
2020-11-02 15:41 ` Matthew Wilcox
2020-11-02 15:41 ` Matthew Wilcox
2020-11-02 15:41 ` Matthew Wilcox
2020-11-02 15:41 ` Matthew Wilcox
2020-11-02 15:43 ` Bartosz Golaszewski
2020-11-02 15:43 ` Bartosz Golaszewski
2020-11-02 15:43 ` Bartosz Golaszewski
2020-11-02 15:20 ` [PATCH v2 2/8] ALSA: pcm: use krealloc_array() Bartosz Golaszewski
2020-11-02 15:20 ` Bartosz Golaszewski
2020-11-02 15:20 ` Bartosz Golaszewski
2020-11-02 15:20 ` [PATCH v2 3/8] vhost: vringh: " Bartosz Golaszewski
2020-11-02 15:20 ` Bartosz Golaszewski
2020-11-02 15:20 ` Bartosz Golaszewski
2020-11-02 15:20 ` [PATCH v2 4/8] pinctrl: " Bartosz Golaszewski
2020-11-02 15:20 ` Bartosz Golaszewski
2020-11-02 15:20 ` Bartosz Golaszewski
2020-11-02 15:20 ` [PATCH v2 5/8] edac: ghes: " Bartosz Golaszewski
2020-11-02 15:20 ` Bartosz Golaszewski
2020-11-02 15:20 ` Bartosz Golaszewski
2020-11-02 15:20 ` [PATCH v2 6/8] drm: atomic: " Bartosz Golaszewski
2020-11-02 15:20 ` Bartosz Golaszewski
2020-11-02 15:20 ` Bartosz Golaszewski
2020-11-02 15:20 ` [PATCH v2 7/8] hwtracing: intel: " Bartosz Golaszewski
2020-11-02 15:20 ` Bartosz Golaszewski
2020-11-02 15:20 ` Bartosz Golaszewski
2020-11-02 15:20 ` [PATCH v2 8/8] dma-buf: " Bartosz Golaszewski
2020-11-02 15:20 ` Bartosz Golaszewski
2020-11-02 15:20 ` Bartosz Golaszewski
2020-11-02 16:10 ` Andy Shevchenko [this message]
2020-11-02 16:10 ` Andy Shevchenko
2020-11-02 16:10 ` Andy Shevchenko
2020-11-02 16:10 ` Andy Shevchenko
2020-11-03 4:14 ` [PATCH v2 0/8] slab: provide and " Joe Perches
2020-11-03 4:14 ` Joe Perches
2020-11-03 4:14 ` Joe Perches
2020-11-03 4:14 ` Joe Perches
2020-11-03 10:12 ` Bartosz Golaszewski
2020-11-03 10:12 ` Bartosz Golaszewski
2020-11-03 10:12 ` Bartosz Golaszewski
2020-11-03 10:55 ` Andy Shevchenko
2020-11-03 10:55 ` Andy Shevchenko
2020-11-03 10:55 ` Andy Shevchenko
2020-11-03 10:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102161016.GN4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bgolaszewski@baylibre.com \
--cc=bp@alien8.de \
--cc=brgl@bgdev.pl \
--cc=christian.koenig@amd.com \
--cc=cl@linux.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=james.morse@arm.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=rric@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=tiwai@suse.com \
--cc=tony.luck@intel.com \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.