Re: [PATCH v7 2/3] pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO

From: kernel test robot <lkp@intel.com>
To: Lars Povlsen <lars.povlsen@microchip.com>,
	Linus Walleij <linus.walleij@linaro.org>
Cc: kbuild-all@lists.01.org,
	Lars Povlsen <lars.povlsen@microchip.com>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v7 2/3] pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO
Date: Mon, 2 Nov 2020 16:53:28 +0800	[thread overview]
Message-ID: <202011021622.gr2ASMHv-lkp@intel.com> (raw)
In-Reply-To: <20201029134027.232951-3-lars.povlsen@microchip.com>

[-- Attachment #1: Type: text/plain, Size: 2004 bytes --]

Hi Lars,

I love your patch! Perhaps something to improve:

[auto build test WARNING on pinctrl/devel]
[also build test WARNING on robh/for-next linus/master v5.10-rc2 next-20201030]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Lars-Povlsen/Adding-support-for-Microchip-Microsemi-serial-GPIO-controller/20201029-214152
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: i386-randconfig-s001-20201101 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-76-gf680124b-dirty
        # https://github.com/0day-ci/linux/commit/af1b5649bb4d40aa5e17bfba52ead8586936648e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Lars-Povlsen/Adding-support-for-Microchip-Microsemi-serial-GPIO-controller/20201029-214152
        git checkout af1b5649bb4d40aa5e17bfba52ead8586936648e
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

"sparse warnings: (new ones prefixed by >>)"
>> drivers/pinctrl/pinctrl-microchip-sgpio.c:61:31: sparse: sparse: symbol 'properties_luton' was not declared. Should it be static?
>> drivers/pinctrl/pinctrl-microchip-sgpio.c:69:31: sparse: sparse: symbol 'properties_ocelot' was not declared. Should it be static?
>> drivers/pinctrl/pinctrl-microchip-sgpio.c:77:31: sparse: sparse: symbol 'properties_sparx5' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33951 bytes --]