From: Paul Kocialkowski <contact@paulk.fr>
To: Maxime Ripard <maxime@cerno.tech>
Cc: devicetree@vger.kernel.org,
Matteo Scordino <matteo.scordino@gmail.com>,
linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Icenowy Zheng <icenowy@aosc.io>
Subject: Re: [PATCH 8/9] dt-bindings: arm: sunxi: Add SL631 with IMX179 bindings
Date: Mon, 2 Nov 2020 18:00:13 +0100 [thread overview]
Message-ID: <20201102170013.GC2037@collins> (raw)
In-Reply-To: <20201102142744.lxjvu67pr7dmxzo7@gilmour.lan>
[-- Attachment #1.1: Type: text/plain, Size: 2021 bytes --]
On Mon 02 Nov 20, 15:27, Maxime Ripard wrote:
> On Mon, Nov 02, 2020 at 11:33:40AM +0100, Paul Kocialkowski wrote:
> > Hi,
> >
> > On Mon 02 Nov 20, 11:13, Maxime Ripard wrote:
> > > On Sat, Oct 31, 2020 at 07:21:36PM +0100, Paul Kocialkowski wrote:
> > > > Document the compatible strings for the SL631 Action Camera with IMX179.
> > > >
> > > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > > > ---
> > > > Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++
> > > > 1 file changed, 6 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > > index afa00268c7db..0fa0c0b5d89f 100644
> > > > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > > @@ -754,6 +754,12 @@ properties:
> > > > - const: sinlinx,sina33
> > > > - const: allwinner,sun8i-a33
> > > >
> > > > + - description: SL631 Action Camera with IMX179
> > > > + items:
> > > > + - const: unknown,sl631-imx179
> > > > + - const: unknown,sl631
> > > > + - const: allwinner,sun8i-v3
> > > > +
> > >
> > > unknown is not a valid vendor (and you should explain why you picked
> > > that vendor name in the first place).
> >
> > Ah right, it's not in the vendor prefixes. The rationale is that there is no
> > indication of what the vendor might be on the PCB. Should I maybe use
> > allwinner here?
>
> You should mention it in the commit log for a start :)
Definitely.
> But yeah, we've used allwinner as a fallback for those cases so far.
Okay then, I'll go with that and add some explanation in the commit log.
Thanks for the review!
Cheers,
Paul
--
Developer of free digital technology and hardware support.
Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Paul Kocialkowski <contact@paulk.fr>
To: Maxime Ripard <maxime@cerno.tech>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Chen-Yu Tsai <wens@csie.org>,
Matteo Scordino <matteo.scordino@gmail.com>,
Icenowy Zheng <icenowy@aosc.io>
Subject: Re: [PATCH 8/9] dt-bindings: arm: sunxi: Add SL631 with IMX179 bindings
Date: Mon, 2 Nov 2020 18:00:13 +0100 [thread overview]
Message-ID: <20201102170013.GC2037@collins> (raw)
In-Reply-To: <20201102142744.lxjvu67pr7dmxzo7@gilmour.lan>
[-- Attachment #1: Type: text/plain, Size: 2021 bytes --]
On Mon 02 Nov 20, 15:27, Maxime Ripard wrote:
> On Mon, Nov 02, 2020 at 11:33:40AM +0100, Paul Kocialkowski wrote:
> > Hi,
> >
> > On Mon 02 Nov 20, 11:13, Maxime Ripard wrote:
> > > On Sat, Oct 31, 2020 at 07:21:36PM +0100, Paul Kocialkowski wrote:
> > > > Document the compatible strings for the SL631 Action Camera with IMX179.
> > > >
> > > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > > > ---
> > > > Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++
> > > > 1 file changed, 6 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > > index afa00268c7db..0fa0c0b5d89f 100644
> > > > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > > @@ -754,6 +754,12 @@ properties:
> > > > - const: sinlinx,sina33
> > > > - const: allwinner,sun8i-a33
> > > >
> > > > + - description: SL631 Action Camera with IMX179
> > > > + items:
> > > > + - const: unknown,sl631-imx179
> > > > + - const: unknown,sl631
> > > > + - const: allwinner,sun8i-v3
> > > > +
> > >
> > > unknown is not a valid vendor (and you should explain why you picked
> > > that vendor name in the first place).
> >
> > Ah right, it's not in the vendor prefixes. The rationale is that there is no
> > indication of what the vendor might be on the PCB. Should I maybe use
> > allwinner here?
>
> You should mention it in the commit log for a start :)
Definitely.
> But yeah, we've used allwinner as a fallback for those cases so far.
Okay then, I'll go with that and add some explanation in the commit log.
Thanks for the review!
Cheers,
Paul
--
Developer of free digital technology and hardware support.
Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-11-02 17:00 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 18:21 [PATCH 0/9] Allwinner V3 SL631 Action Camera Support and Related Fixes Paul Kocialkowski
2020-10-31 18:21 ` Paul Kocialkowski
2020-10-31 18:21 ` [PATCH 1/9] ARM: sunxi: Add machine match for the Allwinner V3 SoC Paul Kocialkowski
2020-10-31 18:21 ` Paul Kocialkowski
2020-11-02 9:28 ` Maxime Ripard
2020-11-02 9:28 ` Maxime Ripard
2020-10-31 18:21 ` [PATCH 2/9] ARM: dts: sun8i-v3: Add UART1 PG pins description Paul Kocialkowski
2020-10-31 18:21 ` Paul Kocialkowski
2020-10-31 18:21 ` [PATCH 3/9] ARM: dts: sun8i-v3s: Add I2C1 PB " Paul Kocialkowski
2020-10-31 18:21 ` Paul Kocialkowski
2020-11-02 10:08 ` Maxime Ripard
2020-11-02 10:08 ` Maxime Ripard
2020-10-31 18:21 ` [PATCH 4/9] dt-bindings: irq: sun7i-nmi: Add binding for the V3s NMI Paul Kocialkowski
2020-10-31 18:21 ` Paul Kocialkowski
2020-11-02 10:09 ` Maxime Ripard
2020-11-02 10:09 ` Maxime Ripard
2020-11-02 10:16 ` Paul Kocialkowski
2020-11-02 10:16 ` Paul Kocialkowski
2020-10-31 18:21 ` [PATCH 5/9] irqchip/sunxi-nmi: Add support " Paul Kocialkowski
2020-10-31 18:21 ` Paul Kocialkowski
2020-11-02 10:09 ` Maxime Ripard
2020-11-02 10:09 ` Maxime Ripard
2020-10-31 18:21 ` [PATCH 6/9] ARM: dts: sun8i-v3s: Add the V3s NMI IRQ controller Paul Kocialkowski
2020-10-31 18:21 ` Paul Kocialkowski
2020-11-02 10:12 ` Maxime Ripard
2020-11-02 10:12 ` Maxime Ripard
2020-11-02 10:25 ` Paul Kocialkowski
2020-11-02 10:25 ` Paul Kocialkowski
2020-11-02 13:44 ` Maxime Ripard
2020-11-02 13:44 ` Maxime Ripard
2020-11-02 16:59 ` Paul Kocialkowski
2020-11-02 16:59 ` Paul Kocialkowski
2020-10-31 18:21 ` [PATCH 7/9] ARM: dts: sun8i: Cleanup the Pinecube AXP209 node Paul Kocialkowski
2020-10-31 18:21 ` Paul Kocialkowski
2020-10-31 18:21 ` [PATCH 8/9] dt-bindings: arm: sunxi: Add SL631 with IMX179 bindings Paul Kocialkowski
2020-10-31 18:21 ` Paul Kocialkowski
2020-11-02 10:13 ` Maxime Ripard
2020-11-02 10:13 ` Maxime Ripard
2020-11-02 10:33 ` Paul Kocialkowski
2020-11-02 10:33 ` Paul Kocialkowski
2020-11-02 14:27 ` Maxime Ripard
2020-11-02 14:27 ` Maxime Ripard
2020-11-02 17:00 ` Paul Kocialkowski [this message]
2020-11-02 17:00 ` Paul Kocialkowski
2020-10-31 18:21 ` [PATCH 9/9] ARM: dts: sun8i-v3: Add support for the SL631 Action Camera with IMX179 Paul Kocialkowski
2020-10-31 18:21 ` Paul Kocialkowski
2020-11-02 10:16 ` Maxime Ripard
2020-11-02 10:16 ` Maxime Ripard
2020-11-02 10:30 ` Paul Kocialkowski
2020-11-02 10:30 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102170013.GC2037@collins \
--to=contact@paulk.fr \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matteo.scordino@gmail.com \
--cc=maxime@cerno.tech \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.