Re: [master/dunfell PATCH] packagegroup-arago-tisdk-addons-sdk-target: Add ti-rpmsg-char dev packages

[Denys Dmytriyenko <denys@ti.com>]

On Mon, Nov 02, 2020 at 04:53:56PM -0600, Suman Anna wrote:
> Hi Dan,
> 
> On 11/2/20 4:18 PM, Dan Murphy wrote:
> > Suman
> > 
> > On 10/27/20 2:11 PM, Denys Dmytriyenko wrote:
> >> On Tue, Oct 27, 2020 at 09:37:18AM -0500, Suman Anna wrote:
> >>> Hi Denys,
> >>>
> >>> On 10/26/20 11:08 PM, Denys Dmytriyenko wrote:
> >>>> On Mon, Oct 26, 2020 at 09:48:26PM -0500, Suman Anna wrote:
> >>>>> On 10/26/20 9:45 PM, Denys Dmytriyenko wrote:
> >>>>>> On Mon, Oct 26, 2020 at 09:41:12PM -0500, Suman Anna wrote:
> >>>>>>> Add the ti-rpmsg-char dev packages to make the public headers available in
> >>>>>>> the target fileystem so that applications can be compiled natively on the
> >>>>>>> target.
> >>>>>> -sdk-target is not for the target filesystem!
> >>>>>> It is for the target sysroot in the devkit.
> >>>>> Hmm, is this supposed to go into a different file or my patch description
> >>>>> needs
> >>>>> correcting?
> >>>> It depends on what you actually need.
> >>> I want the files from the  ti-rpmsg-char-dev package (the public header files
> >>> and libti_rpmsg_char.so) to be part of the FS tarball.
> >> Then you need to pull corresponding -dev package into the packagegroup that
> >> builds up the rootfs.
> >>
> >> At least in Arago, I kept the namespace convention that -sdk-target and
> >> -sdk-host suffixes are used to identify packagegroups for the devkit -
> >> cross-compile development environment on the host, target and host sysroots.
> >>
> >>> regards
> >>> Suman
> >>>
> >>>>
> >>>>>>> Signed-off-by: Suman Anna <s-anna@ti.com>
> >>>>>>> ---
> >>>>>>>   .../packagegroup-arago-tisdk-addons-sdk-target.bb         | 8 ++++++--
> >>>>>>>   1 file changed, 6 insertions(+), 2 deletions(-)
> >>>>>>>
> >>>>>>> diff --git
> >>>>>>> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons-sdk-target.bb
> >>>>>>> b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons-sdk-target.bb
> >>>>>>>
> >>>>>>> index e372dd67744e..b55c79a4d4df 100644
> >>>>>>> ---
> >>>>>>> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons-sdk-target.bb
> >>>>>>>
> >>>>>>> +++
> >>>>>>> b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons-sdk-target.bb
> >>>>>>>
> >>>>>>> @@ -1,6 +1,6 @@
> >>>>>>>   DESCRIPTION = "Task to install headers and libraries related to addons
> >>>>>>> into the SDK"
> >>>>>>>   LICENSE = "MIT"
> >>>>>>> -PR = "r43"
> >>>>>>> +PR = "r44"
> >>>>>>>     PACKAGE_ARCH = "${MACHINE_ARCH}"
> >>>>>>>   @@ -143,7 +143,11 @@ UTILS_append_dra7xx = " can-utils-dev \
> >>>>>>>                           elfutils-staticdev \
> >>>>>>>   "
> >>>>>>>   UTILS_append_k2g = " can-utils-dev"
> >>>>>>> -UTILS_append_k3 = " can-utils-dev"
> >>>>>>> +UTILS_append_k3 = "\
> >>>>>>> +    can-utils-dev \
> >>>>>>> +    ti-rpmsg-char-dev \
> >>>>>>> +    ti-rpmsg-char-staticdev \
> >>>>>>> +"
> >>>>>>>     EXTRA_LIBS = ""
> >>>>>>>   EXTRA_LIBS_append_ti43x = "\
> >>>>>>> -- 
> >>>>>>> 2.28.0
> >>>>>>>
> > 
> > Does this need to go in or are you going to send in v2?
> 
> I am confused by the terminology above, I am not sure if I need to move this to
> the packagegroup-arago-tisdk-addons.bb file, or if this is just a question of
> writing the proper patch description. I cannot verify myself until I fix my OE
> build issues.

Suman,

If you do need these development packages on the target rootfs, then you do 
need to add them to packagegroup-arago-tisdk-addons.bb

But if you need them to be part of the devkit (cross-compile development 
environment on the host), then you need to add to the corresponding 
packagegroup-arago-tisdk-addons-sdk-target.bb

In other words, do you expect someone to compile natively on the target 
against your library and headers? Then it's the first one. But, enabling 
native development environment on the target should not be decided lightly. 
As a matter of fact, for 7.0 we removed this from the default rootfs, 
expecting users to be able to add it optionally from package feeds. Though 
public package feeds were not ready and got postponed...

So, my point is - what are you trying to achieve here? Why do you need -dev 
package on the target filesystem? If you are trying to enable other developers 
to build apps against your library, could they just write a recipe? Is it 
really necessary for the default rootfs? Anyway, hopefully these questions 
could guide you towards the proper solution. Please let me know if you still 
have questions :)

-- 
Denys