All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: Xinhao Zhang <zhangxinhao1@huawei.com>
Cc: <qemu-devel@nongnu.org>,
	xiaoguangrong.eric@gmail.com, mst@redhat.com,
	qemu-trivial@nongnu.org, alex.chen@huawei.com,
	dengkai1@huawei.com
Subject: Re: [PATCH 2/3] hw/acpi : add space before the open parenthesis '('
Date: Tue, 3 Nov 2020 13:28:25 +0100	[thread overview]
Message-ID: <20201103132825.34c7f588@redhat.com> (raw)
In-Reply-To: <20201103102634.273021-2-zhangxinhao1@huawei.com>

On Tue, 3 Nov 2020 18:26:33 +0800
Xinhao Zhang <zhangxinhao1@huawei.com> wrote:

> Fix code style. Space required before the open parenthesis '('.
> 
> Signed-off-by: Xinhao Zhang <zhangxinhao1@huawei.com>
> Signed-off-by: Kai Deng <dengkai1@huawei.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  hw/acpi/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/acpi/core.c b/hw/acpi/core.c
> index ade9158cbf..2c0c83221f 100644
> --- a/hw/acpi/core.c
> +++ b/hw/acpi/core.c
> @@ -558,7 +558,7 @@ static void acpi_pm1_cnt_write(ACPIREGS *ar, uint16_t val)
>      if (val & ACPI_BITMASK_SLEEP_ENABLE) {
>          /* change suspend type */
>          uint16_t sus_typ = (val >> 10) & 7;
> -        switch(sus_typ) {
> +        switch (sus_typ) {
>          case 0: /* soft power off */
>              qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);
>              break;



WARNING: multiple messages have this Message-ID (diff)
From: Igor Mammedov <imammedo@redhat.com>
To: Xinhao Zhang <zhangxinhao1@huawei.com>
Cc: xiaoguangrong.eric@gmail.com, mst@redhat.com,
	qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
	alex.chen@huawei.com, dengkai1@huawei.com
Subject: Re: [PATCH 2/3] hw/acpi : add space before the open parenthesis '('
Date: Tue, 3 Nov 2020 13:28:25 +0100	[thread overview]
Message-ID: <20201103132825.34c7f588@redhat.com> (raw)
In-Reply-To: <20201103102634.273021-2-zhangxinhao1@huawei.com>

On Tue, 3 Nov 2020 18:26:33 +0800
Xinhao Zhang <zhangxinhao1@huawei.com> wrote:

> Fix code style. Space required before the open parenthesis '('.
> 
> Signed-off-by: Xinhao Zhang <zhangxinhao1@huawei.com>
> Signed-off-by: Kai Deng <dengkai1@huawei.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  hw/acpi/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/acpi/core.c b/hw/acpi/core.c
> index ade9158cbf..2c0c83221f 100644
> --- a/hw/acpi/core.c
> +++ b/hw/acpi/core.c
> @@ -558,7 +558,7 @@ static void acpi_pm1_cnt_write(ACPIREGS *ar, uint16_t val)
>      if (val & ACPI_BITMASK_SLEEP_ENABLE) {
>          /* change suspend type */
>          uint16_t sus_typ = (val >> 10) & 7;
> -        switch(sus_typ) {
> +        switch (sus_typ) {
>          case 0: /* soft power off */
>              qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);
>              break;



  reply	other threads:[~2020-11-03 12:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03 10:26 [PATCH 1/3] hw/acpi : Don't use '#' flag of printf format Xinhao Zhang
2020-11-03 10:26 ` Xinhao Zhang
2020-11-03 10:26 ` [PATCH 2/3] hw/acpi : add space before the open parenthesis '(' Xinhao Zhang
2020-11-03 10:26   ` Xinhao Zhang
2020-11-03 12:28   ` Igor Mammedov [this message]
2020-11-03 12:28     ` Igor Mammedov
2020-11-03 10:26 ` [PATCH 3/3] hw/acpi : add spaces around operator Xinhao Zhang
2020-11-03 10:26   ` Xinhao Zhang
2020-11-03 12:28   ` Igor Mammedov
2020-11-03 12:28     ` Igor Mammedov
2020-11-03 12:27 ` [PATCH 1/3] hw/acpi : Don't use '#' flag of printf format Igor Mammedov
2020-11-03 12:27   ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201103132825.34c7f588@redhat.com \
    --to=imammedo@redhat.com \
    --cc=alex.chen@huawei.com \
    --cc=dengkai1@huawei.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=xiaoguangrong.eric@gmail.com \
    --cc=zhangxinhao1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.