* [linux-next:master 2873/3099] drivers/clk/imx/clk-gate2.c:45:5-8: Unneeded variable: "ret". Return "0" on line 60
@ 2020-11-03 15:52 kernel test robot
2020-11-03 15:52 ` [PATCH] clk: imx: gate2: fix returnvar.cocci warnings kernel test robot
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2020-11-03 15:52 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1117 bytes --]
CC: kbuild-all(a)lists.01.org
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Abel Vesa <abel.vesa@nxp.com>
CC: Shawn Guo <shawnguo@kernel.org>
CC: Sascha Hauer <s.hauer@pengutronix.de>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: c50585161e791d5ddb924da98741fdf413a0480a
commit: 12309428c27737c21735fb28540c6c6f69f632f6 [2873/3099] clk: imx: gate2: Remove the IMX_CLK_GATE2_SINGLE_BIT special case
:::::: branch date: 9 hours ago
:::::: commit date: 16 hours ago
config: powerpc-randconfig-c004-20201103 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
"coccinelle warnings: (new ones prefixed by >>)"
>> drivers/clk/imx/clk-gate2.c:45:5-8: Unneeded variable: "ret". Return "0" on line 60
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 44292 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] clk: imx: gate2: fix returnvar.cocci warnings
2020-11-03 15:52 [linux-next:master 2873/3099] drivers/clk/imx/clk-gate2.c:45:5-8: Unneeded variable: "ret". Return "0" on line 60 kernel test robot
@ 2020-11-03 15:52 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-11-03 15:52 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1890 bytes --]
CC: kbuild-all(a)lists.01.org
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Abel Vesa <abel.vesa@nxp.com>
CC: Shawn Guo <shawnguo@kernel.org>
CC: Sascha Hauer <s.hauer@pengutronix.de>
CC: Michael Turquette <mturquette@baylibre.com>
CC: Stephen Boyd <sboyd@kernel.org>
CC: Pengutronix Kernel Team <kernel@pengutronix.de>
CC: Fabio Estevam <festevam@gmail.com>
CC: NXP Linux Team <linux-imx@nxp.com>
CC: Anson Huang <Anson.Huang@nxp.com>
CC: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
From: kernel test robot <lkp@intel.com>
drivers/clk/imx/clk-gate2.c:45:5-8: Unneeded variable: "ret". Return "0" on line 60
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Fixes: 12309428c277 ("clk: imx: gate2: Remove the IMX_CLK_GATE2_SINGLE_BIT special case")
CC: Abel Vesa <abel.vesa@nxp.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: c50585161e791d5ddb924da98741fdf413a0480a
commit: 12309428c27737c21735fb28540c6c6f69f632f6 [2873/3099] clk: imx: gate2: Remove the IMX_CLK_GATE2_SINGLE_BIT special case
:::::: branch date: 9 hours ago
:::::: commit date: 16 hours ago
Please take the patch only if it's a positive warning. Thanks!
clk-gate2.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/clk/imx/clk-gate2.c
+++ b/drivers/clk/imx/clk-gate2.c
@@ -42,7 +42,6 @@ static int clk_gate2_enable(struct clk_h
struct clk_gate2 *gate = to_clk_gate2(hw);
u32 reg;
unsigned long flags;
- int ret = 0;
spin_lock_irqsave(gate->lock, flags);
@@ -57,7 +56,7 @@ static int clk_gate2_enable(struct clk_h
out:
spin_unlock_irqrestore(gate->lock, flags);
- return ret;
+ return 0;
}
static void clk_gate2_disable(struct clk_hw *hw)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-03 15:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-03 15:52 [linux-next:master 2873/3099] drivers/clk/imx/clk-gate2.c:45:5-8: Unneeded variable: "ret". Return "0" on line 60 kernel test robot
2020-11-03 15:52 ` [PATCH] clk: imx: gate2: fix returnvar.cocci warnings kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.