* Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config
2020-11-03 17:01 ` Philippe Mathieu-Daudé
@ 2020-11-03 17:02 ` Daniel P. Berrangé
2020-11-03 17:04 ` Philippe Mathieu-Daudé
2020-11-03 20:57 ` Paolo Bonzini
2 siblings, 0 replies; 34+ messages in thread
From: Daniel P. Berrangé @ 2020-11-03 17:02 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Fam Zheng, Thomas Huth, Matthew Rosato, David Hildenbrand,
Cornelia Huck, qemu-devel, Wainer dos Santos Moschetta,
Halil Pasic, Christian Borntraeger, qemu-s390x, Paolo Bonzini,
Alex Bennée, Richard Henderson
On Tue, Nov 03, 2020 at 06:01:12PM +0100, Philippe Mathieu-Daudé wrote:
> On 11/3/20 5:52 PM, Daniel P. Berrangé wrote:
> > On Tue, Nov 03, 2020 at 05:46:03PM +0100, Philippe Mathieu-Daudé wrote:
> >> We test './configure --without-default-devices' since commit
> >> 20885b5b169 (".travis.yml: test that no-default-device builds
> >> do not regress") in Travis-CI.
> >>
> >> As we prefer to use GitLab-CI, add the equivalent job there.
> >>
> >> One minor difference: the GitLab Ubuntu docker image has the
> >> Xen devel packages installed. As it is automatically selected,
> >> we need to disable it with the --disable-xen option, else the
> >> build fails:
> >>
> >> /usr/bin/ld: libcommon.fa.p/hw_xen_xen-legacy-backend.c.o: in function `xen_be_register_common':
> >> hw/xen/xen-legacy-backend.c:754: undefined reference to `xen_9pfs_ops'
> >> /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x8): undefined reference to `local_ops'
> >> /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x20): undefined reference to `synth_ops'
> >> /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x38): undefined reference to `proxy_ops'
> >> collect2: error: ld returned 1 exit status
> >
> > Surely this is a build bug we need to fix rather than ignore in CI ?
>
> Well it predates this series, so nobody really cared
> (thus I wonder if it makes sense to invest resources
> there).
>
> Anyway I can have a look after 5.2-rc1.
Can you just put a comment in the .gitlab-ci.yml file stating
that the --disable-xen arg is a short term workaround that needs
to be fixed properly
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config
2020-11-03 17:01 ` Philippe Mathieu-Daudé
@ 2020-11-03 17:04 ` Philippe Mathieu-Daudé
2020-11-03 17:04 ` Philippe Mathieu-Daudé
2020-11-03 20:57 ` Paolo Bonzini
2 siblings, 0 replies; 34+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-11-03 17:04 UTC (permalink / raw)
To: Daniel P. Berrangé, Stefano Stabellini, Anthony Perard,
Paul Durrant, xen-devel@lists.xenproject.org, Greg Kurz,
Christian Schoenebeck
Cc: qemu-devel, Paolo Bonzini, Cornelia Huck, Alex Bennée,
David Hildenbrand, qemu-s390x, Fam Zheng, Richard Henderson,
Matthew Rosato, Halil Pasic, Thomas Huth,
Wainer dos Santos Moschetta, Christian Borntraeger
I forgot to Cc the 9pfs & Xen maintainers, doing it now ;)
On 11/3/20 6:01 PM, Philippe Mathieu-Daudé wrote:
> On 11/3/20 5:52 PM, Daniel P. Berrangé wrote:
>> On Tue, Nov 03, 2020 at 05:46:03PM +0100, Philippe Mathieu-Daudé wrote:
>>> We test './configure --without-default-devices' since commit
>>> 20885b5b169 (".travis.yml: test that no-default-device builds
>>> do not regress") in Travis-CI.
>>>
>>> As we prefer to use GitLab-CI, add the equivalent job there.
>>>
>>> One minor difference: the GitLab Ubuntu docker image has the
>>> Xen devel packages installed. As it is automatically selected,
>>> we need to disable it with the --disable-xen option, else the
>>> build fails:
>>>
>>> /usr/bin/ld: libcommon.fa.p/hw_xen_xen-legacy-backend.c.o: in function `xen_be_register_common':
>>> hw/xen/xen-legacy-backend.c:754: undefined reference to `xen_9pfs_ops'
>>> /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x8): undefined reference to `local_ops'
>>> /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x20): undefined reference to `synth_ops'
>>> /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x38): undefined reference to `proxy_ops'
>>> collect2: error: ld returned 1 exit status
>>
>> Surely this is a build bug we need to fix rather than ignore in CI ?
>
> Well it predates this series, so nobody really cared
> (thus I wonder if it makes sense to invest resources
> there).
>
> Anyway I can have a look after 5.2-rc1.
>
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config
@ 2020-11-03 17:04 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 34+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-11-03 17:04 UTC (permalink / raw)
To: Daniel P. Berrangé, Stefano Stabellini, Anthony Perard,
Paul Durrant, xen-devel@lists.xenproject.org, Greg Kurz,
Christian Schoenebeck
Cc: Fam Zheng, Thomas Huth, Matthew Rosato, David Hildenbrand,
Cornelia Huck, qemu-devel, Wainer dos Santos Moschetta,
Halil Pasic, Christian Borntraeger, qemu-s390x, Paolo Bonzini,
Alex Bennée, Richard Henderson
I forgot to Cc the 9pfs & Xen maintainers, doing it now ;)
On 11/3/20 6:01 PM, Philippe Mathieu-Daudé wrote:
> On 11/3/20 5:52 PM, Daniel P. Berrangé wrote:
>> On Tue, Nov 03, 2020 at 05:46:03PM +0100, Philippe Mathieu-Daudé wrote:
>>> We test './configure --without-default-devices' since commit
>>> 20885b5b169 (".travis.yml: test that no-default-device builds
>>> do not regress") in Travis-CI.
>>>
>>> As we prefer to use GitLab-CI, add the equivalent job there.
>>>
>>> One minor difference: the GitLab Ubuntu docker image has the
>>> Xen devel packages installed. As it is automatically selected,
>>> we need to disable it with the --disable-xen option, else the
>>> build fails:
>>>
>>> /usr/bin/ld: libcommon.fa.p/hw_xen_xen-legacy-backend.c.o: in function `xen_be_register_common':
>>> hw/xen/xen-legacy-backend.c:754: undefined reference to `xen_9pfs_ops'
>>> /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x8): undefined reference to `local_ops'
>>> /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x20): undefined reference to `synth_ops'
>>> /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x38): undefined reference to `proxy_ops'
>>> collect2: error: ld returned 1 exit status
>>
>> Surely this is a build bug we need to fix rather than ignore in CI ?
>
> Well it predates this series, so nobody really cared
> (thus I wonder if it makes sense to invest resources
> there).
>
> Anyway I can have a look after 5.2-rc1.
>
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config
2020-11-03 17:04 ` Philippe Mathieu-Daudé
@ 2020-11-04 2:27 ` Stefano Stabellini
-1 siblings, 0 replies; 34+ messages in thread
From: Stefano Stabellini @ 2020-11-04 2:27 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Daniel P. Berrangé, Stefano Stabellini, Anthony Perard,
Paul Durrant, xen-devel@lists.xenproject.org, Greg Kurz,
Christian Schoenebeck, qemu-devel, Paolo Bonzini, Cornelia Huck,
Alex Bennée, David Hildenbrand, qemu-s390x, Fam Zheng,
Richard Henderson, Matthew Rosato, Halil Pasic, Thomas Huth,
Wainer dos Santos Moschetta, Christian Borntraeger
[-- Attachment #1: Type: text/plain, Size: 2427 bytes --]
On Tue, 3 Nov 2020, Philippe Mathieu-Daudé wrote:
> I forgot to Cc the 9pfs & Xen maintainers, doing it now ;)
>
> On 11/3/20 6:01 PM, Philippe Mathieu-Daudé wrote:
> > On 11/3/20 5:52 PM, Daniel P. Berrangé wrote:
> >> On Tue, Nov 03, 2020 at 05:46:03PM +0100, Philippe Mathieu-Daudé wrote:
> >>> We test './configure --without-default-devices' since commit
> >>> 20885b5b169 (".travis.yml: test that no-default-device builds
> >>> do not regress") in Travis-CI.
> >>>
> >>> As we prefer to use GitLab-CI, add the equivalent job there.
> >>>
> >>> One minor difference: the GitLab Ubuntu docker image has the
> >>> Xen devel packages installed. As it is automatically selected,
> >>> we need to disable it with the --disable-xen option, else the
> >>> build fails:
> >>>
> >>> /usr/bin/ld: libcommon.fa.p/hw_xen_xen-legacy-backend.c.o: in function `xen_be_register_common':
> >>> hw/xen/xen-legacy-backend.c:754: undefined reference to `xen_9pfs_ops'
> >>> /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x8): undefined reference to `local_ops'
> >>> /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x20): undefined reference to `synth_ops'
> >>> /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x38): undefined reference to `proxy_ops'
> >>> collect2: error: ld returned 1 exit status
> >>
> >> Surely this is a build bug we need to fix rather than ignore in CI ?
> >
> > Well it predates this series, so nobody really cared
> > (thus I wonder if it makes sense to invest resources
> > there).
> >
> > Anyway I can have a look after 5.2-rc1.
Actually I care about Xen and 9pfs support, it is one of the few
combinations that I use regularly and it is even enabled in the Xilinx
product I look after. But admittedly I don't test QEMU master as much as
I should. With the recent changes to the build system it is not very
suprising that there are some issues. It would be great to have a Xen
and 9pfs test in the gitlab CI-loop.
FYI I tried to build the latest QEMU on Alpine Linux 3.12 ARM64 and I
get:
ninja: unknown tool 'query'
Even after rebuilding ninja master by hand. Any ideas? I don't know much
about ninja.
So I gave up on that and I spinned up a Debian Buster x86 container for
this build. That one got past the "ninja: unknown tool 'query'" error.
The build completed without problems to the end.
Either way I can't reproduce the build error above.
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config
@ 2020-11-04 2:27 ` Stefano Stabellini
0 siblings, 0 replies; 34+ messages in thread
From: Stefano Stabellini @ 2020-11-04 2:27 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Fam Zheng, Thomas Huth, Stefano Stabellini,
Daniel P. Berrangé, Matthew Rosato, Paul Durrant,
Cornelia Huck, Christian Schoenebeck, Greg Kurz,
Wainer dos Santos Moschetta, qemu-devel, Halil Pasic,
Christian Borntraeger, qemu-s390x, Paolo Bonzini, Anthony Perard,
xen-devel@lists.xenproject.org, David Hildenbrand,
Alex Bennée, Richard Henderson
[-- Attachment #1: Type: text/plain, Size: 2427 bytes --]
On Tue, 3 Nov 2020, Philippe Mathieu-Daudé wrote:
> I forgot to Cc the 9pfs & Xen maintainers, doing it now ;)
>
> On 11/3/20 6:01 PM, Philippe Mathieu-Daudé wrote:
> > On 11/3/20 5:52 PM, Daniel P. Berrangé wrote:
> >> On Tue, Nov 03, 2020 at 05:46:03PM +0100, Philippe Mathieu-Daudé wrote:
> >>> We test './configure --without-default-devices' since commit
> >>> 20885b5b169 (".travis.yml: test that no-default-device builds
> >>> do not regress") in Travis-CI.
> >>>
> >>> As we prefer to use GitLab-CI, add the equivalent job there.
> >>>
> >>> One minor difference: the GitLab Ubuntu docker image has the
> >>> Xen devel packages installed. As it is automatically selected,
> >>> we need to disable it with the --disable-xen option, else the
> >>> build fails:
> >>>
> >>> /usr/bin/ld: libcommon.fa.p/hw_xen_xen-legacy-backend.c.o: in function `xen_be_register_common':
> >>> hw/xen/xen-legacy-backend.c:754: undefined reference to `xen_9pfs_ops'
> >>> /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x8): undefined reference to `local_ops'
> >>> /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x20): undefined reference to `synth_ops'
> >>> /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x38): undefined reference to `proxy_ops'
> >>> collect2: error: ld returned 1 exit status
> >>
> >> Surely this is a build bug we need to fix rather than ignore in CI ?
> >
> > Well it predates this series, so nobody really cared
> > (thus I wonder if it makes sense to invest resources
> > there).
> >
> > Anyway I can have a look after 5.2-rc1.
Actually I care about Xen and 9pfs support, it is one of the few
combinations that I use regularly and it is even enabled in the Xilinx
product I look after. But admittedly I don't test QEMU master as much as
I should. With the recent changes to the build system it is not very
suprising that there are some issues. It would be great to have a Xen
and 9pfs test in the gitlab CI-loop.
FYI I tried to build the latest QEMU on Alpine Linux 3.12 ARM64 and I
get:
ninja: unknown tool 'query'
Even after rebuilding ninja master by hand. Any ideas? I don't know much
about ninja.
So I gave up on that and I spinned up a Debian Buster x86 container for
this build. That one got past the "ninja: unknown tool 'query'" error.
The build completed without problems to the end.
Either way I can't reproduce the build error above.
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config
2020-11-04 2:27 ` Stefano Stabellini
@ 2020-11-04 6:17 ` Thomas Huth
-1 siblings, 0 replies; 34+ messages in thread
From: Thomas Huth @ 2020-11-04 6:17 UTC (permalink / raw)
To: Stefano Stabellini, Philippe Mathieu-Daudé
Cc: Daniel P. Berrangé, Anthony Perard, Paul Durrant,
xen-devel@lists.xenproject.org, Greg Kurz, Christian Schoenebeck,
qemu-devel, Paolo Bonzini, Cornelia Huck, Alex Bennée,
David Hildenbrand, qemu-s390x, Fam Zheng, Richard Henderson,
Matthew Rosato, Halil Pasic, Wainer dos Santos Moschetta,
Christian Borntraeger
On 04/11/2020 03.27, Stefano Stabellini wrote:
[...]
> Actually I care about Xen and 9pfs support, it is one of the few
> combinations that I use regularly and it is even enabled in the Xilinx
> product I look after. But admittedly I don't test QEMU master as much as
> I should. With the recent changes to the build system it is not very
> suprising that there are some issues. It would be great to have a Xen
> and 9pfs test in the gitlab CI-loop.
>
>
> FYI I tried to build the latest QEMU on Alpine Linux 3.12 ARM64 and I
> get:
>
> ninja: unknown tool 'query'
>
> Even after rebuilding ninja master by hand. Any ideas? I don't know much
> about ninja.
>
>
> So I gave up on that and I spinned up a Debian Buster x86 container for
> this build. That one got past the "ninja: unknown tool 'query'" error.
> The build completed without problems to the end.
>
> Either way I can't reproduce the build error above.
Did you run "configure" with "--without-default-devices" ?
Thomas
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config
@ 2020-11-04 6:17 ` Thomas Huth
0 siblings, 0 replies; 34+ messages in thread
From: Thomas Huth @ 2020-11-04 6:17 UTC (permalink / raw)
To: Stefano Stabellini, Philippe Mathieu-Daudé
Cc: Fam Zheng, Daniel P. Berrangé, Matthew Rosato, Paul Durrant,
Cornelia Huck, Christian Schoenebeck, Greg Kurz,
Wainer dos Santos Moschetta, qemu-devel, Halil Pasic,
Christian Borntraeger, qemu-s390x, Paolo Bonzini, Anthony Perard,
xen-devel@lists.xenproject.org, David Hildenbrand,
Alex Bennée, Richard Henderson
On 04/11/2020 03.27, Stefano Stabellini wrote:
[...]
> Actually I care about Xen and 9pfs support, it is one of the few
> combinations that I use regularly and it is even enabled in the Xilinx
> product I look after. But admittedly I don't test QEMU master as much as
> I should. With the recent changes to the build system it is not very
> suprising that there are some issues. It would be great to have a Xen
> and 9pfs test in the gitlab CI-loop.
>
>
> FYI I tried to build the latest QEMU on Alpine Linux 3.12 ARM64 and I
> get:
>
> ninja: unknown tool 'query'
>
> Even after rebuilding ninja master by hand. Any ideas? I don't know much
> about ninja.
>
>
> So I gave up on that and I spinned up a Debian Buster x86 container for
> this build. That one got past the "ninja: unknown tool 'query'" error.
> The build completed without problems to the end.
>
> Either way I can't reproduce the build error above.
Did you run "configure" with "--without-default-devices" ?
Thomas
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config
2020-11-04 6:17 ` Thomas Huth
@ 2020-11-05 4:26 ` Stefano Stabellini
-1 siblings, 0 replies; 34+ messages in thread
From: Stefano Stabellini @ 2020-11-05 4:26 UTC (permalink / raw)
To: Thomas Huth
Cc: Stefano Stabellini, Philippe Mathieu-Daudé,
Daniel P. Berrangé, Anthony Perard, Paul Durrant,
xen-devel@lists.xenproject.org, Greg Kurz, Christian Schoenebeck,
qemu-devel, Paolo Bonzini, Cornelia Huck, Alex Bennée,
David Hildenbrand, qemu-s390x, Fam Zheng, Richard Henderson,
Matthew Rosato, Halil Pasic, Wainer dos Santos Moschetta,
Christian Borntraeger
On Wed, 4 Nov 2020, Thomas Huth wrote:
> On 04/11/2020 03.27, Stefano Stabellini wrote:
> [...]
> > Actually I care about Xen and 9pfs support, it is one of the few
> > combinations that I use regularly and it is even enabled in the Xilinx
> > product I look after. But admittedly I don't test QEMU master as much as
> > I should. With the recent changes to the build system it is not very
> > suprising that there are some issues. It would be great to have a Xen
> > and 9pfs test in the gitlab CI-loop.
> >
> >
> > FYI I tried to build the latest QEMU on Alpine Linux 3.12 ARM64 and I
> > get:
> >
> > ninja: unknown tool 'query'
> >
> > Even after rebuilding ninja master by hand. Any ideas? I don't know much
> > about ninja.
> >
> >
> > So I gave up on that and I spinned up a Debian Buster x86 container for
> > this build. That one got past the "ninja: unknown tool 'query'" error.
> > The build completed without problems to the end.
> >
> > Either way I can't reproduce the build error above.
>
> Did you run "configure" with "--without-default-devices" ?
Yes, and still I can't repro the issue, strange. Anyway, I saw that
Philippe managed to find and fix the issue with "hw/9pfs: Fix Kconfig
dependency problem between 9pfs and Xen", so all sorted :)
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config
@ 2020-11-05 4:26 ` Stefano Stabellini
0 siblings, 0 replies; 34+ messages in thread
From: Stefano Stabellini @ 2020-11-05 4:26 UTC (permalink / raw)
To: Thomas Huth
Cc: Fam Zheng, Stefano Stabellini, Daniel P. Berrangé,
Matthew Rosato, Paul Durrant, Alex Bennée, Cornelia Huck,
Christian Schoenebeck, Greg Kurz, Wainer dos Santos Moschetta,
qemu-devel, Halil Pasic, Christian Borntraeger, qemu-s390x,
Paolo Bonzini, Anthony Perard, xen-devel@lists.xenproject.org,
David Hildenbrand, Philippe Mathieu-Daudé, Richard Henderson
On Wed, 4 Nov 2020, Thomas Huth wrote:
> On 04/11/2020 03.27, Stefano Stabellini wrote:
> [...]
> > Actually I care about Xen and 9pfs support, it is one of the few
> > combinations that I use regularly and it is even enabled in the Xilinx
> > product I look after. But admittedly I don't test QEMU master as much as
> > I should. With the recent changes to the build system it is not very
> > suprising that there are some issues. It would be great to have a Xen
> > and 9pfs test in the gitlab CI-loop.
> >
> >
> > FYI I tried to build the latest QEMU on Alpine Linux 3.12 ARM64 and I
> > get:
> >
> > ninja: unknown tool 'query'
> >
> > Even after rebuilding ninja master by hand. Any ideas? I don't know much
> > about ninja.
> >
> >
> > So I gave up on that and I spinned up a Debian Buster x86 container for
> > this build. That one got past the "ninja: unknown tool 'query'" error.
> > The build completed without problems to the end.
> >
> > Either way I can't reproduce the build error above.
>
> Did you run "configure" with "--without-default-devices" ?
Yes, and still I can't repro the issue, strange. Anyway, I saw that
Philippe managed to find and fix the issue with "hw/9pfs: Fix Kconfig
dependency problem between 9pfs and Xen", so all sorted :)
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config
2020-11-05 4:26 ` Stefano Stabellini
@ 2020-11-05 8:19 ` Philippe Mathieu-Daudé
-1 siblings, 0 replies; 34+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-11-05 8:19 UTC (permalink / raw)
To: Stefano Stabellini
Cc: Thomas Huth, Fam Zheng, Daniel P. Berrangé, Matthew Rosato,
Paul Durrant, Alex Bennée, Cornelia Huck,
Christian Schoenebeck, Greg Kurz, Wainer dos Santos Moschetta,
qemu-devel, Halil Pasic, Christian Borntraeger, qemu-s390x,
Paolo Bonzini, Anthony Perard, xen-devel@lists.xenproject.org,
David Hildenbrand, Philippe Mathieu-Daudé, Richard Henderson
[-- Attachment #1: Type: text/plain, Size: 1545 bytes --]
Le jeu. 5 nov. 2020 05:28, Stefano Stabellini <sstabellini@kernel.org> a
écrit :
> On Wed, 4 Nov 2020, Thomas Huth wrote:
> > On 04/11/2020 03.27, Stefano Stabellini wrote:
> > [...]
> > > Actually I care about Xen and 9pfs support, it is one of the few
> > > combinations that I use regularly and it is even enabled in the Xilinx
> > > product I look after. But admittedly I don't test QEMU master as much
> as
> > > I should. With the recent changes to the build system it is not very
> > > suprising that there are some issues. It would be great to have a Xen
> > > and 9pfs test in the gitlab CI-loop.
> > >
> > >
> > > FYI I tried to build the latest QEMU on Alpine Linux 3.12 ARM64 and I
> > > get:
> > >
> > > ninja: unknown tool 'query'
> > >
> > > Even after rebuilding ninja master by hand. Any ideas? I don't know
> much
> > > about ninja.
> > >
> > >
> > > So I gave up on that and I spinned up a Debian Buster x86 container for
> > > this build. That one got past the "ninja: unknown tool 'query'" error.
> > > The build completed without problems to the end.
> > >
> > > Either way I can't reproduce the build error above.
> >
> > Did you run "configure" with "--without-default-devices" ?
>
> Yes, and still I can't repro the issue, strange. Anyway, I saw that
> Philippe managed to find and fix the issue with "hw/9pfs: Fix Kconfig
> dependency problem between 9pfs and Xen", so all sorted :)
>
Paolo figured the problem and sent a diff, I just forwarded it as a formal
patch ;)
>
[-- Attachment #2: Type: text/html, Size: 2306 bytes --]
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config
@ 2020-11-05 8:19 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 34+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-11-05 8:19 UTC (permalink / raw)
To: Stefano Stabellini
Cc: Fam Zheng, Thomas Huth, Daniel P. Berrangé, Matthew Rosato,
Paul Durrant, Philippe Mathieu-Daudé, Cornelia Huck,
Christian Schoenebeck, Greg Kurz, Wainer dos Santos Moschetta,
qemu-devel, Halil Pasic, Christian Borntraeger, qemu-s390x,
xen-devel@lists.xenproject.org, Anthony Perard, Paolo Bonzini,
David Hildenbrand, Alex Bennée, Richard Henderson
[-- Attachment #1: Type: text/plain, Size: 1545 bytes --]
Le jeu. 5 nov. 2020 05:28, Stefano Stabellini <sstabellini@kernel.org> a
écrit :
> On Wed, 4 Nov 2020, Thomas Huth wrote:
> > On 04/11/2020 03.27, Stefano Stabellini wrote:
> > [...]
> > > Actually I care about Xen and 9pfs support, it is one of the few
> > > combinations that I use regularly and it is even enabled in the Xilinx
> > > product I look after. But admittedly I don't test QEMU master as much
> as
> > > I should. With the recent changes to the build system it is not very
> > > suprising that there are some issues. It would be great to have a Xen
> > > and 9pfs test in the gitlab CI-loop.
> > >
> > >
> > > FYI I tried to build the latest QEMU on Alpine Linux 3.12 ARM64 and I
> > > get:
> > >
> > > ninja: unknown tool 'query'
> > >
> > > Even after rebuilding ninja master by hand. Any ideas? I don't know
> much
> > > about ninja.
> > >
> > >
> > > So I gave up on that and I spinned up a Debian Buster x86 container for
> > > this build. That one got past the "ninja: unknown tool 'query'" error.
> > > The build completed without problems to the end.
> > >
> > > Either way I can't reproduce the build error above.
> >
> > Did you run "configure" with "--without-default-devices" ?
>
> Yes, and still I can't repro the issue, strange. Anyway, I saw that
> Philippe managed to find and fix the issue with "hw/9pfs: Fix Kconfig
> dependency problem between 9pfs and Xen", so all sorted :)
>
Paolo figured the problem and sent a diff, I just forwarded it as a formal
patch ;)
>
[-- Attachment #2: Type: text/html, Size: 2306 bytes --]
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config
2020-11-04 2:27 ` Stefano Stabellini
@ 2020-11-04 8:12 ` Paolo Bonzini
-1 siblings, 0 replies; 34+ messages in thread
From: Paolo Bonzini @ 2020-11-04 8:12 UTC (permalink / raw)
To: Stefano Stabellini
Cc: Philippe Mathieu-Daudé, Daniel P. Berrangé,
Anthony Perard, Paul Durrant, xen-devel@lists.xenproject.org,
Greg Kurz, Christian Schoenebeck, qemu-devel, Cornelia Huck,
Alex Bennée, David Hildenbrand, qemu-s390x, Fam Zheng,
Richard Henderson, Matthew Rosato, Halil Pasic, Thomas Huth,
Wainer dos Santos Moschetta, Christian Borntraeger
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
Il mer 4 nov 2020, 03:27 Stefano Stabellini <sstabellini@kernel.org> ha
scritto:
> FYI I tried to build the latest QEMU on Alpine Linux 3.12 ARM64 and I
> get:
>
> ninja: unknown tool 'query'
>
> Even after rebuilding ninja master by hand. Any ideas? I don't know much
> about ninja.
>
Are you sure you have ninja installed and not its clone samurai (yes, I am
serious)? I have contributed query support to samurai but it hasn't made it
to a release yet.
What is the output of "ninja -t list"?
Paolo
>
> So I gave up on that and I spinned up a Debian Buster x86 container for
> this build. That one got past the "ninja: unknown tool 'query'" error.
> The build completed without problems to the end.
>
> Either way I can't reproduce the build error above.
[-- Attachment #2: Type: text/html, Size: 1465 bytes --]
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config
@ 2020-11-04 8:12 ` Paolo Bonzini
0 siblings, 0 replies; 34+ messages in thread
From: Paolo Bonzini @ 2020-11-04 8:12 UTC (permalink / raw)
To: Stefano Stabellini
Cc: Fam Zheng, Thomas Huth, Daniel P. Berrangé, Matthew Rosato,
Paul Durrant, Alex Bennée, Cornelia Huck,
Christian Schoenebeck, Greg Kurz, Wainer dos Santos Moschetta,
qemu-devel, Halil Pasic, Christian Borntraeger, qemu-s390x,
Anthony Perard, xen-devel@lists.xenproject.org, David Hildenbrand,
Philippe Mathieu-Daudé, Richard Henderson
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
Il mer 4 nov 2020, 03:27 Stefano Stabellini <sstabellini@kernel.org> ha
scritto:
> FYI I tried to build the latest QEMU on Alpine Linux 3.12 ARM64 and I
> get:
>
> ninja: unknown tool 'query'
>
> Even after rebuilding ninja master by hand. Any ideas? I don't know much
> about ninja.
>
Are you sure you have ninja installed and not its clone samurai (yes, I am
serious)? I have contributed query support to samurai but it hasn't made it
to a release yet.
What is the output of "ninja -t list"?
Paolo
>
> So I gave up on that and I spinned up a Debian Buster x86 container for
> this build. That one got past the "ninja: unknown tool 'query'" error.
> The build completed without problems to the end.
>
> Either way I can't reproduce the build error above.
[-- Attachment #2: Type: text/html, Size: 1465 bytes --]
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config
2020-11-04 8:12 ` Paolo Bonzini
@ 2020-11-05 2:48 ` Stefano Stabellini
-1 siblings, 0 replies; 34+ messages in thread
From: Stefano Stabellini @ 2020-11-05 2:48 UTC (permalink / raw)
To: Paolo Bonzini
Cc: Stefano Stabellini, Philippe Mathieu-Daudé,
Daniel P. Berrangé, Anthony Perard, Paul Durrant,
xen-devel@lists.xenproject.org, Greg Kurz, Christian Schoenebeck,
qemu-devel, Cornelia Huck, Alex Bennée, David Hildenbrand,
qemu-s390x, Fam Zheng, Richard Henderson, Matthew Rosato,
Halil Pasic, Thomas Huth, Wainer dos Santos Moschetta,
Christian Borntraeger
[-- Attachment #1: Type: text/plain, Size: 976 bytes --]
On Wed, 4 Nov 2020, Paolo Bonzini wrote:
> Il mer 4 nov 2020, 03:27 Stefano Stabellini <sstabellini@kernel.org> ha scritto:
> FYI I tried to build the latest QEMU on Alpine Linux 3.12 ARM64 and I
> get:
>
> ninja: unknown tool 'query'
>
> Even after rebuilding ninja master by hand. Any ideas? I don't know much
> about ninja.
>
>
> Are you sure you have ninja installed and not its clone samurai (yes, I am serious)? I have contributed query support to samurai but it
> hasn't made it to a release yet.
>
> What is the output of "ninja -t list"?
I repeated all the steps to make sure. The first time I was using
Samurai because Alpine Linux comes with it and not Ninja. Then, I
removed Samurai and built and installed Ninja by hand from
https://github.com/ninja-build/ninja and that actually works. Yesterday
it was late and I was distracted by global events -- I must have failed
to update Ninja appropriately. Sorry for the confusion.
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config
@ 2020-11-05 2:48 ` Stefano Stabellini
0 siblings, 0 replies; 34+ messages in thread
From: Stefano Stabellini @ 2020-11-05 2:48 UTC (permalink / raw)
To: Paolo Bonzini
Cc: Fam Zheng, Thomas Huth, Stefano Stabellini,
Daniel P. Berrangé, Matthew Rosato, Paul Durrant,
Alex Bennée, Cornelia Huck, Christian Schoenebeck, Greg Kurz,
Wainer dos Santos Moschetta, qemu-devel, Halil Pasic,
Christian Borntraeger, qemu-s390x, Anthony Perard,
xen-devel@lists.xenproject.org, David Hildenbrand,
Philippe Mathieu-Daudé, Richard Henderson
[-- Attachment #1: Type: text/plain, Size: 976 bytes --]
On Wed, 4 Nov 2020, Paolo Bonzini wrote:
> Il mer 4 nov 2020, 03:27 Stefano Stabellini <sstabellini@kernel.org> ha scritto:
> FYI I tried to build the latest QEMU on Alpine Linux 3.12 ARM64 and I
> get:
>
> ninja: unknown tool 'query'
>
> Even after rebuilding ninja master by hand. Any ideas? I don't know much
> about ninja.
>
>
> Are you sure you have ninja installed and not its clone samurai (yes, I am serious)? I have contributed query support to samurai but it
> hasn't made it to a release yet.
>
> What is the output of "ninja -t list"?
I repeated all the steps to make sure. The first time I was using
Samurai because Alpine Linux comes with it and not Ninja. Then, I
removed Samurai and built and installed Ninja by hand from
https://github.com/ninja-build/ninja and that actually works. Yesterday
it was late and I was distracted by global events -- I must have failed
to update Ninja appropriately. Sorry for the confusion.
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config
2020-11-05 2:48 ` Stefano Stabellini
@ 2020-11-05 11:00 ` Paolo Bonzini
-1 siblings, 0 replies; 34+ messages in thread
From: Paolo Bonzini @ 2020-11-05 11:00 UTC (permalink / raw)
To: Stefano Stabellini
Cc: Philippe Mathieu-Daudé, Daniel P. Berrangé,
Anthony Perard, Paul Durrant, xen-devel@lists.xenproject.org,
Greg Kurz, Christian Schoenebeck, qemu-devel, Cornelia Huck,
Alex Bennée, David Hildenbrand, qemu-s390x, Fam Zheng,
Richard Henderson, Matthew Rosato, Halil Pasic, Thomas Huth,
Wainer dos Santos Moschetta, Christian Borntraeger
On 05/11/20 03:48, Stefano Stabellini wrote:
> I repeated all the steps to make sure. The first time I was using
> Samurai because Alpine Linux comes with it and not Ninja. Then, I
> removed Samurai and built and installed Ninja by hand from
> https://github.com/ninja-build/ninja and that actually works. Yesterday
> it was late and I was distracted by global events -- I must have failed
> to update Ninja appropriately. Sorry for the confusion.
FWIW I sent an Alpine merge request to support "ninja -t query". We
should add an Alpine container and pipeline once it's merged.
Paolo
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config
@ 2020-11-05 11:00 ` Paolo Bonzini
0 siblings, 0 replies; 34+ messages in thread
From: Paolo Bonzini @ 2020-11-05 11:00 UTC (permalink / raw)
To: Stefano Stabellini
Cc: Fam Zheng, Thomas Huth, Daniel P. Berrangé, Matthew Rosato,
Paul Durrant, Alex Bennée, Cornelia Huck,
Christian Schoenebeck, Greg Kurz, Wainer dos Santos Moschetta,
qemu-devel, Halil Pasic, Christian Borntraeger, qemu-s390x,
Anthony Perard, xen-devel@lists.xenproject.org, David Hildenbrand,
Philippe Mathieu-Daudé, Richard Henderson
On 05/11/20 03:48, Stefano Stabellini wrote:
> I repeated all the steps to make sure. The first time I was using
> Samurai because Alpine Linux comes with it and not Ninja. Then, I
> removed Samurai and built and installed Ninja by hand from
> https://github.com/ninja-build/ninja and that actually works. Yesterday
> it was late and I was distracted by global events -- I must have failed
> to update Ninja appropriately. Sorry for the confusion.
FWIW I sent an Alpine merge request to support "ninja -t query". We
should add an Alpine container and pipeline once it's merged.
Paolo
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config
2020-11-03 17:01 ` Philippe Mathieu-Daudé
2020-11-03 17:02 ` Daniel P. Berrangé
2020-11-03 17:04 ` Philippe Mathieu-Daudé
@ 2020-11-03 20:57 ` Paolo Bonzini
2020-11-03 21:07 ` Philippe Mathieu-Daudé
2 siblings, 1 reply; 34+ messages in thread
From: Paolo Bonzini @ 2020-11-03 20:57 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Fam Zheng, Thomas Huth, Daniel P. Berrangé, Matthew Rosato,
David Hildenbrand, Cornelia Huck, qemu-devel,
Wainer dos Santos Moschetta, Halil Pasic, Christian Borntraeger,
qemu-s390x, Alex Bennée, Richard Henderson
On Tue, Nov 3, 2020 at 6:01 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> On 11/3/20 5:52 PM, Daniel P. Berrangé wrote:
> > On Tue, Nov 03, 2020 at 05:46:03PM +0100, Philippe Mathieu-Daudé wrote:
> >> We test './configure --without-default-devices' since commit
> >> 20885b5b169 (".travis.yml: test that no-default-device builds
> >> do not regress") in Travis-CI.
> >>
> >> One minor difference: the GitLab Ubuntu docker image has the
> >> Xen devel packages installed. As it is automatically selected,
> >> we need to disable it with the --disable-xen option, else the
> >> build fails:
> >>
> >> /usr/bin/ld: libcommon.fa.p/hw_xen_xen-legacy-backend.c.o: in function `xen_be_register_common':
> >> hw/xen/xen-legacy-backend.c:754: undefined reference to `xen_9pfs_ops'
> >> /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x8): undefined reference to `local_ops'
> >> /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x20): undefined reference to `synth_ops'
> >> /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x38): undefined reference to `proxy_ops'
All these symbols are defined in hw/9pfs/meson.build's fs_ss, which is
conditional on CONFIG_9PFS. So:
diff --git a/accel/Kconfig b/accel/Kconfig
index 2ad94a3839..d24664d736 100644
--- a/accel/Kconfig
+++ b/accel/Kconfig
@@ -7,3 +7,4 @@ config KVM
config XEN
bool
select FSDEV_9P if VIRTFS
+ select 9PFS if VIRTFS
or alternatively (and I think better):
diff --git a/hw/9pfs/Kconfig b/hw/9pfs/Kconfig
index d3ebd73730..3ae5749661 100644
--- a/hw/9pfs/Kconfig
+++ b/hw/9pfs/Kconfig
@@ -2,12 +2,8 @@ config FSDEV_9P
bool
depends on VIRTFS
-config 9PFS
- bool
-
config VIRTIO_9P
bool
default y
depends on VIRTFS && VIRTIO
select FSDEV_9P
- select 9PFS
diff --git a/hw/9pfs/meson.build b/hw/9pfs/meson.build
index cc09426212..99be5d9119 100644
--- a/hw/9pfs/meson.build
+++ b/hw/9pfs/meson.build
@@ -15,6 +15,6 @@ fs_ss.add(files(
'coxattr.c',
))
fs_ss.add(when: 'CONFIG_XEN', if_true: files('xen-9p-backend.c'))
-softmmu_ss.add_all(when: 'CONFIG_9PFS', if_true: fs_ss)
+softmmu_ss.add_all(when: 'CONFIG_FSDEV_9P', if_true: fs_ss)
specific_ss.add(when: 'CONFIG_VIRTIO_9P', if_true: files('virtio-9p-device.c'))
Paolo
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config
2020-11-03 20:57 ` Paolo Bonzini
@ 2020-11-03 21:07 ` Philippe Mathieu-Daudé
2020-11-03 21:12 ` Paolo Bonzini
0 siblings, 1 reply; 34+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-11-03 21:07 UTC (permalink / raw)
To: Paolo Bonzini
Cc: Fam Zheng, Thomas Huth, Daniel P. Berrangé, Matthew Rosato,
David Hildenbrand, Cornelia Huck, qemu-devel,
Wainer dos Santos Moschetta, Halil Pasic, Christian Borntraeger,
qemu-s390x, Alex Bennée, Richard Henderson
On 11/3/20 9:57 PM, Paolo Bonzini wrote:
> On Tue, Nov 3, 2020 at 6:01 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>> On 11/3/20 5:52 PM, Daniel P. Berrangé wrote:
>>> On Tue, Nov 03, 2020 at 05:46:03PM +0100, Philippe Mathieu-Daudé wrote:
>>>> We test './configure --without-default-devices' since commit
>>>> 20885b5b169 (".travis.yml: test that no-default-device builds
>>>> do not regress") in Travis-CI.
>>>>
>>>> One minor difference: the GitLab Ubuntu docker image has the
>>>> Xen devel packages installed. As it is automatically selected,
>>>> we need to disable it with the --disable-xen option, else the
>>>> build fails:
>>>>
>>>> /usr/bin/ld: libcommon.fa.p/hw_xen_xen-legacy-backend.c.o: in function `xen_be_register_common':
>>>> hw/xen/xen-legacy-backend.c:754: undefined reference to `xen_9pfs_ops'
>>>> /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x8): undefined reference to `local_ops'
>>>> /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x20): undefined reference to `synth_ops'
>>>> /usr/bin/ld: libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x38): undefined reference to `proxy_ops'
>
> All these symbols are defined in hw/9pfs/meson.build's fs_ss, which is
> conditional on CONFIG_9PFS. So:
>
> diff --git a/accel/Kconfig b/accel/Kconfig
> index 2ad94a3839..d24664d736 100644
> --- a/accel/Kconfig
> +++ b/accel/Kconfig
> @@ -7,3 +7,4 @@ config KVM
> config XEN
> bool
> select FSDEV_9P if VIRTFS
> + select 9PFS if VIRTFS
Without this line ^ it works! Thanks :*
Can you reply with your S-o-b? :)
>
> or alternatively (and I think better):
>
> diff --git a/hw/9pfs/Kconfig b/hw/9pfs/Kconfig
> index d3ebd73730..3ae5749661 100644
> --- a/hw/9pfs/Kconfig
> +++ b/hw/9pfs/Kconfig
> @@ -2,12 +2,8 @@ config FSDEV_9P
> bool
> depends on VIRTFS
>
> -config 9PFS
> - bool
> -
> config VIRTIO_9P
> bool
> default y
> depends on VIRTFS && VIRTIO
> select FSDEV_9P
> - select 9PFS
> diff --git a/hw/9pfs/meson.build b/hw/9pfs/meson.build
> index cc09426212..99be5d9119 100644
> --- a/hw/9pfs/meson.build
> +++ b/hw/9pfs/meson.build
> @@ -15,6 +15,6 @@ fs_ss.add(files(
> 'coxattr.c',
> ))
> fs_ss.add(when: 'CONFIG_XEN', if_true: files('xen-9p-backend.c'))
> -softmmu_ss.add_all(when: 'CONFIG_9PFS', if_true: fs_ss)
> +softmmu_ss.add_all(when: 'CONFIG_FSDEV_9P', if_true: fs_ss)
>
> specific_ss.add(when: 'CONFIG_VIRTIO_9P', if_true: files('virtio-9p-device.c'))
>
> Paolo
>
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config
2020-11-03 21:07 ` Philippe Mathieu-Daudé
@ 2020-11-03 21:12 ` Paolo Bonzini
2020-11-04 8:45 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 34+ messages in thread
From: Paolo Bonzini @ 2020-11-03 21:12 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Fam Zheng, Thomas Huth, Daniel P. Berrangé, Matthew Rosato,
David Hildenbrand, Cornelia Huck, qemu-devel,
Wainer dos Santos Moschetta, Halil Pasic, Christian Borntraeger,
qemu-s390x, Alex Bennée, Richard Henderson
On 03/11/20 22:07, Philippe Mathieu-Daudé wrote:
>> diff --git a/accel/Kconfig b/accel/Kconfig
>> index 2ad94a3839..d24664d736 100644
>> --- a/accel/Kconfig
>> +++ b/accel/Kconfig
>> @@ -7,3 +7,4 @@ config KVM
>> config XEN
>> bool
>> select FSDEV_9P if VIRTFS
>> + select 9PFS if VIRTFS
> Without this line ^ it works! Thanks :*
Without which line?
(Also if both work I prefer the other one).
Paolo
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config
2020-11-03 21:12 ` Paolo Bonzini
@ 2020-11-04 8:45 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 34+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-11-04 8:45 UTC (permalink / raw)
To: Paolo Bonzini
Cc: Fam Zheng, Thomas Huth, Daniel P. Berrangé, Matthew Rosato,
David Hildenbrand, Cornelia Huck, qemu-devel,
Wainer dos Santos Moschetta, Halil Pasic, Christian Borntraeger,
qemu-s390x, Alex Bennée, Richard Henderson
On 11/3/20 10:12 PM, Paolo Bonzini wrote:
> On 03/11/20 22:07, Philippe Mathieu-Daudé wrote:
>>> diff --git a/accel/Kconfig b/accel/Kconfig
>>> index 2ad94a3839..d24664d736 100644
>>> --- a/accel/Kconfig
>>> +++ b/accel/Kconfig
>>> @@ -7,3 +7,4 @@ config KVM
>>> config XEN
>>> bool
>>> select FSDEV_9P if VIRTFS
>>> + select 9PFS if VIRTFS
>> Without this line ^ it works! Thanks :*
>
> Without which line?
Not adding "select 9PFS if VIRTFS" (keeping
the current "select FSDEV_9P if VIRTFS").
>
> (Also if both work I prefer the other one).
>
> Paolo
>
^ permalink raw reply [flat|nested] 34+ messages in thread