All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Lee Jones <lee.jones@linaro.org>
Cc: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
	netdev@vger.kernel.org,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	linux-kernel@vger.kernel.org, kuba@kernel.org,
	davem@davemloft.net, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 06/12] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header
Date: Wed, 4 Nov 2020 14:33:54 +0100	[thread overview]
Message-ID: <20201104133354.GA933237@lunn.ch> (raw)
In-Reply-To: <20201104090610.1446616-7-lee.jones@linaro.org>

On Wed, Nov 04, 2020 at 09:06:04AM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'ndev' not described in 'am65_cpsw_timer_set'
>  drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'est_new' not described in 'am65_cpsw_timer_set'
> 
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

I _think_ these have got missed so far in the various cleanup passes
because of missing COMPILE_TEST. I've been adding that as part of
fixing these warnings. When your respin, could you add that as well?

Thanks
	Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Lee Jones <lee.jones@linaro.org>
Cc: davem@davemloft.net, kuba@kernel.org,
	Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 06/12] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header
Date: Wed, 4 Nov 2020 14:33:54 +0100	[thread overview]
Message-ID: <20201104133354.GA933237@lunn.ch> (raw)
In-Reply-To: <20201104090610.1446616-7-lee.jones@linaro.org>

On Wed, Nov 04, 2020 at 09:06:04AM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'ndev' not described in 'am65_cpsw_timer_set'
>  drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'est_new' not described in 'am65_cpsw_timer_set'
> 
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

I _think_ these have got missed so far in the various cleanup passes
because of missing COMPILE_TEST. I've been adding that as part of
fixing these warnings. When your respin, could you add that as well?

Thanks
	Andrew

  reply	other threads:[~2020-11-04 13:35 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-04  9:05 [PATCH 00/12] [Set 2] Rid W=1 warnings in Net Lee Jones
2020-11-04  9:05 ` Lee Jones
2020-11-04  9:05 ` [PATCH 01/12] net: usb: lan78xx: Remove lots of set but unused 'ret' variables Lee Jones
2020-11-04  9:05   ` Lee Jones
2020-11-04 13:23   ` Andrew Lunn
2020-11-04 13:23     ` Andrew Lunn
2020-11-04  9:06 ` [PATCH 02/12] net: ethernet: smsc: smc911x: Mark 'status' as __maybe_unused Lee Jones
2020-11-04  9:06   ` Lee Jones
2020-11-04 13:22   ` Andrew Lunn
2020-11-04 13:22     ` Andrew Lunn
2020-11-04 14:31     ` Lee Jones
2020-11-04 14:31       ` Lee Jones
2020-11-04 14:38       ` Lee Jones
2020-11-04 14:38         ` Lee Jones
2020-11-04 14:47         ` Andrew Lunn
2020-11-04 14:47           ` Andrew Lunn
2020-11-04 14:45       ` Andrew Lunn
2020-11-04 14:45         ` Andrew Lunn
2020-11-04 14:56         ` Lee Jones
2020-11-04 14:56           ` Lee Jones
2020-11-04  9:06 ` [PATCH 03/12] net: ethernet: xilinx: xilinx_emaclite: Document 'txqueue' even if it is unused Lee Jones
2020-11-04  9:06   ` Lee Jones
2020-11-04 13:24   ` Andrew Lunn
2020-11-04 13:24     ` Andrew Lunn
2020-11-04  9:06 ` [PATCH 04/12] net: ethernet: smsc: smc91x: Demote non-conformant kernel function header Lee Jones
2020-11-04  9:06   ` Lee Jones
2020-11-04  9:06 ` [PATCH 05/12] net: xen-netback: xenbus: Demote nonconformant kernel-doc headers Lee Jones
2020-11-04  9:06   ` Lee Jones
2020-11-04 12:00   ` Wei Liu
2020-11-04 12:00     ` Wei Liu
2020-11-04 13:27   ` Andrew Lunn
2020-11-04 13:27     ` Andrew Lunn
2020-11-04  9:06 ` [PATCH 06/12] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header Lee Jones
2020-11-04  9:06   ` Lee Jones
2020-11-04 13:33   ` Andrew Lunn [this message]
2020-11-04 13:33     ` Andrew Lunn
2020-11-04 14:28     ` Lee Jones
2020-11-04 14:28       ` Lee Jones
2020-11-04 14:38       ` Andrew Lunn
2020-11-04 14:38         ` Andrew Lunn
2020-11-04 15:02         ` Lee Jones
2020-11-04 15:02           ` Lee Jones
2020-11-04  9:06 ` [PATCH 07/12] net: ethernet: ti: am65-cpts: Document am65_cpts_rx_enable()'s 'en' parameter Lee Jones
2020-11-04  9:06   ` Lee Jones
2020-11-04 11:37   ` Grygorii Strashko
2020-11-04 11:37     ` Grygorii Strashko
2020-11-04  9:06 ` [PATCH 08/12] net: xen-netfront: Demote non-kernel-doc headers to standard comment blocks Lee Jones
2020-11-04  9:06   ` Lee Jones
2020-11-04  9:31   ` Jürgen Groß
2020-11-04  9:31     ` Jürgen Groß
2020-11-04 13:36   ` Andrew Lunn
2020-11-04 13:36     ` Andrew Lunn
2020-11-04  9:06 ` [PATCH 09/12] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours Lee Jones
2020-11-04  9:06   ` Lee Jones
2020-11-04  9:06   ` Lee Jones
2020-11-04 13:38   ` Andrew Lunn
2020-11-04 13:38     ` Andrew Lunn
2020-11-04 13:38     ` Andrew Lunn
2020-11-04 17:54     ` drt
2020-11-04 17:54       ` drt
2020-11-04 17:54       ` drt
2020-11-04  9:06 ` [PATCH 10/12] net: ethernet: toshiba: ps3_gelic_net: " Lee Jones
2020-11-04  9:06   ` Lee Jones
2020-11-04  9:06   ` Lee Jones
2020-11-04 13:41   ` Andrew Lunn
2020-11-04 13:41     ` Andrew Lunn
2020-11-04 13:41     ` Andrew Lunn
2020-11-04  9:06 ` [PATCH 11/12] net: ethernet: toshiba: spider_net: Document a whole bunch of function parameters Lee Jones
2020-11-04  9:06   ` Lee Jones
2020-11-04 13:43   ` Andrew Lunn
2020-11-04 13:43     ` Andrew Lunn
2020-11-04  9:06 ` [PATCH 12/12] net: ethernet: ibm: ibmvnic: Fix some kernel-doc issues Lee Jones
2020-11-04  9:06   ` Lee Jones
2020-11-04  9:06   ` Lee Jones
2020-11-04 17:59   ` drt
2020-11-04 17:59     ` drt
2020-11-04 17:59     ` drt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201104133354.GA933237@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=gustavoars@kernel.org \
    --cc=ivan.khoronzhuk@linaro.org \
    --cc=kuba@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.