All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leonro@nvidia.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: alsa-devel@alsa-project.org, Parav Pandit <parav@mellanox.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	Takashi Iwai <tiwai@suse.de>, Netdev <netdev@vger.kernel.org>,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Fred Oh <fred.oh@linux.intel.com>,
	linux-rdma <linux-rdma@vger.kernel.org>,
	Doug Ledford <dledford@redhat.com>,
	Mark Brown <broonie@kernel.org>, Jason Gunthorpe <jgg@nvidia.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Dave Ertman <david.m.ertman@intel.com>,
	"Saleem, Shiraz" <shiraz.saleem@intel.com>,
	David Miller <davem@davemloft.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Patil, Kiran" <kiran.patil@intel.com>
Subject: Re: [PATCH v3 01/10] Add auxiliary bus support
Date: Thu, 5 Nov 2020 11:47:19 +0200	[thread overview]
Message-ID: <20201105094719.GQ5429@unreal> (raw)
In-Reply-To: <CAPcyv4i9s=CsO5VJOhPnS77K=bD0LTQ8TUAbhLd+0OmyU8YQ3g@mail.gmail.com>

On Thu, Nov 05, 2020 at 01:19:09AM -0800, Dan Williams wrote:
> Some doc fixups, and minor code feedback. Otherwise looks good to me.
>
> On Thu, Oct 22, 2020 at 5:35 PM Dave Ertman <david.m.ertman@intel.com> wrote:
> >

<...>

> >
> > +config AUXILIARY_BUS
> > +       bool
>
> tristate? Unless you need non-exported symbols, might as well let this
> be a module.

I asked it to be "bool", because bus as a module is an invitation for
a disaster. For example if I compile-in mlx5 which is based on this bus,
and won't add auxiliary_bus as a module to initramfs, the system won't boot.

<...>

>
> Per above SPDX is v2 only, so...

Isn't it default for the Linux kernel?

>
> MODULE_LICENSE("GPL v2");

Thanks

WARNING: multiple messages have this Message-ID (diff)
From: Leon Romanovsky <leonro@nvidia.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Dave Ertman <david.m.ertman@intel.com>,
	alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
	Mark Brown <broonie@kernel.org>,
	linux-rdma <linux-rdma@vger.kernel.org>,
	Jason Gunthorpe <jgg@nvidia.com>,
	Doug Ledford <dledford@redhat.com>,
	Netdev <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Fred Oh <fred.oh@linux.intel.com>,
	Parav Pandit <parav@mellanox.com>,
	"Saleem, Shiraz" <shiraz.saleem@intel.com>,
	"Patil, Kiran" <kiran.patil@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 01/10] Add auxiliary bus support
Date: Thu, 5 Nov 2020 11:47:19 +0200	[thread overview]
Message-ID: <20201105094719.GQ5429@unreal> (raw)
In-Reply-To: <CAPcyv4i9s=CsO5VJOhPnS77K=bD0LTQ8TUAbhLd+0OmyU8YQ3g@mail.gmail.com>

On Thu, Nov 05, 2020 at 01:19:09AM -0800, Dan Williams wrote:
> Some doc fixups, and minor code feedback. Otherwise looks good to me.
>
> On Thu, Oct 22, 2020 at 5:35 PM Dave Ertman <david.m.ertman@intel.com> wrote:
> >

<...>

> >
> > +config AUXILIARY_BUS
> > +       bool
>
> tristate? Unless you need non-exported symbols, might as well let this
> be a module.

I asked it to be "bool", because bus as a module is an invitation for
a disaster. For example if I compile-in mlx5 which is based on this bus,
and won't add auxiliary_bus as a module to initramfs, the system won't boot.

<...>

>
> Per above SPDX is v2 only, so...

Isn't it default for the Linux kernel?

>
> MODULE_LICENSE("GPL v2");

Thanks

  reply	other threads:[~2020-11-06  8:45 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-23  0:33 [PATCH v3 00/10] Auxiliary bus implementation and SOF multi-client support Dave Ertman
2020-10-23  0:33 ` Dave Ertman
2020-10-23  0:33 ` [PATCH v3 01/10] Add auxiliary bus support Dave Ertman
2020-10-23  0:33   ` Dave Ertman
2020-11-05  9:19   ` Dan Williams
2020-11-05  9:19     ` Dan Williams
2020-11-05  9:47     ` Leon Romanovsky [this message]
2020-11-05  9:47       ` Leon Romanovsky
2020-11-05 17:12       ` Dan Williams
2020-11-05 17:12         ` Dan Williams
2020-11-05 19:30         ` Leon Romanovsky
2020-11-05 19:30           ` Leon Romanovsky
2020-11-05 20:27           ` Dan Williams
2020-11-05 20:27             ` Dan Williams
2020-11-05 20:22         ` Greg KH
2020-11-05 20:22           ` Greg KH
2020-11-05 20:24           ` Dan Williams
2020-11-05 20:24             ` Dan Williams
2020-11-05 19:27     ` Ertman, David M
2020-11-05 19:27       ` Ertman, David M
2020-11-05 19:32       ` Pierre-Louis Bossart
2020-11-05 19:32         ` Pierre-Louis Bossart
2020-11-05 19:37         ` Leon Romanovsky
2020-11-05 19:37           ` Leon Romanovsky
2020-11-05 19:35       ` Leon Romanovsky
2020-11-05 19:35         ` Leon Romanovsky
2020-11-05 20:52         ` Ertman, David M
2020-11-05 20:52           ` Ertman, David M
2020-11-05 19:40       ` Parav Pandit
2020-11-05 19:40         ` Parav Pandit
2020-11-05 20:26         ` Dan Williams
2020-11-05 20:26           ` Dan Williams
2020-11-05 20:37           ` Parav Pandit
2020-11-05 20:37             ` Parav Pandit
2020-11-06 19:35             ` Mark Brown
2020-11-06 19:35               ` Mark Brown
2020-11-10  7:23               ` Oded Gabbay
2020-11-10  7:23                 ` Oded Gabbay
2020-11-05 22:00       ` Dan Williams
2020-11-05 22:00         ` Dan Williams
2020-11-05 23:48         ` Ertman, David M
2020-11-05 23:48           ` Ertman, David M
2020-11-13 15:50   ` Greg KH
2020-11-13 15:50     ` Greg KH
2020-11-13 16:07     ` Ertman, David M
2020-11-13 16:07       ` Ertman, David M
2020-11-13 23:21       ` Greg KH
2020-11-13 23:21         ` Greg KH
2020-11-15  6:48         ` Leon Romanovsky
2020-11-15  6:48           ` Leon Romanovsky
2020-10-23  0:33 ` [PATCH v3 02/10] ASoC: SOF: Introduce descriptors for SOF client Dave Ertman
2020-10-23  0:33   ` Dave Ertman
2020-10-23  0:33 ` [PATCH v3 03/10] ASoC: SOF: Create client driver for IPC test Dave Ertman
2020-10-23  0:33   ` Dave Ertman
2020-10-23  0:33 ` [PATCH v3 04/10] ASoC: SOF: ops: Add ops for client registration Dave Ertman
2020-10-23  0:33   ` Dave Ertman
2020-10-23  0:33 ` [PATCH v3 05/10] ASoC: SOF: Intel: Define " Dave Ertman
2020-10-23  0:33   ` Dave Ertman
2020-10-23  0:33 ` [PATCH v3 06/10] ASoC: SOF: Intel: Remove IPC flood test support in SOF core Dave Ertman
2020-10-23  0:33   ` Dave Ertman
2020-10-23  0:33 ` [PATCH v3 07/10] ASoC: SOF: sof-client: Add client APIs to access probes ops Dave Ertman
2020-10-23  0:33   ` Dave Ertman
2020-10-23  0:33 ` [PATCH v3 08/10] ASoC: SOF: compress: move and export sof_probe_compr_ops Dave Ertman
2020-10-23  0:33   ` Dave Ertman
2020-10-23  0:33 ` [PATCH v3 09/10] ASoC: SOF: Add new client driver for probes support Dave Ertman
2020-10-23  0:33   ` Dave Ertman
2020-10-23  0:33 ` [PATCH v3 10/10] ASoC: SOF: Intel: CNL: register probes client Dave Ertman
2020-10-23  0:33   ` Dave Ertman
2020-10-23  6:49 ` [PATCH v3 00/10] Auxiliary bus implementation and SOF multi-client support Leon Romanovsky
2020-10-23  6:56   ` Greg KH
2020-10-23  6:56     ` Greg KH
2020-10-23 15:48     ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201105094719.GQ5429@unreal \
    --to=leonro@nvidia.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=davem@davemloft.net \
    --cc=david.m.ertman@intel.com \
    --cc=dledford@redhat.com \
    --cc=fred.oh@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jgg@nvidia.com \
    --cc=kiran.patil@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=parav@mellanox.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=shiraz.saleem@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.