All of lore.kernel.org
 help / color / mirror / Atom feed
From: Deepak R Varma <mh12gx2825@gmail.com>
To: David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: mh12gx2825@gmail.com
Subject: Re: [PATCH] drm/vgm: replace idr_init() by idr_init_base()
Date: Thu, 5 Nov 2020 16:01:16 +0530	[thread overview]
Message-ID: <20201105103116.GA29881@localhost> (raw)
In-Reply-To: <20201105094215.GT401619@phenom.ffwll.local>

On Thu, Nov 05, 2020 at 10:42:15AM +0100, Daniel Vetter wrote:
> On Wed, Nov 04, 2020 at 04:53:38PM +0530, Deepak R Varma wrote:
> > idr_init() uses base 0 which is an invalid identifier. The new function
> > idr_init_base allows IDR to set the ID lookup from base 1. This avoids
> > all lookups that otherwise starts from 0 since 0 is always unused.
> > 
> > References: commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient")
> > 
> > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> 
> Tiny typo in the commit message summary: s/vgm/vgem/
> 
> Also can you pls resbumit this with intel-gfx mailing list on cc (like for
> i915)? There's a CI bot there which runs a few vgem tests, would be good
> to confirm nothing has been broken.

Hi Daniel,
sure. I will correct the summary typo and also feed it to the CI bot.

Also, according to Felix Kuehling's comment on a similar patch for
drm/amdkfd driver, an ID can be 0. The change I am proposing is more
efficient for conditions that do not want to use ID as 0. Otherwise,
id = 0 is an acceptable possibility. So, my statement that "Id 0 is an invalid
identifier" is not true.

Can you please comment if this is accurate and I should reword my log
message as well?

Thank you.
./drv

> 
> Otherwise lgtm.
> 
> Thanks, Daniel
> 
> > ---
> >  drivers/gpu/drm/vgem/vgem_fence.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/vgem/vgem_fence.c b/drivers/gpu/drm/vgem/vgem_fence.c
> > index 17f32f550dd9..2902dc6e64fa 100644
> > --- a/drivers/gpu/drm/vgem/vgem_fence.c
> > +++ b/drivers/gpu/drm/vgem/vgem_fence.c
> > @@ -233,7 +233,7 @@ int vgem_fence_signal_ioctl(struct drm_device *dev,
> >  int vgem_fence_open(struct vgem_file *vfile)
> >  {
> >  	mutex_init(&vfile->fence_mutex);
> > -	idr_init(&vfile->fence_idr);
> > +	idr_init_base(&vfile->fence_idr, 1);
> >  
> >  	return 0;
> >  }
> > -- 
> > 2.25.1
> > 
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Deepak R Varma <mh12gx2825@gmail.com>
To: David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: daniel@ffwll.ch, mh12gx2825@gmail.com
Subject: Re: [PATCH] drm/vgm: replace idr_init() by idr_init_base()
Date: Thu, 5 Nov 2020 16:01:16 +0530	[thread overview]
Message-ID: <20201105103116.GA29881@localhost> (raw)
In-Reply-To: <20201105094215.GT401619@phenom.ffwll.local>

On Thu, Nov 05, 2020 at 10:42:15AM +0100, Daniel Vetter wrote:
> On Wed, Nov 04, 2020 at 04:53:38PM +0530, Deepak R Varma wrote:
> > idr_init() uses base 0 which is an invalid identifier. The new function
> > idr_init_base allows IDR to set the ID lookup from base 1. This avoids
> > all lookups that otherwise starts from 0 since 0 is always unused.
> > 
> > References: commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient")
> > 
> > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> 
> Tiny typo in the commit message summary: s/vgm/vgem/
> 
> Also can you pls resbumit this with intel-gfx mailing list on cc (like for
> i915)? There's a CI bot there which runs a few vgem tests, would be good
> to confirm nothing has been broken.

Hi Daniel,
sure. I will correct the summary typo and also feed it to the CI bot.

Also, according to Felix Kuehling's comment on a similar patch for
drm/amdkfd driver, an ID can be 0. The change I am proposing is more
efficient for conditions that do not want to use ID as 0. Otherwise,
id = 0 is an acceptable possibility. So, my statement that "Id 0 is an invalid
identifier" is not true.

Can you please comment if this is accurate and I should reword my log
message as well?

Thank you.
./drv

> 
> Otherwise lgtm.
> 
> Thanks, Daniel
> 
> > ---
> >  drivers/gpu/drm/vgem/vgem_fence.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/vgem/vgem_fence.c b/drivers/gpu/drm/vgem/vgem_fence.c
> > index 17f32f550dd9..2902dc6e64fa 100644
> > --- a/drivers/gpu/drm/vgem/vgem_fence.c
> > +++ b/drivers/gpu/drm/vgem/vgem_fence.c
> > @@ -233,7 +233,7 @@ int vgem_fence_signal_ioctl(struct drm_device *dev,
> >  int vgem_fence_open(struct vgem_file *vfile)
> >  {
> >  	mutex_init(&vfile->fence_mutex);
> > -	idr_init(&vfile->fence_idr);
> > +	idr_init_base(&vfile->fence_idr, 1);
> >  
> >  	return 0;
> >  }
> > -- 
> > 2.25.1
> > 
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

  reply	other threads:[~2020-11-06  8:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-04 11:23 [PATCH] drm/vgm: replace idr_init() by idr_init_base() Deepak R Varma
2020-11-04 11:23 ` Deepak R Varma
2020-11-05  9:42 ` Daniel Vetter
2020-11-05  9:42   ` Daniel Vetter
2020-11-05 10:31   ` Deepak R Varma [this message]
2020-11-05 10:31     ` Deepak R Varma
2020-11-05 11:16     ` Daniel Vetter
2020-11-05 11:16       ` Daniel Vetter
2020-11-05 17:40       ` Deepak R Varma
2020-11-05 17:40         ` Deepak R Varma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201105103116.GA29881@localhost \
    --to=mh12gx2825@gmail.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.