All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Thirumalesha N <nthirumalesha7@gmail.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	Richard Weinberger <richard@nod.at>,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Chuanhong Guo <gch981213@gmail.com>,
	Shivamurthy Shastri <sshivamurthy@micron.com>
Subject: Re: [PATCH v5] mtd: spinand: micron: add support for MT29F2G01AAAED
Date: Thu, 5 Nov 2020 15:44:21 +0100	[thread overview]
Message-ID: <20201105154421.686e0675@collabora.com> (raw)
In-Reply-To: <CALKVOUrf6J8Ke-fqv8SuTGMdWf+FDD8yK2RmZ2AtT9KUrJE_Xg@mail.gmail.com>

On Tue, 3 Nov 2020 23:18:54 +0800
Thirumalesha N <nthirumalesha7@gmail.com> wrote:

> Hi Boris,
> 
> On Tue, Nov 3, 2020 at 11:03 PM Boris Brezillon <
> boris.brezillon@collabora.com> wrote:  
> 
> > On Tue,  3 Nov 2020 22:59:01 +0800
> > Thirumalesha Narasimhappa <nthirumalesha7@gmail.com> wrote:
> >  
> > > The MT29F2G01AAAED is a single die, 2Gb Micron SPI NAND Flash with 4-bit
> > > ECC
> > >
> > > Signed-off-by: Thirumalesha Narasimhappa <nthirumalesha7@gmail.com>
> > > ---
> > >
> > > v5: As per the review comments, the changes were reverted to the v2,
> > > except the MT29F2G01AAAED device related (including the review comments)  
> >
> > I don't think that's what Miquel suggested, especially not for the
> > {write,update,write}_cache_variants helpers.
> >  
> 
> 
> I was a bit confused with the multiple levels of comments with the previous
> patch and I renamed *{write,update,write}_cache_var**iants* to *micron_4_**
> to avoid function redefinition.
> Please can you direct me with this patch, what needs to be modified/renamed
> ?

Keep the SPINAND_OP_VARIANTS() as they were in v4 and use the micron_4_
prefix for ECC related stuff.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Thirumalesha N <nthirumalesha7@gmail.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Shivamurthy Shastri <sshivamurthy@micron.com>,
	Chuanhong Guo <gch981213@gmail.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] mtd: spinand: micron: add support for MT29F2G01AAAED
Date: Thu, 5 Nov 2020 15:44:21 +0100	[thread overview]
Message-ID: <20201105154421.686e0675@collabora.com> (raw)
In-Reply-To: <CALKVOUrf6J8Ke-fqv8SuTGMdWf+FDD8yK2RmZ2AtT9KUrJE_Xg@mail.gmail.com>

On Tue, 3 Nov 2020 23:18:54 +0800
Thirumalesha N <nthirumalesha7@gmail.com> wrote:

> Hi Boris,
> 
> On Tue, Nov 3, 2020 at 11:03 PM Boris Brezillon <
> boris.brezillon@collabora.com> wrote:  
> 
> > On Tue,  3 Nov 2020 22:59:01 +0800
> > Thirumalesha Narasimhappa <nthirumalesha7@gmail.com> wrote:
> >  
> > > The MT29F2G01AAAED is a single die, 2Gb Micron SPI NAND Flash with 4-bit
> > > ECC
> > >
> > > Signed-off-by: Thirumalesha Narasimhappa <nthirumalesha7@gmail.com>
> > > ---
> > >
> > > v5: As per the review comments, the changes were reverted to the v2,
> > > except the MT29F2G01AAAED device related (including the review comments)  
> >
> > I don't think that's what Miquel suggested, especially not for the
> > {write,update,write}_cache_variants helpers.
> >  
> 
> 
> I was a bit confused with the multiple levels of comments with the previous
> patch and I renamed *{write,update,write}_cache_var**iants* to *micron_4_**
> to avoid function redefinition.
> Please can you direct me with this patch, what needs to be modified/renamed
> ?

Keep the SPINAND_OP_VARIANTS() as they were in v4 and use the micron_4_
prefix for ECC related stuff.

  parent reply	other threads:[~2020-11-05 14:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03 14:59 [PATCH v5] mtd: spinand: micron: add support for MT29F2G01AAAED Thirumalesha Narasimhappa
2020-11-03 14:59 ` Thirumalesha Narasimhappa
2020-11-03 15:03 ` Boris Brezillon
2020-11-03 15:03   ` Boris Brezillon
     [not found]   ` <CALKVOUrf6J8Ke-fqv8SuTGMdWf+FDD8yK2RmZ2AtT9KUrJE_Xg@mail.gmail.com>
2020-11-05 14:44     ` Boris Brezillon [this message]
2020-11-05 14:44       ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201105154421.686e0675@collabora.com \
    --to=boris.brezillon@collabora.com \
    --cc=gch981213@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=nthirumalesha7@gmail.com \
    --cc=richard@nod.at \
    --cc=sshivamurthy@micron.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.