All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Zhu Yanjun <yanjunz@nvidia.com>,
	Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
	linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org,
	Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
	iommu@lists.linux-foundation.org,
	Bjorn Helgaas <bhelgaas@google.com>,
	Bernard Metzler <bmt@zurich.ibm.com>,
	Logan Gunthorpe <logang@deltatee.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 3/6] RDMA/core: remove use of dma_virt_ops
Date: Fri, 6 Nov 2020 15:18:43 +0100	[thread overview]
Message-ID: <20201106141843.GD23884@lst.de> (raw)
In-Reply-To: <20201105175816.GH36674@ziepe.ca>

On Thu, Nov 05, 2020 at 01:58:16PM -0400, Jason Gunthorpe wrote:
> > I noticed there were a couple of places expecting dma_device to be set
> > to !NULL:
> > 
> > drivers/infiniband/core/umem.c:                 dma_get_max_seg_size(device->dma_device), sg, npages,
> > drivers/nvme/host/rdma.c:       ctrl->ctrl.numa_node = dev_to_node(ctrl->device->dev->dma_device);
> 
> Don't know much about NUMA, but do you think the ib device setup
> should autocopy the numa node from the dma_device to the ib_device and
> this usage should just refer to the ib_device?

FYI, I ended up just lifting the ibdev_to_node from rds to ib_verbs.h.  That uses
the parent pointer in the ib_device and should generally work ok.  If not we can
improve іt as we now have a proper abstraction.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Christoph Hellwig <hch@lst.de>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Bernard Metzler <bmt@zurich.ibm.com>,
	Zhu Yanjun <yanjunz@nvidia.com>,
	Logan Gunthorpe <logang@deltatee.com>,
	Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
	Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
	linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org,
	iommu@lists.linux-foundation.org
Subject: Re: [PATCH 3/6] RDMA/core: remove use of dma_virt_ops
Date: Fri, 6 Nov 2020 15:18:43 +0100	[thread overview]
Message-ID: <20201106141843.GD23884@lst.de> (raw)
In-Reply-To: <20201105175816.GH36674@ziepe.ca>

On Thu, Nov 05, 2020 at 01:58:16PM -0400, Jason Gunthorpe wrote:
> > I noticed there were a couple of places expecting dma_device to be set
> > to !NULL:
> > 
> > drivers/infiniband/core/umem.c:                 dma_get_max_seg_size(device->dma_device), sg, npages,
> > drivers/nvme/host/rdma.c:       ctrl->ctrl.numa_node = dev_to_node(ctrl->device->dev->dma_device);
> 
> Don't know much about NUMA, but do you think the ib device setup
> should autocopy the numa node from the dma_device to the ib_device and
> this usage should just refer to the ib_device?

FYI, I ended up just lifting the ibdev_to_node from rds to ib_verbs.h.  That uses
the parent pointer in the ib_device and should generally work ok.  If not we can
improve іt as we now have a proper abstraction.

  reply	other threads:[~2020-11-06 14:18 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-05  7:41 remove dma_virt_ops v2 Christoph Hellwig
2020-11-05  7:41 ` Christoph Hellwig
2020-11-05  7:42 ` [PATCH 1/6] RMDA/sw: don't allow drivers using dma_virt_ops on highmem configs Christoph Hellwig
2020-11-05  7:42   ` Christoph Hellwig
2020-11-05 12:15   ` Robin Murphy
2020-11-05 12:15     ` Robin Murphy
2020-11-05 17:00     ` Christoph Hellwig
2020-11-05 17:00       ` Christoph Hellwig
2020-11-05 14:41   ` Jason Gunthorpe
2020-11-05 14:41     ` Jason Gunthorpe
2020-11-05 15:29     ` Robin Murphy
2020-11-05 15:29       ` Robin Murphy
2020-11-05 17:03       ` Christoph Hellwig
2020-11-05 17:03         ` Christoph Hellwig
2020-11-05 20:32   ` Bernard Metzler
2020-11-05 20:32     ` Bernard Metzler
2020-11-05  7:42 ` [PATCH 2/6] RDMA/core: remove ib_dma_{alloc,free}_coherent Christoph Hellwig
2020-11-05  7:42   ` Christoph Hellwig
2020-11-05  7:42 ` [PATCH 3/6] RDMA/core: remove use of dma_virt_ops Christoph Hellwig
2020-11-05  7:42   ` Christoph Hellwig
2020-11-05 14:34   ` Jason Gunthorpe
2020-11-05 14:34     ` Jason Gunthorpe
2020-11-05 17:09     ` Christoph Hellwig
2020-11-05 17:09       ` Christoph Hellwig
2020-11-05 17:52   ` Jason Gunthorpe
2020-11-05 17:52     ` Jason Gunthorpe
2020-11-05 17:58     ` Jason Gunthorpe
2020-11-05 17:58       ` Jason Gunthorpe
2020-11-06 14:18       ` Christoph Hellwig [this message]
2020-11-06 14:18         ` Christoph Hellwig
2020-11-06 10:01     ` Christoph Hellwig
2020-11-06 10:01       ` Christoph Hellwig
2020-11-05  7:42 ` [PATCH 4/6] PCI/P2PDMA: Remove the DMA_VIRT_OPS hacks Christoph Hellwig
2020-11-05  7:42   ` Christoph Hellwig
2020-11-05 14:34   ` Jason Gunthorpe
2020-11-05 14:34     ` Jason Gunthorpe
2020-11-05 17:08     ` Christoph Hellwig
2020-11-05 17:08       ` Christoph Hellwig
2020-11-05 17:23       ` Jason Gunthorpe
2020-11-05 17:23         ` Jason Gunthorpe
2020-11-05 17:29         ` Christoph Hellwig
2020-11-05 17:29           ` Christoph Hellwig
2020-11-05 17:39           ` Jason Gunthorpe
2020-11-05 17:39             ` Jason Gunthorpe
2020-11-05 17:43             ` Christoph Hellwig
2020-11-05 17:43               ` Christoph Hellwig
2020-11-05 17:56               ` Jason Gunthorpe
2020-11-05 17:56                 ` Jason Gunthorpe
2020-11-05  7:42 ` [PATCH 5/6] PCI/P2PDMA: Cleanup __pci_p2pdma_map_sg a bit Christoph Hellwig
2020-11-05  7:42   ` Christoph Hellwig
2020-11-05  7:42 ` [PATCH 6/6] dma-mapping: remove dma_virt_ops Christoph Hellwig
2020-11-05  7:42   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201106141843.GD23884@lst.de \
    --to=hch@lst.de \
    --cc=bhelgaas@google.com \
    --cc=bmt@zurich.ibm.com \
    --cc=dennis.dalessandro@cornelisnetworks.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=mike.marciniszyn@cornelisnetworks.com \
    --cc=yanjunz@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.