* [PATCH] ath11k: Fix single phy hw mode
@ 2020-11-04 17:35 ` Karthikeyan Periyasamy
0 siblings, 0 replies; 4+ messages in thread
From: Karthikeyan Periyasamy @ 2020-11-04 17:35 UTC (permalink / raw)
To: ath11k; +Cc: Karthikeyan Periyasamy, linux-wireless
driver not able to bootup in the single radio configured board.
single phy hw mode is converted to invalid hw mode and sent to FW
through wmi init cmd. In that case driver is not receiving wmi
ready event which leads to driver bootup fail. single phy hw mode
is a valid for single radio configured board. so removed the
conversion logic.
Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.1.0.1-01238-QCAHKSWPL_SILICONZ-2
Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/wmi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
index 6e17373..1f0c517 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.c
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
@@ -3351,9 +3351,6 @@ int ath11k_wmi_cmd_init(struct ath11k_base *ab)
init_param.hw_mode_id = wmi_sc->preferred_hw_mode;
init_param.mem_chunks = wmi_sc->mem_chunks;
- if (wmi_sc->preferred_hw_mode == WMI_HOST_HW_MODE_SINGLE)
- init_param.hw_mode_id = WMI_HOST_HW_MODE_MAX;
-
if (ab->hw_params.needs_band_to_mac) {
init_param.num_band_to_mac = ab->num_radios;
ath11k_fill_band_to_mac_param(ab, init_param.band_to_mac);
--
2.7.4
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ath11k: Fix single phy hw mode
@ 2020-11-04 17:35 ` Karthikeyan Periyasamy
0 siblings, 0 replies; 4+ messages in thread
From: Karthikeyan Periyasamy @ 2020-11-04 17:35 UTC (permalink / raw)
To: ath11k; +Cc: linux-wireless, Karthikeyan Periyasamy
driver not able to bootup in the single radio configured board.
single phy hw mode is converted to invalid hw mode and sent to FW
through wmi init cmd. In that case driver is not receiving wmi
ready event which leads to driver bootup fail. single phy hw mode
is a valid for single radio configured board. so removed the
conversion logic.
Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.1.0.1-01238-QCAHKSWPL_SILICONZ-2
Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/wmi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
index 6e17373..1f0c517 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.c
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
@@ -3351,9 +3351,6 @@ int ath11k_wmi_cmd_init(struct ath11k_base *ab)
init_param.hw_mode_id = wmi_sc->preferred_hw_mode;
init_param.mem_chunks = wmi_sc->mem_chunks;
- if (wmi_sc->preferred_hw_mode == WMI_HOST_HW_MODE_SINGLE)
- init_param.hw_mode_id = WMI_HOST_HW_MODE_MAX;
-
if (ab->hw_params.needs_band_to_mac) {
init_param.num_band_to_mac = ab->num_radios;
ath11k_fill_band_to_mac_param(ab, init_param.band_to_mac);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ath11k: Fix single phy hw mode
2020-11-04 17:35 ` Karthikeyan Periyasamy
(?)
@ 2020-11-07 8:04 ` Kalle Valo
-1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-11-07 8:04 UTC (permalink / raw)
To: Karthikeyan Periyasamy; +Cc: linux-wireless, ath11k
Karthikeyan Periyasamy <periyasa@codeaurora.org> wrote:
> driver not able to bootup in the single radio configured board.
> single phy hw mode is converted to invalid hw mode and sent to FW
> through wmi init cmd. In that case driver is not receiving wmi
> ready event which leads to driver bootup fail. single phy hw mode
> is a valid for single radio configured board. so removed the
> conversion logic.
>
> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.1.0.1-01238-QCAHKSWPL_SILICONZ-2
>
> Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
9fb13b81e145 ath11k: Fix single phy hw mode
--
https://patchwork.kernel.org/project/linux-wireless/patch/1604511331-22477-1-git-send-email-periyasa@codeaurora.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ath11k: Fix single phy hw mode
2020-11-04 17:35 ` Karthikeyan Periyasamy
(?)
(?)
@ 2020-11-07 8:04 ` Kalle Valo
-1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-11-07 8:04 UTC (permalink / raw)
To: Karthikeyan Periyasamy; +Cc: ath11k, linux-wireless, Karthikeyan Periyasamy
Karthikeyan Periyasamy <periyasa@codeaurora.org> wrote:
> driver not able to bootup in the single radio configured board.
> single phy hw mode is converted to invalid hw mode and sent to FW
> through wmi init cmd. In that case driver is not receiving wmi
> ready event which leads to driver bootup fail. single phy hw mode
> is a valid for single radio configured board. so removed the
> conversion logic.
>
> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.1.0.1-01238-QCAHKSWPL_SILICONZ-2
>
> Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
9fb13b81e145 ath11k: Fix single phy hw mode
--
https://patchwork.kernel.org/project/linux-wireless/patch/1604511331-22477-1-git-send-email-periyasa@codeaurora.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-07 8:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-04 17:35 [PATCH] ath11k: Fix single phy hw mode Karthikeyan Periyasamy
2020-11-04 17:35 ` Karthikeyan Periyasamy
2020-11-07 8:04 ` Kalle Valo
2020-11-07 8:04 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.