[tip: perf/kprobes] locking/atomics: Regenerate the atomics-check SHA1's

[tip: perf/kprobes] locking/atomics: Regenerate the atomics-check SHA1's

[tip-bot2 for Ingo Molnar]

The following commit has been merged into the perf/kprobes branch of tip:

Commit-ID:     a70a04b3844f59c29573a8581d5c263225060dd6
Gitweb:        https://git.kernel.org/tip/a70a04b3844f59c29573a8581d5c263225060dd6
Author:        Ingo Molnar <mingo@kernel.org>
AuthorDate:    Sat, 07 Nov 2020 12:54:49 +01:00
Committer:     Ingo Molnar <mingo@kernel.org>
CommitterDate: Sat, 07 Nov 2020 13:20:41 +01:00

locking/atomics: Regenerate the atomics-check SHA1's

The include/asm-generic/atomic-instrumented.h checksum got out
of sync, so regenerate it. (No change to actual code.)

Also make scripts/atomic/gen-atomics.sh executable, to make
it easier to use.

The auto-generated atomic header signatures are now fine:

  thule:~/tip> scripts/atomic/check-atomics.sh
  thule:~/tip>

Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Paul E. McKenney <paulmck@kernel.org>
Cc: Will Deacon <will.deacon@arm.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 include/asm-generic/atomic-instrumented.h | 2 +-
 scripts/atomic/gen-atomics.sh             | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 mode change 100644 => 100755 scripts/atomic/gen-atomics.sh

diff --git a/include/asm-generic/atomic-instrumented.h b/include/asm-generic/atomic-instrumented.h
index 492cc95..888b6cf 100644
--- a/include/asm-generic/atomic-instrumented.h
+++ b/include/asm-generic/atomic-instrumented.h
@@ -1830,4 +1830,4 @@ atomic64_dec_if_positive(atomic64_t *v)
 })
 
 #endif /* _ASM_GENERIC_ATOMIC_INSTRUMENTED_H */
-// 9d5e6a315fb1335d02f0ccd3655a91c3dafcc63e
+// 4bec382e44520f4d8267e42620054db26a659ea3
diff --git a/scripts/atomic/gen-atomics.sh b/scripts/atomic/gen-atomics.sh
old mode 100644
new mode 100755

Re: [tip: perf/kprobes] locking/atomics: Regenerate the atomics-check SHA1's

[Borislav Petkov]

On Sat, Nov 07, 2020 at 03:13:58PM -0000, tip-bot2 for Ingo Molnar wrote:
> The following commit has been merged into the perf/kprobes branch of tip:
> 
> Commit-ID:     a70a04b3844f59c29573a8581d5c263225060dd6
> Gitweb:        https://git.kernel.org/tip/a70a04b3844f59c29573a8581d5c263225060dd6
> Author:        Ingo Molnar <mingo@kernel.org>
> AuthorDate:    Sat, 07 Nov 2020 12:54:49 +01:00
> Committer:     Ingo Molnar <mingo@kernel.org>
> CommitterDate: Sat, 07 Nov 2020 13:20:41 +01:00
> 
> locking/atomics: Regenerate the atomics-check SHA1's
> 
> The include/asm-generic/atomic-instrumented.h checksum got out
> of sync, so regenerate it. (No change to actual code.)
> 
> Also make scripts/atomic/gen-atomics.sh executable, to make
> it easier to use.
> 
> The auto-generated atomic header signatures are now fine:
> 
>   thule:~/tip> scripts/atomic/check-atomics.sh
>   thule:~/tip>
> 
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
> Cc: linux-kernel@vger.kernel.org
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Paul E. McKenney <paulmck@kernel.org>
> Cc: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
> ---
>  include/asm-generic/atomic-instrumented.h | 2 +-
>  scripts/atomic/gen-atomics.sh             | 0
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  mode change 100644 => 100755 scripts/atomic/gen-atomics.sh
		^^^^^^^^^^^^^^^

That looks like it snuck in but it shouldn't have...

> diff --git a/scripts/atomic/gen-atomics.sh b/scripts/atomic/gen-atomics.sh
> old mode 100644
> new mode 100755

... here too.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Re: [tip: perf/kprobes] locking/atomics: Regenerate the atomics-check SHA1's

[Ingo Molnar]

* Borislav Petkov <bp@alien8.de> wrote:

> On Sat, Nov 07, 2020 at 03:13:58PM -0000, tip-bot2 for Ingo Molnar wrote:
> > The following commit has been merged into the perf/kprobes branch of tip:
> > 
> > Commit-ID:     a70a04b3844f59c29573a8581d5c263225060dd6
> > Gitweb:        https://git.kernel.org/tip/a70a04b3844f59c29573a8581d5c263225060dd6
> > Author:        Ingo Molnar <mingo@kernel.org>
> > AuthorDate:    Sat, 07 Nov 2020 12:54:49 +01:00
> > Committer:     Ingo Molnar <mingo@kernel.org>
> > CommitterDate: Sat, 07 Nov 2020 13:20:41 +01:00
> > 
> > locking/atomics: Regenerate the atomics-check SHA1's
> > 
> > The include/asm-generic/atomic-instrumented.h checksum got out
> > of sync, so regenerate it. (No change to actual code.)
> > 
> > Also make scripts/atomic/gen-atomics.sh executable, to make
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > it easier to use.
    ^^^^^^^^^^^^^^^^^

> >  mode change 100644 => 100755 scripts/atomic/gen-atomics.sh
> 		^^^^^^^^^^^^^^^
> 
> That looks like it snuck in but it shouldn't have...

So that mode change to executable was intentional, as mentioned in the 
changelog.

Or did I miss something?

Thanks,

	Ingo

Re: [tip: perf/kprobes] locking/atomics: Regenerate the atomics-check SHA1's

[Borislav Petkov]

On Sun, Nov 08, 2020 at 10:05:21AM +0100, Ingo Molnar wrote:
> So that mode change to executable was intentional, as mentioned in the 
> changelog.

Yeah, I thought we don't make them executable in the tree but I guess we
do, at least most of them, from looking at git ls-files *.sh output.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Re: [tip: perf/kprobes] locking/atomics: Regenerate the atomics-check SHA1's

[Linus Torvalds]

On Sun, Nov 8, 2020 at 1:23 AM Borislav Petkov <bp@alien8.de> wrote:
>
> On Sun, Nov 08, 2020 at 10:05:21AM +0100, Ingo Molnar wrote:
> > So that mode change to executable was intentional, as mentioned in the
> > changelog.
>
> Yeah, I thought we don't make them executable in the tree but I guess we
> do, at least most of them, from looking at git ls-files *.sh output.

We do try mark scripts executable, but you may have been misled by the
fact that we then try to avoid _depending_ on that during the build.

That's mostly because some people still use old workflows with
patches, and the executable bit will be lost if you apply a patch
without the proper git tools.

(I think we've also had cases where people were developing on no-exec
filesystems etc).

So while we try to mark scripts executable, we then actually generally
execute them using an explicit interpreter invocation anyway (ie using

  $(CONFIG_SHELL) "some-script-path"

or similar).

              Linus

Re: [tip: perf/kprobes] locking/atomics: Regenerate the atomics-check SHA1's

[Borislav Petkov]

On Sun, Nov 08, 2020 at 09:35:38AM -0800, Linus Torvalds wrote:
> So while we try to mark scripts executable, we then actually generally
> execute them using an explicit interpreter invocation anyway (ie using
>
>   $(CONFIG_SHELL) "some-script-path"
>
> or similar).

Thanks for explaining!

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette