From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Balbir Singh <bsingharora@gmail.com>, Tom Rix <trix@redhat.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
clang-built-linux@googlegroups.com,
kernel-janitors@vger.kernel.org, linux-safety@lists.elisa.tech,
linux-kernel@vger.kernel.org
Subject: Re: [linux-safety] [PATCH] taskstats: remove unneeded dead assignment
Date: Tue, 10 Nov 2020 08:06:09 +0000 [thread overview]
Message-ID: <20201110080609.GD29398@kadam> (raw)
In-Reply-To: <aea9d12d-88ee-f262-4328-03993521668f@codethink.co.uk>
On Fri, Nov 06, 2020 at 12:04:53PM +0000, Sudip Mukherjee wrote:
> Hi Lukas,
>
> On 06/11/2020 10:31, Lukas Bulwahn wrote:
> >
> >
> > On Fri, 6 Nov 2020, Sudip Mukherjee wrote:
> >
> >> Hi Lukas,
> >>
>
> <snip>
>
> >
> > I did not try but I bet (a beverage of your choice) that the object code
> > remains the same also for your suggested patch. Try to disprove my claim
> > and possibly earn yourself a beverage when we meet...
>
> Lets decide which beverage.. ;-)
>
> Using gcc-7.2.0 for MIPS:
>
> original:- ab81d3305d578c2568fbc73aad2f9e61 kernel/taskstats.o
> After your change:- ab81d3305d578c2568fbc73aad2f9e61 kernel/taskstats.o
> After my change:- 0acae2c8d72abd3e15bf805fccdca711 kernel/taskstats.o
I'm surprised the line numbers from the printks aren't affecting it...
I personally prefer Lukas's patch. "rc" should be function scope...
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Balbir Singh <bsingharora@gmail.com>, Tom Rix <trix@redhat.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
clang-built-linux@googlegroups.com,
kernel-janitors@vger.kernel.org, linux-safety@lists.elisa.tech,
linux-kernel@vger.kernel.org
Subject: Re: [linux-safety] [PATCH] taskstats: remove unneeded dead assignment
Date: Tue, 10 Nov 2020 11:06:09 +0300 [thread overview]
Message-ID: <20201110080609.GD29398@kadam> (raw)
In-Reply-To: <aea9d12d-88ee-f262-4328-03993521668f@codethink.co.uk>
On Fri, Nov 06, 2020 at 12:04:53PM +0000, Sudip Mukherjee wrote:
> Hi Lukas,
>
> On 06/11/2020 10:31, Lukas Bulwahn wrote:
> >
> >
> > On Fri, 6 Nov 2020, Sudip Mukherjee wrote:
> >
> >> Hi Lukas,
> >>
>
> <snip>
>
> >
> > I did not try but I bet (a beverage of your choice) that the object code
> > remains the same also for your suggested patch. Try to disprove my claim
> > and possibly earn yourself a beverage when we meet...
>
> Lets decide which beverage.. ;-)
>
> Using gcc-7.2.0 for MIPS:
>
> original:- ab81d3305d578c2568fbc73aad2f9e61 kernel/taskstats.o
> After your change:- ab81d3305d578c2568fbc73aad2f9e61 kernel/taskstats.o
> After my change:- 0acae2c8d72abd3e15bf805fccdca711 kernel/taskstats.o
I'm surprised the line numbers from the printks aren't affecting it...
I personally prefer Lukas's patch. "rc" should be function scope...
regards,
dan carpenter
next prev parent reply other threads:[~2020-11-10 8:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 6:22 [PATCH] taskstats: remove unneeded dead assignment Lukas Bulwahn
2020-11-06 6:22 ` Lukas Bulwahn
2020-11-06 9:50 ` Nathan Chancellor
2020-11-06 9:50 ` Nathan Chancellor
2020-11-06 10:23 ` Lukas Bulwahn
2020-11-06 10:23 ` Lukas Bulwahn
2020-11-06 10:47 ` Lukas Bulwahn
2020-11-06 10:47 ` Lukas Bulwahn
2020-11-06 10:25 ` [linux-safety] " Sudip Mukherjee
2020-11-06 10:25 ` Sudip Mukherjee
2020-11-06 10:31 ` Lukas Bulwahn
2020-11-06 10:31 ` Lukas Bulwahn
2020-11-06 12:04 ` Sudip Mukherjee
2020-11-06 12:04 ` Sudip Mukherjee
2020-11-06 12:38 ` Lukas Bulwahn
2020-11-06 12:38 ` Lukas Bulwahn
2020-11-06 12:38 ` Lukas Bulwahn
2020-11-10 8:06 ` Dan Carpenter [this message]
2020-11-10 8:06 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110080609.GD29398@kadam \
--to=dan.carpenter@oracle.com \
--cc=bsingharora@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-safety@lists.elisa.tech \
--cc=lukas.bulwahn@gmail.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=sudip.mukherjee@codethink.co.uk \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.