From: Michael Tretter <m.tretter@pengutronix.de>
To: Adam Ford <aford173@gmail.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
linux-samsung-soc@vger.kernel.org, jy0922.shim@samsung.com,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
sw0312.kim@samsung.com, Krzysztof Kozlowski <krzk@kernel.org>,
a.hajda@samsung.com,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sascha Hauer <kernel@pengutronix.de>,
sylvester.nawrocki@gmail.com
Subject: Re: [PATCH v2 01/16] drm/encoder: remove obsolete documentation of bridge
Date: Tue, 10 Nov 2020 09:46:01 +0100 [thread overview]
Message-ID: <20201110084601.GD13669@pengutronix.de> (raw)
In-Reply-To: <CAHCN7xKAHm0cvh+7rb1wxF+UqE2Fs48nYF7=rWm7E9ipy2Jtmw@mail.gmail.com>
On Sat, 07 Nov 2020 09:07:19 -0600, Adam Ford wrote:
> On Fri, Sep 11, 2020 at 8:54 AM Michael Tretter
> <m.tretter@pengutronix.de> wrote:
> >
> > In commit 05193dc38197 ("drm/bridge: Make the bridge chain a
> > double-linked list") the bridge has been removed and replaced by a
> > private field. Remove the leftover documentation of the removed field.
> >
> > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> What is the status of this series? I know of at least one other patch
> series depending on this.
Sorry for that. I lately didn't have time to work on the series.
There are two big open TODOs:
- How should this bridge react if there is no out bridge available, yet? This
series implements a static approach by returning EPROBE_DEFER from
bridge_attach if there isn't a next bridge, connector or display. Andrezej
suggested a dynamic approach which allows to attach this bridge without a
next bridge and dynamically add further bridges/panels. The latter approach
didn't work with the mxsfb driver, but I didn't have time to look into this.
- The component framework stuff that allows to use the bridge with the Exynos
driver should not go into the bridge driver, but stay in the platform part.
Michael
>
> adam
>
> > ---
> > v2: none
> > ---
> > include/drm/drm_encoder.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/include/drm/drm_encoder.h b/include/drm/drm_encoder.h
> > index a60f5f1555ac..5dfa5f7a80a7 100644
> > --- a/include/drm/drm_encoder.h
> > +++ b/include/drm/drm_encoder.h
> > @@ -89,7 +89,6 @@ struct drm_encoder_funcs {
> > * @head: list management
> > * @base: base KMS object
> > * @name: human readable name, can be overwritten by the driver
> > - * @bridge: bridge associated to the encoder
> > * @funcs: control functions
> > * @helper_private: mid-layer private data
> > *
> > --
> > 2.20.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
WARNING: multiple messages have this Message-ID (diff)
From: Michael Tretter <m.tretter@pengutronix.de>
To: Adam Ford <aford173@gmail.com>
Cc: linux-samsung-soc@vger.kernel.org, jy0922.shim@samsung.com,
Neil Armstrong <narmstrong@baylibre.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
sw0312.kim@samsung.com,
dri-devel <dri-devel@lists.freedesktop.org>,
a.hajda@samsung.com, Krzysztof Kozlowski <krzk@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
sylvester.nawrocki@gmail.com,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v2 01/16] drm/encoder: remove obsolete documentation of bridge
Date: Tue, 10 Nov 2020 09:46:01 +0100 [thread overview]
Message-ID: <20201110084601.GD13669@pengutronix.de> (raw)
In-Reply-To: <CAHCN7xKAHm0cvh+7rb1wxF+UqE2Fs48nYF7=rWm7E9ipy2Jtmw@mail.gmail.com>
On Sat, 07 Nov 2020 09:07:19 -0600, Adam Ford wrote:
> On Fri, Sep 11, 2020 at 8:54 AM Michael Tretter
> <m.tretter@pengutronix.de> wrote:
> >
> > In commit 05193dc38197 ("drm/bridge: Make the bridge chain a
> > double-linked list") the bridge has been removed and replaced by a
> > private field. Remove the leftover documentation of the removed field.
> >
> > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> What is the status of this series? I know of at least one other patch
> series depending on this.
Sorry for that. I lately didn't have time to work on the series.
There are two big open TODOs:
- How should this bridge react if there is no out bridge available, yet? This
series implements a static approach by returning EPROBE_DEFER from
bridge_attach if there isn't a next bridge, connector or display. Andrezej
suggested a dynamic approach which allows to attach this bridge without a
next bridge and dynamically add further bridges/panels. The latter approach
didn't work with the mxsfb driver, but I didn't have time to look into this.
- The component framework stuff that allows to use the bridge with the Exynos
driver should not go into the bridge driver, but stay in the platform part.
Michael
>
> adam
>
> > ---
> > v2: none
> > ---
> > include/drm/drm_encoder.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/include/drm/drm_encoder.h b/include/drm/drm_encoder.h
> > index a60f5f1555ac..5dfa5f7a80a7 100644
> > --- a/include/drm/drm_encoder.h
> > +++ b/include/drm/drm_encoder.h
> > @@ -89,7 +89,6 @@ struct drm_encoder_funcs {
> > * @head: list management
> > * @base: base KMS object
> > * @name: human readable name, can be overwritten by the driver
> > - * @bridge: bridge associated to the encoder
> > * @funcs: control functions
> > * @helper_private: mid-layer private data
> > *
> > --
> > 2.20.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-10 8:46 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200911165401epcas1p3c7ee84dd01db93f472d6fa21c1100f29@epcas1p3.samsung.com>
2020-09-11 13:53 ` [PATCH v2 00/16] drm/exynos: Convert driver to drm bridge Michael Tretter
2020-09-11 13:53 ` Michael Tretter
2020-09-11 13:53 ` [PATCH v2 01/16] drm/encoder: remove obsolete documentation of bridge Michael Tretter
2020-09-11 13:53 ` Michael Tretter
2020-11-07 15:07 ` Adam Ford
2020-11-07 15:07 ` Adam Ford
2020-11-10 8:46 ` Michael Tretter [this message]
2020-11-10 8:46 ` Michael Tretter
2020-11-07 22:17 ` Sam Ravnborg
2020-11-07 22:17 ` Sam Ravnborg
2020-09-11 13:53 ` [PATCH v2 02/16] drm/exynos: remove in_bridge_node from exynos_dsi Michael Tretter
2020-09-11 13:53 ` Michael Tretter
2020-11-07 22:19 ` Sam Ravnborg
2020-11-07 22:19 ` Sam Ravnborg
2020-11-09 2:24 ` Inki Dae
2020-09-11 13:54 ` [PATCH v2 03/16] drm/exynos: use exynos_dsi as drvdata Michael Tretter
2020-09-11 13:54 ` Michael Tretter
2020-11-07 22:24 ` Sam Ravnborg
2020-11-07 22:24 ` Sam Ravnborg
2020-11-09 2:24 ` Inki Dae
2020-11-09 2:24 ` Inki Dae
2020-09-11 13:54 ` [PATCH v2 04/16] drm/exynos: extract helper functions for probe Michael Tretter
2020-09-11 13:54 ` Michael Tretter
2020-11-07 22:27 ` Sam Ravnborg
2020-11-07 22:27 ` Sam Ravnborg
2020-11-09 2:52 ` Inki Dae
2020-11-09 2:52 ` Inki Dae
2020-09-11 13:54 ` [PATCH v2 05/16] drm/exynos: move dsi host registration to probe Michael Tretter
2020-09-11 13:54 ` Michael Tretter
2020-09-11 13:54 ` [PATCH v2 06/16] drm/exynos: shift register values to fields on write Michael Tretter
2020-09-11 13:54 ` Michael Tretter
2020-11-07 22:39 ` Sam Ravnborg
2020-11-07 22:39 ` Sam Ravnborg
2020-11-10 8:28 ` Michael Tretter
2020-11-10 8:28 ` Michael Tretter
2020-09-11 13:54 ` [PATCH v2 07/16] drm/exynos: use identifier instead of register offsets Michael Tretter
2020-09-11 13:54 ` Michael Tretter
2020-09-11 13:54 ` [PATCH v2 08/16] drm/exynos: add host_ops callback for platform drivers Michael Tretter
2020-09-11 13:54 ` Michael Tretter
2020-09-15 17:07 ` Andrzej Hajda
2020-09-15 17:07 ` Andrzej Hajda
2020-09-15 18:02 ` Michael Tretter
2020-09-15 18:02 ` Michael Tretter
2020-09-16 22:01 ` Andrzej Hajda
2020-09-16 22:01 ` Andrzej Hajda
2020-09-11 13:54 ` [PATCH v2 09/16] drm/exynos: add callback for tearing effect handler Michael Tretter
2020-09-11 13:54 ` Michael Tretter
2020-09-11 13:54 ` [PATCH v2 10/16] drm/exynos: implement a drm bridge Michael Tretter
2020-09-11 13:54 ` Michael Tretter
2020-09-14 8:29 ` Marek Szyprowski
2020-09-14 8:29 ` Marek Szyprowski
2020-09-14 12:31 ` Marek Szyprowski
2020-09-14 12:31 ` Marek Szyprowski
2020-09-14 20:01 ` Michael Tretter
2020-09-14 20:01 ` Michael Tretter
2020-09-14 21:19 ` Andrzej Hajda
2020-09-14 21:19 ` Andrzej Hajda
2020-09-15 19:40 ` Andrzej Hajda
2020-09-15 19:40 ` Andrzej Hajda
2021-02-01 16:33 ` Michael Tretter
2021-02-01 16:33 ` Michael Tretter
2021-02-03 20:31 ` Michael Tretter
2021-02-03 20:31 ` Michael Tretter
2021-02-04 10:17 ` Daniel Vetter
2021-02-04 10:17 ` Daniel Vetter
2021-02-04 10:56 ` Michael Tretter
2021-02-04 10:56 ` Michael Tretter
2021-02-04 16:05 ` Daniel Vetter
2021-02-04 16:05 ` Daniel Vetter
2021-02-04 16:28 ` Andrzej Hajda
2021-02-04 16:28 ` Andrzej Hajda
2021-02-04 17:19 ` Daniel Vetter
2021-02-04 17:19 ` Daniel Vetter
2021-02-04 17:26 ` Laurent Pinchart
2021-02-04 17:26 ` Laurent Pinchart
2021-02-04 17:46 ` Daniel Vetter
2021-02-04 17:46 ` Daniel Vetter
2021-02-10 9:10 ` Frieder Schrempf
2021-02-10 9:10 ` Frieder Schrempf
2021-02-18 8:04 ` Michael Tretter
2021-02-18 8:04 ` Michael Tretter
2021-02-18 16:02 ` Andrzej Hajda
2021-02-18 16:02 ` Andrzej Hajda
2021-02-23 12:07 ` Daniel Vetter
2021-02-23 12:07 ` Daniel Vetter
2021-04-20 11:42 ` Frieder Schrempf
2021-04-20 11:42 ` Frieder Schrempf
2021-04-20 14:27 ` Laurent Pinchart
2021-04-20 14:27 ` Laurent Pinchart
2020-09-11 13:54 ` [PATCH v2 11/16] drm/exynos: convert encoder functions to bridge function Michael Tretter
2020-09-11 13:54 ` Michael Tretter
2020-09-11 13:54 ` [PATCH v2 12/16] drm/exynos: configure mode on drm bridge Michael Tretter
2020-09-11 13:54 ` Michael Tretter
2020-09-11 13:54 ` [PATCH v2 13/16] drm/exynos: get encoder from bridge whenever possible Michael Tretter
2020-09-11 13:54 ` Michael Tretter
2020-09-11 13:54 ` [PATCH v2 14/16] drm/exynos: add API functions for platform drivers Michael Tretter
2020-09-11 13:54 ` Michael Tretter
2020-09-11 13:54 ` [PATCH v2 15/16] drm/exynos: split out platform specific code Michael Tretter
2020-09-11 13:54 ` Michael Tretter
2020-09-11 13:54 ` [PATCH v2 16/16] drm/exynos: move bridge driver to bridges Michael Tretter
2020-09-16 7:58 ` Daniel Vetter
2020-09-16 8:58 ` Michael Tretter
2020-09-16 9:03 ` Daniel Vetter
2020-11-09 3:15 ` [PATCH v2 00/16] drm/exynos: Convert driver to drm bridge Inki Dae
2020-11-09 3:15 ` Inki Dae
2020-11-10 8:13 ` Michael Tretter
2020-11-10 8:13 ` Michael Tretter
2020-11-10 12:34 ` Marek Szyprowski
2020-11-10 12:34 ` Marek Szyprowski
2020-11-10 18:52 ` Sam Ravnborg
2020-11-11 3:04 ` Inki Dae
2020-11-11 3:04 ` Inki Dae
2020-11-11 3:11 ` Inki Dae
2020-11-11 3:11 ` Inki Dae
2020-11-11 10:18 ` Michael Tretter
2020-11-11 10:18 ` Michael Tretter
2020-11-13 9:34 ` Inki Dae
2020-11-13 9:34 ` Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110084601.GD13669@pengutronix.de \
--to=m.tretter@pengutronix.de \
--cc=a.hajda@samsung.com \
--cc=aford173@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jy0922.shim@samsung.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=sw0312.kim@samsung.com \
--cc=sylvester.nawrocki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.