From: Al Viro <viro@zeniv.linux.org.uk>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: fix missing include in asm uaccess.h
Date: Wed, 11 Nov 2020 00:58:26 +0000 [thread overview]
Message-ID: <20201111005826.GY3576660@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20201111004440.8783-1-ansuelsmth@gmail.com>
On Wed, Nov 11, 2020 at 01:44:38AM +0100, Ansuel Smith wrote:
> Fix a compilation error as PF_KTHREAD is defined in linux/sched.h and
> this is missing.
>
> Fixes: df325e05a682 ("arm64: Validate tagged addresses in access_ok()
> called from kernel threads")
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> arch/arm64/include/asm/uaccess.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h
> index 991dd5f031e4..51a4f63f464a 100644
> --- a/arch/arm64/include/asm/uaccess.h
> +++ b/arch/arm64/include/asm/uaccess.h
> @@ -7,6 +7,8 @@
> #ifndef __ASM_UACCESS_H
> #define __ASM_UACCESS_H
>
> +#include <linux/sched.h>
> +
> #include <asm/alternative.h>
> #include <asm/kernel-pgtable.h>
> #include <asm/sysreg.h>
NAK. The real bug is in arch/arm64/include/asm/asm-prototypes.h -
it has no business pulling asm/uaccess.h
Just include linux/uaccess.h instead.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mark Rutland <mark.rutland@arm.com>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: fix missing include in asm uaccess.h
Date: Wed, 11 Nov 2020 00:58:26 +0000 [thread overview]
Message-ID: <20201111005826.GY3576660@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20201111004440.8783-1-ansuelsmth@gmail.com>
On Wed, Nov 11, 2020 at 01:44:38AM +0100, Ansuel Smith wrote:
> Fix a compilation error as PF_KTHREAD is defined in linux/sched.h and
> this is missing.
>
> Fixes: df325e05a682 ("arm64: Validate tagged addresses in access_ok()
> called from kernel threads")
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> arch/arm64/include/asm/uaccess.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h
> index 991dd5f031e4..51a4f63f464a 100644
> --- a/arch/arm64/include/asm/uaccess.h
> +++ b/arch/arm64/include/asm/uaccess.h
> @@ -7,6 +7,8 @@
> #ifndef __ASM_UACCESS_H
> #define __ASM_UACCESS_H
>
> +#include <linux/sched.h>
> +
> #include <asm/alternative.h>
> #include <asm/kernel-pgtable.h>
> #include <asm/sysreg.h>
NAK. The real bug is in arch/arm64/include/asm/asm-prototypes.h -
it has no business pulling asm/uaccess.h
Just include linux/uaccess.h instead.
next prev parent reply other threads:[~2020-11-11 0:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 0:44 [PATCH] arm64: fix missing include in asm uaccess.h Ansuel Smith
2020-11-11 0:44 ` Ansuel Smith
2020-11-11 0:58 ` Al Viro [this message]
2020-11-11 0:58 ` Al Viro
2020-11-11 1:09 ` Al Viro
2020-11-11 1:09 ` Al Viro
2020-11-11 1:19 ` R: " ansuelsmth
2020-11-11 1:19 ` ansuelsmth
2020-11-13 0:48 ` Andrew Morton
2020-11-13 0:48 ` Andrew Morton
2020-11-13 2:40 ` Al Viro
2020-11-13 2:40 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111005826.GY3576660@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=ansuelsmth@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pasha.tatashin@soleen.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.