From: Thomas Zimmermann <tzimmermann@suse.de>
To: alexander.deucher@amd.com, christian.koenig@amd.com,
airlied@linux.ie, daniel@ffwll.ch,
maarten.lankhorst@linux.intel.com, mripard@kernel.org
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [PATCH 7/7] drm/radeon: Move radeon_align_pitch() next to its only caller
Date: Thu, 12 Nov 2020 14:21:17 +0100 [thread overview]
Message-ID: <20201112132117.27228-8-tzimmermann@suse.de> (raw)
In-Reply-To: <20201112132117.27228-1-tzimmermann@suse.de>
Allows to declare the function as static. The tiled parameter is always
false, so it is being removed.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/radeon/radeon_fb.c | 24 ------------------------
drivers/gpu/drm/radeon/radeon_gem.c | 26 +++++++++++++++++++++++++-
drivers/gpu/drm/radeon/radeon_mode.h | 2 --
3 files changed, 25 insertions(+), 27 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c
index c687d14a1b93..0b89dd4f4af6 100644
--- a/drivers/gpu/drm/radeon/radeon_fb.c
+++ b/drivers/gpu/drm/radeon/radeon_fb.c
@@ -30,30 +30,6 @@
#include "radeon.h"
-int radeon_align_pitch(struct radeon_device *rdev, int width, int cpp, bool tiled)
-{
- int aligned = width;
- int align_large = (ASIC_IS_AVIVO(rdev)) || tiled;
- int pitch_mask = 0;
-
- switch (cpp) {
- case 1:
- pitch_mask = align_large ? 255 : 127;
- break;
- case 2:
- pitch_mask = align_large ? 127 : 31;
- break;
- case 3:
- case 4:
- pitch_mask = align_large ? 63 : 15;
- break;
- }
-
- aligned += pitch_mask;
- aligned &= ~pitch_mask;
- return aligned * cpp;
-}
-
void radeon_fbdev_init(struct radeon_device *rdev)
{
struct drm_device *ddev = rdev->ddev;
diff --git a/drivers/gpu/drm/radeon/radeon_gem.c b/drivers/gpu/drm/radeon/radeon_gem.c
index eaf7fc9a7b07..e19956c3309f 100644
--- a/drivers/gpu/drm/radeon/radeon_gem.c
+++ b/drivers/gpu/drm/radeon/radeon_gem.c
@@ -816,6 +816,30 @@ int radeon_gem_op_ioctl(struct drm_device *dev, void *data,
return r;
}
+static int radeon_align_pitch(struct radeon_device *rdev, int width, int cpp)
+{
+ int aligned = width;
+ int align_large = ASIC_IS_AVIVO(rdev);
+ int pitch_mask = 0;
+
+ switch (cpp) {
+ case 1:
+ pitch_mask = align_large ? 255 : 127;
+ break;
+ case 2:
+ pitch_mask = align_large ? 127 : 31;
+ break;
+ case 3:
+ case 4:
+ pitch_mask = align_large ? 63 : 15;
+ break;
+ }
+
+ aligned += pitch_mask;
+ aligned &= ~pitch_mask;
+ return aligned * cpp;
+}
+
int radeon_mode_dumb_create(struct drm_file *file_priv,
struct drm_device *dev,
struct drm_mode_create_dumb *args)
@@ -826,7 +850,7 @@ int radeon_mode_dumb_create(struct drm_file *file_priv,
int r;
args->pitch = radeon_align_pitch(rdev, args->width,
- DIV_ROUND_UP(args->bpp, 8), 0);
+ DIV_ROUND_UP(args->bpp, 8));
args->size = args->pitch * args->height;
args->size = ALIGN(args->size, PAGE_SIZE);
diff --git a/drivers/gpu/drm/radeon/radeon_mode.h b/drivers/gpu/drm/radeon/radeon_mode.h
index 197423ad42c1..50ba2b5edb93 100644
--- a/drivers/gpu/drm/radeon/radeon_mode.h
+++ b/drivers/gpu/drm/radeon/radeon_mode.h
@@ -982,8 +982,6 @@ void radeon_crtc_handle_vblank(struct radeon_device *rdev, int crtc_id);
void radeon_crtc_handle_flip(struct radeon_device *rdev, int crtc_id);
-int radeon_align_pitch(struct radeon_device *rdev, int width, int bpp, bool tiled);
-
/* mst */
int radeon_dp_mst_init(struct radeon_connector *radeon_connector);
int radeon_dp_mst_probe(struct radeon_connector *radeon_connector);
--
2.29.2
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: alexander.deucher@amd.com, christian.koenig@amd.com,
airlied@linux.ie, daniel@ffwll.ch,
maarten.lankhorst@linux.intel.com, mripard@kernel.org
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [PATCH 7/7] drm/radeon: Move radeon_align_pitch() next to its only caller
Date: Thu, 12 Nov 2020 14:21:17 +0100 [thread overview]
Message-ID: <20201112132117.27228-8-tzimmermann@suse.de> (raw)
In-Reply-To: <20201112132117.27228-1-tzimmermann@suse.de>
Allows to declare the function as static. The tiled parameter is always
false, so it is being removed.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/radeon/radeon_fb.c | 24 ------------------------
drivers/gpu/drm/radeon/radeon_gem.c | 26 +++++++++++++++++++++++++-
drivers/gpu/drm/radeon/radeon_mode.h | 2 --
3 files changed, 25 insertions(+), 27 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c
index c687d14a1b93..0b89dd4f4af6 100644
--- a/drivers/gpu/drm/radeon/radeon_fb.c
+++ b/drivers/gpu/drm/radeon/radeon_fb.c
@@ -30,30 +30,6 @@
#include "radeon.h"
-int radeon_align_pitch(struct radeon_device *rdev, int width, int cpp, bool tiled)
-{
- int aligned = width;
- int align_large = (ASIC_IS_AVIVO(rdev)) || tiled;
- int pitch_mask = 0;
-
- switch (cpp) {
- case 1:
- pitch_mask = align_large ? 255 : 127;
- break;
- case 2:
- pitch_mask = align_large ? 127 : 31;
- break;
- case 3:
- case 4:
- pitch_mask = align_large ? 63 : 15;
- break;
- }
-
- aligned += pitch_mask;
- aligned &= ~pitch_mask;
- return aligned * cpp;
-}
-
void radeon_fbdev_init(struct radeon_device *rdev)
{
struct drm_device *ddev = rdev->ddev;
diff --git a/drivers/gpu/drm/radeon/radeon_gem.c b/drivers/gpu/drm/radeon/radeon_gem.c
index eaf7fc9a7b07..e19956c3309f 100644
--- a/drivers/gpu/drm/radeon/radeon_gem.c
+++ b/drivers/gpu/drm/radeon/radeon_gem.c
@@ -816,6 +816,30 @@ int radeon_gem_op_ioctl(struct drm_device *dev, void *data,
return r;
}
+static int radeon_align_pitch(struct radeon_device *rdev, int width, int cpp)
+{
+ int aligned = width;
+ int align_large = ASIC_IS_AVIVO(rdev);
+ int pitch_mask = 0;
+
+ switch (cpp) {
+ case 1:
+ pitch_mask = align_large ? 255 : 127;
+ break;
+ case 2:
+ pitch_mask = align_large ? 127 : 31;
+ break;
+ case 3:
+ case 4:
+ pitch_mask = align_large ? 63 : 15;
+ break;
+ }
+
+ aligned += pitch_mask;
+ aligned &= ~pitch_mask;
+ return aligned * cpp;
+}
+
int radeon_mode_dumb_create(struct drm_file *file_priv,
struct drm_device *dev,
struct drm_mode_create_dumb *args)
@@ -826,7 +850,7 @@ int radeon_mode_dumb_create(struct drm_file *file_priv,
int r;
args->pitch = radeon_align_pitch(rdev, args->width,
- DIV_ROUND_UP(args->bpp, 8), 0);
+ DIV_ROUND_UP(args->bpp, 8));
args->size = args->pitch * args->height;
args->size = ALIGN(args->size, PAGE_SIZE);
diff --git a/drivers/gpu/drm/radeon/radeon_mode.h b/drivers/gpu/drm/radeon/radeon_mode.h
index 197423ad42c1..50ba2b5edb93 100644
--- a/drivers/gpu/drm/radeon/radeon_mode.h
+++ b/drivers/gpu/drm/radeon/radeon_mode.h
@@ -982,8 +982,6 @@ void radeon_crtc_handle_vblank(struct radeon_device *rdev, int crtc_id);
void radeon_crtc_handle_flip(struct radeon_device *rdev, int crtc_id);
-int radeon_align_pitch(struct radeon_device *rdev, int width, int bpp, bool tiled);
-
/* mst */
int radeon_dp_mst_init(struct radeon_connector *radeon_connector);
int radeon_dp_mst_probe(struct radeon_connector *radeon_connector);
--
2.29.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-12 13:21 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 13:21 [PATCH 0/7] drm/radeon: Convert to generic fbdev emulation Thomas Zimmermann
2020-11-12 13:21 ` Thomas Zimmermann
2020-11-12 13:21 ` [PATCH 1/7] drm/fb-helper: Set framebuffer for vga-switcheroo clients Thomas Zimmermann
2020-11-12 13:21 ` Thomas Zimmermann
2020-11-12 13:21 ` [PATCH 2/7] drm/fb-helper: Add hint to enable VT switching during suspend/resume Thomas Zimmermann
2020-11-12 13:21 ` Thomas Zimmermann
2020-11-12 13:21 ` [PATCH 3/7] drm/radeon: Whitespace fixes Thomas Zimmermann
2020-11-12 13:21 ` Thomas Zimmermann
2020-11-12 13:21 ` [PATCH 4/7] drm/radeon: Pin buffers while they are vmap'ed Thomas Zimmermann
2020-11-12 13:21 ` Thomas Zimmermann
2020-11-12 17:16 ` Christian König
2020-11-12 17:16 ` Christian König
2020-11-13 7:59 ` Thomas Zimmermann
2020-11-13 7:59 ` Thomas Zimmermann
2020-11-16 11:28 ` Christian König
2020-11-16 11:28 ` Christian König
2020-11-13 16:27 ` Thomas Zimmermann
2020-11-13 16:27 ` Thomas Zimmermann
2020-11-16 20:07 ` Thomas Zimmermann
2020-11-16 20:07 ` Thomas Zimmermann
2020-11-24 9:16 ` Thomas Zimmermann
2020-11-24 9:16 ` Thomas Zimmermann
2020-11-24 11:30 ` Christian König
2020-11-24 11:30 ` Christian König
2020-11-24 11:44 ` Thomas Zimmermann
2020-11-24 11:44 ` Thomas Zimmermann
2020-11-24 11:54 ` Christian König
2020-11-24 11:54 ` Christian König
2020-11-24 12:15 ` Thomas Zimmermann
2020-11-24 12:15 ` Thomas Zimmermann
2020-11-24 13:36 ` Christian König
2020-11-24 13:36 ` Christian König
2020-11-24 13:56 ` Thomas Zimmermann
2020-11-24 13:56 ` Thomas Zimmermann
2020-11-24 14:06 ` Christian König
2020-11-24 14:06 ` Christian König
2020-11-25 8:28 ` Thomas Zimmermann
2020-11-25 8:28 ` Thomas Zimmermann
2020-11-24 14:09 ` Daniel Vetter
2020-11-24 14:09 ` Daniel Vetter
2020-11-25 8:37 ` Thomas Zimmermann
2020-11-25 8:37 ` Thomas Zimmermann
2020-11-25 10:13 ` Christian König
2020-11-25 10:13 ` Christian König
2020-11-25 10:36 ` Daniel Vetter
2020-11-25 10:36 ` Daniel Vetter
2020-11-25 10:57 ` Christian König
2020-11-25 10:57 ` Christian König
2020-11-25 11:38 ` Thomas Zimmermann
2020-11-25 11:38 ` Thomas Zimmermann
2020-11-25 16:32 ` Daniel Vetter
2020-11-25 16:32 ` Daniel Vetter
2020-11-26 10:15 ` Thomas Zimmermann
2020-11-26 10:15 ` Thomas Zimmermann
2020-11-26 11:04 ` Daniel Vetter
2020-11-26 11:04 ` Daniel Vetter
2020-11-26 11:28 ` Christian König
2020-11-26 11:28 ` Christian König
2020-11-26 11:42 ` Thomas Zimmermann
2020-11-26 11:42 ` Thomas Zimmermann
2020-11-26 11:59 ` Thomas Zimmermann
2020-11-26 11:59 ` Thomas Zimmermann
2020-11-26 12:08 ` Christian König
2020-11-26 12:08 ` Christian König
2020-11-26 12:14 ` Thomas Zimmermann
2020-11-26 12:14 ` Thomas Zimmermann
2020-11-26 12:16 ` Christian König
2020-11-26 12:16 ` Christian König
2020-11-12 13:21 ` [PATCH 5/7] drm/radeon: Replace framebuffer console with generic implementation Thomas Zimmermann
2020-11-12 13:21 ` Thomas Zimmermann
2020-11-12 13:21 ` [PATCH 6/7] drm/radeon: Use fbdev shadow fb Thomas Zimmermann
2020-11-12 13:21 ` Thomas Zimmermann
2020-11-12 13:21 ` Thomas Zimmermann [this message]
2020-11-12 13:21 ` [PATCH 7/7] drm/radeon: Move radeon_align_pitch() next to its only caller Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112132117.27228-8-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.