From: Christoph Hellwig <hch@lst.de>
To: Petr Vorel <pvorel@suse.cz>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Josef Bacik <josef@toxicpanda.com>, Jens Axboe <axboe@kernel.dk>,
Martijn Coenen <maco@android.com>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Hannes Reinecke <hare@suse.de>,
ltp@lists.linux.it
Subject: Re: [PATCH 1/1] loop: Fix occasional uevent drop
Date: Thu, 12 Nov 2020 15:43:07 +0100 [thread overview]
Message-ID: <20201112144307.GA8377@lst.de> (raw)
In-Reply-To: <20201111180846.21515-1-pvorel@suse.cz>
On Wed, Nov 11, 2020 at 07:08:46PM +0100, Petr Vorel wrote:
> 716ad0986cbd caused to occasional drop of loop device uevent, which was
> no longer triggered in loop_set_size() but in a different part of code.
>
> Bug is reproducible with LTP test uevent01 [1]:
>
> i=0; while true; do
> i=$((i+1)); echo "== $i =="
> lsmod |grep -q loop && rmmod -f loop
> ./uevent01 || break
> done
>
> Put back triggering through code called in loop_set_size().
>
> Fix required to add yet another parameter to
> set_capacity_revalidate_and_notify().
I don't like where this is heading, especially as I've rewritten the whole
area pending inclusion for 5.11. I think the you want something like what
I did in this three commits with a loop commit equivalent to the last
commit for nbd:
http://git.infradead.org/users/hch/block.git/commitdiff/89348f9f510d77d0bf69994f096eb6b71199e0f4
http://git.infradead.org/users/hch/block.git/commitdiff/89348f9f510d77d0bf69994f096eb6b71199e0f4
Jens, maybe I should rebase things so that a version of that first
commit can go into 5.10 and stable?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] loop: Fix occasional uevent drop
Date: Thu, 12 Nov 2020 15:43:07 +0100 [thread overview]
Message-ID: <20201112144307.GA8377@lst.de> (raw)
In-Reply-To: <20201111180846.21515-1-pvorel@suse.cz>
On Wed, Nov 11, 2020 at 07:08:46PM +0100, Petr Vorel wrote:
> 716ad0986cbd caused to occasional drop of loop device uevent, which was
> no longer triggered in loop_set_size() but in a different part of code.
>
> Bug is reproducible with LTP test uevent01 [1]:
>
> i=0; while true; do
> i=$((i+1)); echo "== $i =="
> lsmod |grep -q loop && rmmod -f loop
> ./uevent01 || break
> done
>
> Put back triggering through code called in loop_set_size().
>
> Fix required to add yet another parameter to
> set_capacity_revalidate_and_notify().
I don't like where this is heading, especially as I've rewritten the whole
area pending inclusion for 5.11. I think the you want something like what
I did in this three commits with a loop commit equivalent to the last
commit for nbd:
http://git.infradead.org/users/hch/block.git/commitdiff/89348f9f510d77d0bf69994f096eb6b71199e0f4
http://git.infradead.org/users/hch/block.git/commitdiff/89348f9f510d77d0bf69994f096eb6b71199e0f4
Jens, maybe I should rebase things so that a version of that first
commit can go into 5.10 and stable?
next prev parent reply other threads:[~2020-11-12 14:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 18:08 [PATCH 1/1] loop: Fix occasional uevent drop Petr Vorel
2020-11-11 18:08 ` [LTP] " Petr Vorel
2020-11-12 14:43 ` Christoph Hellwig [this message]
2020-11-12 14:43 ` Christoph Hellwig
2020-11-12 15:59 ` Jens Axboe
2020-11-12 15:59 ` [LTP] " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112144307.GA8377@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=maco@android.com \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.