* [PATCH for-next] RDMA/hns: Fix double free of the pointer to TSQ/TPQ
@ 2020-11-12 11:29 Weihang Li
2020-11-12 17:41 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Weihang Li @ 2020-11-12 11:29 UTC (permalink / raw)
To: dledford, jgg; +Cc: leon, linux-rdma, linuxarm
A return statement is omitted after getting HEM table, then the newly
allocated pointer will be freed directly, which will cause a calltrace when
the driver was removed.
Fixes: d6d91e46210f ("RDMA/hns: Add support for configuring GMV table")
Signed-off-by: Weihang Li <liweihang@huawei.com>
---
drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
index 83842cd..4d697e4 100644
--- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
@@ -2582,6 +2582,8 @@ static int hns_roce_v2_init(struct hns_roce_dev *hr_dev)
if (ret)
goto err_get_hem_table_failed;
+ return 0;
+
err_get_hem_table_failed:
hns_roce_free_link_table(hr_dev, &priv->tpq);
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH for-next] RDMA/hns: Fix double free of the pointer to TSQ/TPQ
2020-11-12 11:29 [PATCH for-next] RDMA/hns: Fix double free of the pointer to TSQ/TPQ Weihang Li
@ 2020-11-12 17:41 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2020-11-12 17:41 UTC (permalink / raw)
To: Weihang Li; +Cc: dledford, leon, linux-rdma, linuxarm
On Thu, Nov 12, 2020 at 07:29:42PM +0800, Weihang Li wrote:
> A return statement is omitted after getting HEM table, then the newly
> allocated pointer will be freed directly, which will cause a calltrace when
> the driver was removed.
>
> Fixes: d6d91e46210f ("RDMA/hns: Add support for configuring GMV table")
> Signed-off-by: Weihang Li <liweihang@huawei.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-12 17:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-12 11:29 [PATCH for-next] RDMA/hns: Fix double free of the pointer to TSQ/TPQ Weihang Li
2020-11-12 17:41 ` Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.