From: Sam Ravnborg <sam@ravnborg.org>
To: Jonathan Liu <net147@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Neil Armstrong <narmstrong@baylibre.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Andrzej Hajda <a.hajda@samsung.com>,
linux-rockchip@lists.infradead.org,
Boris Brezillon <boris.brezillon@collabora.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Liu Ying <victor.liu@nxp.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm: bridge: dw-hdmi: Avoid resetting force in the detect function
Date: Thu, 12 Nov 2020 22:22:54 +0100 [thread overview]
Message-ID: <20201112212254.GA3361340@ravnborg.org> (raw)
In-Reply-To: <20201031081747.372599-1-net147@gmail.com>
Hi Jonathan
On Sat, Oct 31, 2020 at 07:17:47PM +1100, Jonathan Liu wrote:
> It has been observed that resetting force in the detect function can
> result in the PHY being powered down in response to hot-plug detect
> being asserted, even when the HDMI connector is forced on.
>
> Enabling debug messages and adding a call to dump_stack() in
> dw_hdmi_phy_power_off() shows the following in dmesg:
> [ 160.637413] dwhdmi-rockchip ff940000.hdmi: EVENT=plugin
> [ 160.637433] dwhdmi-rockchip ff940000.hdmi: PHY powered down in 0 iterations
>
> Call trace:
> dw_hdmi_phy_power_off
> dw_hdmi_phy_disable
> dw_hdmi_update_power
> dw_hdmi_detect
> dw_hdmi_connector_detect
> drm_helper_probe_detect_ctx
> drm_helper_hpd_irq_event
> dw_hdmi_irq
> irq_thread_fn
> irq_thread
> kthread
> ret_from_fork
>
> Fixes: 381f05a7a842 ("drm: bridge/dw_hdmi: add connector mode forcing")
> Signed-off-by: Jonathan Liu <net147@gmail.com>
Applied to drm-misc-fixes.
Sam
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Jonathan Liu <net147@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Neil Armstrong <narmstrong@baylibre.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Andrzej Hajda <a.hajda@samsung.com>,
linux-rockchip@lists.infradead.org,
Boris Brezillon <boris.brezillon@collabora.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Liu Ying <victor.liu@nxp.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm: bridge: dw-hdmi: Avoid resetting force in the detect function
Date: Thu, 12 Nov 2020 22:22:54 +0100 [thread overview]
Message-ID: <20201112212254.GA3361340@ravnborg.org> (raw)
In-Reply-To: <20201031081747.372599-1-net147@gmail.com>
Hi Jonathan
On Sat, Oct 31, 2020 at 07:17:47PM +1100, Jonathan Liu wrote:
> It has been observed that resetting force in the detect function can
> result in the PHY being powered down in response to hot-plug detect
> being asserted, even when the HDMI connector is forced on.
>
> Enabling debug messages and adding a call to dump_stack() in
> dw_hdmi_phy_power_off() shows the following in dmesg:
> [ 160.637413] dwhdmi-rockchip ff940000.hdmi: EVENT=plugin
> [ 160.637433] dwhdmi-rockchip ff940000.hdmi: PHY powered down in 0 iterations
>
> Call trace:
> dw_hdmi_phy_power_off
> dw_hdmi_phy_disable
> dw_hdmi_update_power
> dw_hdmi_detect
> dw_hdmi_connector_detect
> drm_helper_probe_detect_ctx
> drm_helper_hpd_irq_event
> dw_hdmi_irq
> irq_thread_fn
> irq_thread
> kthread
> ret_from_fork
>
> Fixes: 381f05a7a842 ("drm: bridge/dw_hdmi: add connector mode forcing")
> Signed-off-by: Jonathan Liu <net147@gmail.com>
Applied to drm-misc-fixes.
Sam
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Jonathan Liu <net147@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Neil Armstrong <narmstrong@baylibre.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Andrzej Hajda <a.hajda@samsung.com>,
linux-rockchip@lists.infradead.org,
Boris Brezillon <boris.brezillon@collabora.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Liu Ying <victor.liu@nxp.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm: bridge: dw-hdmi: Avoid resetting force in the detect function
Date: Thu, 12 Nov 2020 22:22:54 +0100 [thread overview]
Message-ID: <20201112212254.GA3361340@ravnborg.org> (raw)
In-Reply-To: <20201031081747.372599-1-net147@gmail.com>
Hi Jonathan
On Sat, Oct 31, 2020 at 07:17:47PM +1100, Jonathan Liu wrote:
> It has been observed that resetting force in the detect function can
> result in the PHY being powered down in response to hot-plug detect
> being asserted, even when the HDMI connector is forced on.
>
> Enabling debug messages and adding a call to dump_stack() in
> dw_hdmi_phy_power_off() shows the following in dmesg:
> [ 160.637413] dwhdmi-rockchip ff940000.hdmi: EVENT=plugin
> [ 160.637433] dwhdmi-rockchip ff940000.hdmi: PHY powered down in 0 iterations
>
> Call trace:
> dw_hdmi_phy_power_off
> dw_hdmi_phy_disable
> dw_hdmi_update_power
> dw_hdmi_detect
> dw_hdmi_connector_detect
> drm_helper_probe_detect_ctx
> drm_helper_hpd_irq_event
> dw_hdmi_irq
> irq_thread_fn
> irq_thread
> kthread
> ret_from_fork
>
> Fixes: 381f05a7a842 ("drm: bridge/dw_hdmi: add connector mode forcing")
> Signed-off-by: Jonathan Liu <net147@gmail.com>
Applied to drm-misc-fixes.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Jonathan Liu <net147@gmail.com>
Cc: linux-rockchip@lists.infradead.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Fabio Estevam <fabio.estevam@freescale.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Neil Armstrong <narmstrong@baylibre.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Liu Ying <victor.liu@nxp.com>
Subject: Re: [PATCH] drm: bridge: dw-hdmi: Avoid resetting force in the detect function
Date: Thu, 12 Nov 2020 22:22:54 +0100 [thread overview]
Message-ID: <20201112212254.GA3361340@ravnborg.org> (raw)
In-Reply-To: <20201031081747.372599-1-net147@gmail.com>
Hi Jonathan
On Sat, Oct 31, 2020 at 07:17:47PM +1100, Jonathan Liu wrote:
> It has been observed that resetting force in the detect function can
> result in the PHY being powered down in response to hot-plug detect
> being asserted, even when the HDMI connector is forced on.
>
> Enabling debug messages and adding a call to dump_stack() in
> dw_hdmi_phy_power_off() shows the following in dmesg:
> [ 160.637413] dwhdmi-rockchip ff940000.hdmi: EVENT=plugin
> [ 160.637433] dwhdmi-rockchip ff940000.hdmi: PHY powered down in 0 iterations
>
> Call trace:
> dw_hdmi_phy_power_off
> dw_hdmi_phy_disable
> dw_hdmi_update_power
> dw_hdmi_detect
> dw_hdmi_connector_detect
> drm_helper_probe_detect_ctx
> drm_helper_hpd_irq_event
> dw_hdmi_irq
> irq_thread_fn
> irq_thread
> kthread
> ret_from_fork
>
> Fixes: 381f05a7a842 ("drm: bridge/dw_hdmi: add connector mode forcing")
> Signed-off-by: Jonathan Liu <net147@gmail.com>
Applied to drm-misc-fixes.
Sam
next prev parent reply other threads:[~2020-11-12 21:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 8:17 [PATCH] drm: bridge: dw-hdmi: Avoid resetting force in the detect function Jonathan Liu
2020-10-31 8:17 ` Jonathan Liu
2020-10-31 8:17 ` Jonathan Liu
2020-10-31 8:17 ` Jonathan Liu
2020-11-08 9:53 ` Sam Ravnborg
2020-11-08 9:53 ` Sam Ravnborg
2020-11-08 9:53 ` Sam Ravnborg
2020-11-08 9:53 ` Sam Ravnborg
2020-11-08 9:57 ` Russell King - ARM Linux admin
2020-11-08 9:57 ` Russell King - ARM Linux admin
2020-11-08 9:57 ` Russell King - ARM Linux admin
2020-11-08 9:57 ` Russell King - ARM Linux admin
2020-11-08 10:47 ` Sam Ravnborg
2020-11-08 10:47 ` Sam Ravnborg
2020-11-08 10:47 ` Sam Ravnborg
2020-11-08 10:47 ` Sam Ravnborg
2020-11-11 7:57 ` Jonathan Liu
2020-11-11 7:59 ` Jonathan Liu
2020-11-11 7:59 ` Jonathan Liu
2020-11-11 7:59 ` Jonathan Liu
2020-11-11 7:59 ` Jonathan Liu
2020-11-12 21:22 ` Sam Ravnborg [this message]
2020-11-12 21:22 ` Sam Ravnborg
2020-11-12 21:22 ` Sam Ravnborg
2020-11-12 21:22 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112212254.GA3361340@ravnborg.org \
--to=sam@ravnborg.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@freescale.com \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=narmstrong@baylibre.com \
--cc=net147@gmail.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.